MIME-Version: 1.0
From: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Date: Tue, 22 May 2018 11:35:32 +0530
Message-ID: 
 <CAM9w-_ntCUguZp2rVJXPsDvWJbWneAz4-AHJoYB+nUTSYMXc9g@mail.gmail.com>
Subject: [pgAdmin4][RM#3289] Can't query SQL_ASCII database.
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000c78af7056cc5340c"
Precedence: bulk

--000000000000c78af7056cc5340c
Content-Type: multipart/alternative; boundary="000000000000c78af2056cc5340a"

--000000000000c78af2056cc5340a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hackers,

PFA patch for RM#3289 where decode error was thrown on querying a SQL_ASCII
database table. Please note, this problem occurs only on windows.
Sample insert - insert into test_tab values ('=C3=A9');

psycopg2 has a encodings dictionary where Postgres Database Encodings are
mapped to python equivalent. It uses 'ascii' decoder of python to decode
for SQL_ASCII encoding. If data has characters beyond the limit of ascii
then it failed. The solution would be to use utf_8 decoder instead of
ascii. I tried setting the client_encoding using
set_client_encoding('UTF8') method of a psycopg2 connection but no luck
(also its not allowed for async connection). I also tried executing "SET
CLIENT_ENCODING=3D'UTF8'" but it didn't work too.
So, as in the patch, I had to set encodings dict value directly to 'utf_8'
and it seems to be working. Please note, the same is added to psycopg3
milestones
https://github.com/psycopg/psycopg2/milestone/4

Also fixed a small glitch for sql editor connection status check.

Kindly review.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

--000000000000c78af2056cc5340a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Hackers,</div><div><br></div><div>PFA patch for RM=
#3289 where decode error was thrown on querying a SQL_ASCII database table.=
 Please note, this problem occurs only on windows.</div><div>Sample insert =
-=C2=A0insert into test_tab values (&#39;=C3=A9&#39;);</div><div><br></div>=
<div>psycopg2 has a encodings dictionary where Postgres Database Encodings =
are mapped to python equivalent. It uses &#39;ascii&#39; decoder of python =
to decode for SQL_ASCII encoding. If data has characters beyond the limit o=
f ascii then it failed. The solution would be to use utf_8 decoder instead =
of ascii. I tried setting the client_encoding using set_client_encoding(=
9;UTF8&#39;) method of a psycopg2 connection but no luck (also its not allo=
wed for async connection). I also tried executing &quot;SET CLIENT_ENCODING=
=3D&#39;UTF8&#39;&quot; but it didn&#39;t work too.</div><div>So, as in the=
 patch, I had to set encodings dict value directly to &#39;utf_8&#39; and i=
t seems to be working. Please note, the same is added to psycopg3 milestone=
s</div><div><a href=3D"https://github.com/psycopg/psycopg2/milestone/4">htt=
ps://github.com/psycopg/psycopg2/milestone/4</a></div><div><br></div><div>A=
lso fixed a small glitch for sql editor connection status check.</div><div>=
<br></div><div>Kindly review.</div><br clear=3D"all"><div><div class=3D"gma=
il_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><font face=3D"trebuche=
t ms, sans-serif" size=3D"2" color=3D"#000000">Thanks and Regards,</font><d=
iv><span style=3D"background-color:rgb(255,255,255)"><font face=3D"trebuche=
t ms, sans-serif" size=3D"2" color=3D"#000000">Aditya Toshniwal</font></spa=
n></div><div><span style=3D"background-color:rgb(255,255,255)"><font face=
=3D"trebuchet ms, sans-serif" size=3D"2" color=3D"#000000">Software Enginee=
r |=C2=A0EnterpriseDB Software Solutions |=C2=A0</font></span><span style=
=3D"color:rgb(0,0,0);font-family:&quot;trebuchet ms&quot;,sans-serif;font-s=
ize:small">Pune</span></div><div><span style=3D"font-family:&quot;trebuchet=
 ms&quot;,sans-serif;font-size:x-small"><font color=3D"#38761d">&quot;Don&#=
39;t Complain about Heat, Plant a tree&quot;</font></span></div></div></div=
></div></div></div>
</div>

--000000000000c78af2056cc5340a--

--000000000000c78af7056cc5340c
Content-Type: application/octet-stream; name="RM3289.patch"
Content-Disposition: attachment; filename="RM3289.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_jhh9yw3r0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5weSBiL3dl
Yi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5weQppbmRleCBjNzI1MDVhNC4uYWVj
M2ZhYmEgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5w
eQorKysgYi93ZWIvcGdhZG1pbi90b29scy9zcWxlZGl0b3IvX19pbml0X18ucHkKQEAgLTE0NzQs
NyArMTQ3NCw3IEBAIGRlZiBxdWVyeV90b29sX3N0YXR1cyh0cmFuc19pZCk6CiAgICAgICAgICAg
ICBlcnJvcm1zZz1lcnJvcl9tc2cKICAgICAgICAgKQogCi0gICAgaWYgY29ubiBhbmQgdHJhbnNf
b2JqIGFuZCBzZXNzaW9uX29iajoKKyAgICBpZiBjb25uIGFuZCB0cmFuc19vYmogYW5kIHNlc3Np
b25fb2JqIGFuZCBjb25uLnRyYW5zYWN0aW9uX3N0YXR1cygpIGlzIG5vdCBOb25lOgogICAgICAg
ICBzdGF0dXMgPSBjb25uLnRyYW5zYWN0aW9uX3N0YXR1cygpCiAgICAgICAgIHJldHVybiBtYWtl
X2pzb25fcmVzcG9uc2UoCiAgICAgICAgICAgICBkYXRhPXsKZGlmZiAtLWdpdCBhL3dlYi9wZ2Fk
bWluL3V0aWxzL2RyaXZlci9wc3ljb3BnMi9jb25uZWN0aW9uLnB5IGIvd2ViL3BnYWRtaW4vdXRp
bHMvZHJpdmVyL3BzeWNvcGcyL2Nvbm5lY3Rpb24ucHkKaW5kZXggMzE1NjMxYzAuLmVhOTBlNjJm
IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi91dGlscy9kcml2ZXIvcHN5Y29wZzIvY29ubmVjdGlv
bi5weQorKysgYi93ZWIvcGdhZG1pbi91dGlscy9kcml2ZXIvcHN5Y29wZzIvY29ubmVjdGlvbi5w
eQpAQCAtNDksNiArNDksOSBAQCBlbHNlOgogCiBfID0gZ2V0dGV4dAogCisjIFVzZSB1dGZfOCBk
ZWNvZGVyIGluc3RlYWQgb2YgYXNjaWkgZm9yIFNRTF9BU0NJSSBkYXRhYmFzZSB0byBhdm9pZCBk
ZWNvZGUgZXJyb3JzCitlbmNvZGluZ3NbJ1NRTF9BU0NJSSddID0gJ3V0Zl84JworZW5jb2Rpbmdz
WydTUUxBU0NJSSddID0gJ3V0Zl84JwogCiAjIFJlZ2lzdGVyIGdsb2JhbCB0eXBlIGNhc3RlciB3
aGljaCB3aWxsIGJlIGFwcGxpY2FibGUgdG8gYWxsIGNvbm5lY3Rpb25zLgogcmVnaXN0ZXJfZ2xv
YmFsX3R5cGVjYXN0ZXJzKCkK
--000000000000c78af7056cc5340c--