public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][RM7172] Validation error block user from entering input
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][RM7172] Validation error block user from entering input
@ 2022-03-04 09:44 Aditya Toshniwal <[email protected]>
2022-03-04 11:56 ` Re: [pgAdmin][RM7172] Validation error block user from entering input Akshay Joshi <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Toshniwal @ 2022-03-04 09:44 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Attached patch will add margin to form when a validation error occurs, so
that the user can scroll and enter input.
Please review.
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM7172.patch (1.6K, 3-RM7172.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/SchemaView/FormView.jsx b/web/pgadmin/static/js/SchemaView/FormView.jsx
index 8c8e5b9fb..684390d7f 100644
--- a/web/pgadmin/static/js/SchemaView/FormView.jsx
+++ b/web/pgadmin/static/js/SchemaView/FormView.jsx
@@ -39,6 +39,10 @@ const useStyles = makeStyles((theme)=>({
nestedControl: {
height: 'unset',
},
+ errorMargin: {
+ /* Error footer margin */
+ marginBottom: '36px',
+ },
sqlTabInput: {
border: 0,
}
@@ -368,7 +372,6 @@ export default function FormView({
onChange={(event, selTabValue) => {
setTabValue(selTabValue);
}}
- // indicatorColor="primary"
variant="scrollable"
scrollButtons="auto"
action={(ref)=>ref && ref.updateIndicator()}
@@ -379,9 +382,13 @@ export default function FormView({
</Tabs>
</Box>
{Object.keys(finalTabs).map((tabName, i)=>{
+ let contentClassName = null;
+ if(fullTabs.indexOf(tabName) == -1) {
+ contentClassName = clsx(classes.nestedControl, stateUtils.formErr.message ? classes.errorMargin : null);
+ }
return (
<TabPanel key={tabName} value={tabValue} index={i} classNameRoot={clsx(tabsClassname[tabName], isNested ? classes.nestedTabPanel : null)}
- className={fullTabs.indexOf(tabName) == -1 ? classes.nestedControl : null}>
+ className={contentClassName}>
{finalTabs[tabName]}
</TabPanel>
);
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][RM7172] Validation error block user from entering input
2022-03-04 09:44 [pgAdmin][RM7172] Validation error block user from entering input Aditya Toshniwal <[email protected]>
@ 2022-03-04 11:56 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2022-03-04 11:56 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers
Thanks, the patch applied
On Fri, Mar 4, 2022 at 3:15 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> Attached patch will add margin to form when a validation error occurs, so
> that the user can scroll and enter input.
> Please review.
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com;
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-03-04 11:56 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-03-04 09:44 [pgAdmin][RM7172] Validation error block user from entering input Aditya Toshniwal <[email protected]>
2022-03-04 11:56 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox