Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdUfA-00014p-C8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Jun 2019 07:05:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hdUf8-00052T-8f for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Jun 2019 07:05:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdUf7-0004ys-LH for pgadmin-hackers@lists.postgresql.org; Wed, 19 Jun 2019 07:05:42 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hdUf3-0007Ey-RS for pgadmin-hackers@postgresql.org; Wed, 19 Jun 2019 07:05:40 +0000 Received: by mail-lj1-x243.google.com with SMTP id r9so2142544ljg.5 for ; Wed, 19 Jun 2019 00:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EseO0UBQ5zpBcxw9PALFfwx84pJT0VXA1XoTUVlH8Aw=; b=ID1+JrH8quAelFchK0ecWpK30+ufl7iX+vjYTjcmK3cjJrrS3dI3gu3C5RXRnOBFRb ldTOjaXlcR3IVJWgbI9zK2DUab9h0bycCzoEhX1EF6LUPLhQpLzcKliBgy526+gciVQm oWZUE05z1V5s3IRUiaZ3euWBCWd43L84A27OlCmAxUqeWe+rc8s88bH2k4WwBY9JsTul dbIfx30GQij0P3fWQBcXadejt0ZqBiWG1n2MU2Z6OBzps6O0ukA1AUtceRdy3tC9knO/ p4wemg0hloKJuybjyIF3h2izBlbbAcYrYSR9ps3XNYVgcpLPRPf+mitsebFlG2qUqNHN AMmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EseO0UBQ5zpBcxw9PALFfwx84pJT0VXA1XoTUVlH8Aw=; b=qbXn5iGd2+bbWOn/DJWX2V7UJEsDeFQ0ABVLrYQya9Lc5uYK6Q5MJWplcukbCp5P/9 1VVUSvbT9lpSq/Ah8wr3L19YKio03K/bdB97wbPrw3YfTX5xSr0U8/z9Ik64AXaXgfWy JMsfITnqQo5rYXTO+HDRAS6lnohJQscf682e0yfJDMYAMBhY6q1UjsV6rwIQBI1MWhw0 8cDztC3k3fBodb6ki0/k6Q2hijVC/ssPevIgdsau/Y73ij9rwvqpQevMEdibwqAn3Aos PGwgvSoQKv7Pvvm4mgXVR0f9EZfuKbP8gNtPQdwegDonLHD1TcN2M17UM7cwrlSMHD8t AHTA== X-Gm-Message-State: APjAAAUVGD3rYC746B6D4GYFAqpW7JGQBH2DXuqT/biXfwQne1JyhY1h gWmTgJU+3WOKigt0OFvwCgmrEj/x0uUT0csjmi0oGw== X-Google-Smtp-Source: APXvYqy4lTz5TDKqgvfavu/p0VA7Qw3aPvj0vL3JiFtq1066SZRMnP114ycd2zICvn9Kt/6DE5t5HZWVu0jKDGRtkM8= X-Received: by 2002:a2e:9d4e:: with SMTP id y14mr37290183ljj.199.1560927935092; Wed, 19 Jun 2019 00:05:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 19 Jun 2019 12:34:58 +0530 Message-ID: Subject: Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs To: Dave Page Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000001780cf058ba7dbd0" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001780cf058ba7dbd0 Content-Type: multipart/alternative; boundary="0000000000001780ce058ba7dbce" --0000000000001780ce058ba7dbce Content-Type: text/plain; charset="UTF-8" Hi, This is not working on Python 2.7 :( Attached patch will add an __init__ file in the utils directory under debugger to make it work with python 2.7 On Fri, Jun 14, 2019 at 5:17 PM Dave Page wrote: > Thanks, applied. > > On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> I have missed a line while implementing this. Attached is the patch to >> fix that. >> Although it has not caused any trouble, but still it should be changed. >> Kindly review. >> >> On Mon, Jun 10, 2019 at 7:28 PM Dave Page wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the updated patch with fixes. >>>> >>>> On Mon, Jun 10, 2019 at 12:58 PM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Hi Aditya >>>>> >>>>> Following are the review comments: >>>>> >>>>> - "Set breakpoint" option not working, when click it throws an >>>>> error. >>>>> >>>>> Fixed. >>>> >>>>> >>>>> - Create an empty function and try to debug that. It should show >>>>> proper error message. >>>>> >>>>> This seems to be a bug in the debugger itself. I'll raise a bug with >>>> simulation steps if it is. But, not sure where to raise. >>>> >>>>> >>>>> - Got the following backend error when closing the connection, >>>>> please fix this: >>>>> - File >>>>> "E:\Projects\pgadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, >>>>> in close_debugger_session >>>>> conn_id=dbg_obj['exe_conn_id']) >>>>> >>>>> Fixed. >>>> >>>>> >>>>> On Fri, Jun 7, 2019 at 12:21 PM Aditya Toshniwal < >>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Attached is the patch for debugger improvements. The changes include: >>>>>> 1) Change the way debug info is stored in session. Removed redundant >>>>>> session related code in debugger code. All the session related handling >>>>>> done at one place. >>>>>> 2) Fixed a bug where debugger was not opening for EPAS package >>>>>> function. >>>>>> 3) If a package is defined without body and we try to debug a >>>>>> proc/func, the debugger opened a blank window. Changes made so that it will >>>>>> throw error as "XYZ is not defined in package body." >>>>>> >>>>>> -- >>>>>> Thanks and Regards, >>>>>> Aditya Toshniwal >>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> >>>>> *Sr. Software Architect* >>>>> *EnterpriseDB Software India Private Limited* >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --0000000000001780ce058ba7dbce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

This is not working on Python 2.7 :(
Attached patch = will add an __init__ file in the utils directory under debugger to make it = work with python 2.7


On Fri, Jun 14, 2019 at 5:17 PM Dave Page &l= t;dpage@pgadmin.org> wrote:
=
Th= anks, applied.

On Fri, Jun 14, 2019 at 10:38 AM Aditya Toshniwal <aditya.to= shniwal@enterprisedb.com> wrote:
Hi Hackers,

I have missed a line w= hile implementing this. Attached is the patch to fix that.
Although it has= not caused any trouble, but still it should be changed.
Kindly review.

On Mon, Jun 10, 2019 at 7:28 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch= applied.

On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal <aditya.toshniwal@= enterprisedb.com> wrote:
Hi Hackers,

Attached is t= he updated patch with fixes.

On Mon, Jun 10, 2019 at 12:58 PM Akshay J= oshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya

Following are the review comments:
  • "Set breakp= oint" option not working, when click it throws an error.
Fixed.=C2=A0
  • Create an empty functio= n and try to debug that. It should show proper error message.
This seems to be a bug in the debugger itself. I'= ll raise a bug with simulation steps if it is. But, not sure where to raise= .
  • Got the following backend error when closing the conn= ection, please fix this:
    • =C2=A0 =C2=A0 File "E:\Projects\p= gadmin4\web\pgadmin\tools\debugger\__init__.py", line 2053, in close_d= ebugger_session
      =C2=A0 =C2=A0 conn_id=3Ddbg_obj['exe_conn_id'])<= /li>
Fixed.=C2=A0

On Fri, Jun 7, 2019 at 12:21 PM Aditya To= shniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

At= tached is the patch for debugger improvements. The changes include:
1) Change the way debug info is= stored in session. Removed redundant session related code in debugger code= . All the session related handling done at one place.
2) Fixed a bug where debugger was not opening= for EPAS package function.
3)= If a package is defined without body and we try to debug a proc/func, the = debugger opened a blank window. Changes made so that it will throw error as= "XYZ is not defined in package body."

-- =
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0En= terpriseDB India |=C2=A0Pune=
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi<= /div>
Sr. Softwar= e Architect
EnterpriseD= B Software India Private Limited
Mobile: +91 976-788-82= 46


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0Enterpri= seDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitt= er: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postg= reSQL Company


--
Thanks and Regards,=
Aditya Toshniwal<= /span>
Software Engi= neer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TR= EE"


--
Dave Page
Blog: http://pgsnake.blog= spot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.comThe Enterprise PostgreSQL Company


--
Adi= tya Toshniwal
Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"
--0000000000001780ce058ba7dbce-- --0000000000001780cf058ba7dbd0 Content-Type: application/octet-stream; name="debugger.py27.patch" Content-Disposition: attachment; filename="debugger.py27.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jx2w5ho80 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL3V0aWxzL19faW5pdF9fLnB5 IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvdXRpbHMvX19pbml0X18ucHkKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAuLmU2OWRlMjliCg== --0000000000001780cf058ba7dbd0--