Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiHlW-0006XU-Bd for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 12:52:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iiHlU-0007J8-Su for pgadmin-hackers@arkaria.postgresql.org; Fri, 20 Dec 2019 12:52:20 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iiHlU-0007J1-Do for pgadmin-hackers@lists.postgresql.org; Fri, 20 Dec 2019 12:52:20 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iiHlR-0005jc-A9 for pgadmin-hackers@postgresql.org; Fri, 20 Dec 2019 12:52:19 +0000 Received: by mail-ed1-x52a.google.com with SMTP id t17so8132811eds.6 for ; Fri, 20 Dec 2019 04:52:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UxlswQ2Bvfp7ISoYfWCqWgYajMlvOSlCtcG2XtJsAEw=; b=vhCWY3Pd0AdXIXoETlafK8+9Z1mB5z3vl15bao/AsXUeUnDL/BPGmDuOZdax1xkgxu P2Dltnv3afKH+85EMTOjjcmtJTDhgwGjC1G6t/esswJJttgL1TLzJ9rvUeLUXUeGG8Kc 1UNyVzgHLpwqoWZ34SEXzey+QxyUoTkeVgOFFCstxacQcy7KiG8WMb8UlpobYsvUHyOf 6e6WPlRLMYJcbtLsJjpBRBfDgMxoqbGffHL16gbLl0nkj03VARMuuXdRVfuU7EIyRlKo +MFcn+wIwjigsb9QNI8ZmCbD+QVmZnegKqo+c2MuL5fQVD/CjkJt3tX2ePM43u+AhGIV SfYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UxlswQ2Bvfp7ISoYfWCqWgYajMlvOSlCtcG2XtJsAEw=; b=niojp09n4XX1etwDRLg1WfBHeJH7VOfgzZysTxAlWkX9vklK7xSIvyhsbDloQQfiA2 lrH8c2gedzPWeW2e23Wnho1eGeboKRfFGK1kh8IRUKN0k+tuCWl1eO9Jz2J76fk4nvBm oLVC+rTqEbW3x69aFLw/Q0d1V+zZ/spfGrNjSB5+u4TqI0GDQnPLhcGLmhRhRhkJ11y4 q4D08L9YC4Kzz1eoSyyRI7gscLYxQOgY8AFTipvSbT6weGUOhQBNGA3jUKbyd3yQ6MTI Np7ZqAeGyAP59G73q5JRg1IDXkp30b/k+SLuvP3IU7eL+bYweB05RQFHpJRJeOEk9/2f Hhkg== X-Gm-Message-State: APjAAAW+dwABnjF698ZGKL4+JrJlJ/3V1xrkhdGRHLVlDGY9LK6vSNPc pofG3xvcDMyn0o8D2F3rrXMIXNWUuQ7aAKFzPhvg3WAXBWDQzmMGDD1Zk+kVhPQI7CGbCPKW6ds fWh+n1Z4iSio4AvG6XEAkfM3HkA/L7O9FmynSVVeY+6UGZYZFid9NVeYEPs018ydOlU0ntxV8xH jcUGfD3d5iraGbObNa5KoLOGXU/ZHu6UyI5cMZvZqYcyshHQvJViA= X-Google-Smtp-Source: APXvYqy3LLQdfp45S6SO2SaLnO3lkZ/jNoNwRRNlRQ6/D7ylAKodAhOyoKRdejSOojdWgrTLpm5Pv3HZz3zab9VndFg= X-Received: by 2002:a50:eb04:: with SMTP id y4mr15318697edp.170.1576846335408; Fri, 20 Dec 2019 04:52:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Fri, 20 Dec 2019 18:21:39 +0530 Message-ID: Subject: Re: [pgAdmin][RM5017] Use cheroot as default production server To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000b0316d059a2225cc" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000b0316d059a2225cc Content-Type: text/plain; charset="UTF-8" Hi Ashesh, I had tried with - https://newrelic.com/ API to check Flask app performance. To be honest, there was not a great difference in the performance. Per new relic, cheroot used slightly less CPU, with more RPM and, with less response time. Anyway, flask is still not recommended and cheroot looks a good option as it is pure python and supports almost all OS. On Fri, Dec 20, 2019 at 1:34 PM Ashesh Vashi wrote: > Have you seen any improvements in performance? > > On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to use https://pypi.org/project/cheroot/ instead >> of current flask dev server. cheroot is a stable production ready server. >> Plus, flask dev server is not recommended for production. >> Code is changed to use cheroot only when DEBUG is False, otherwise you >> the default flask server. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" --000000000000b0316d059a2225cc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ashesh,

I had tried with -=C2=A0https://new= relic.com/=C2=A0API to check Flask app performance. To be=C2=A0honest, = there was not a great difference in the performance.=C2=A0
Per new relic, = cheroot used slightly less CPU, with more RPM and, with less response time.=
Anyway, flask is still not recommended=C2=A0and cheroot looks a good optio= n as it is pure python and supports almost all OS.

On Fri, Dec 20, 201= 9 at 1:34 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Have you seen any improv= ements in performance?=C2=A0

On Tue, 17 Dec 2019, 15:16 Aditya Toshniwal, = <= aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is t= he patch to use=C2=A0https://pypi.org/project/cheroot/=C2=A0instead of current flask dev = server. cheroot is a stable production ready server. Plus, flask dev server= is not recommended for production.
Code is changed to use cheroot only whe= n DEBUG is False, otherwise=C2=A0you the default flask server.
Kindly review.

--
Thanks and Regar= ds,
Aditya Toshniwal
Sr. Softwa= re Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Pl= ant a TREE"


--
Thanks and Regards,Aditya Toshniwal
pgAdmin Hacker | Sr. S= oftware Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat= , Plant a TREE"
=
--000000000000b0316d059a2225cc--