public inbox for [email protected]
help / color / mirror / Atom feedFrom: Aditya Toshniwal <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][patch] Partition node related fixes
Date: Wed, 6 Oct 2021 16:37:20 +0530
Message-ID: <CAM9w-_nykH8mrdGUa9MNrErZ=WVaNVE9WuzU55cxHY1bUSDtJQ@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDf6Wia8QL7x=xxVKfwfj6ip9b29o0qurF17NPutoBywjA@mail.gmail.com>
References: <CAM9w-_nijDb7aVsamVnroUH9edmXaXi0En2Qtf8LOJD8=F-GUQ@mail.gmail.com>
<CANxoLDf6Wia8QL7x=xxVKfwfj6ip9b29o0qurF17NPutoBywjA@mail.gmail.com>
Hi Hackers,
The nodes index, RLS policy, rules, triggers are failing to save for
partitions. Please review the attached patch to fix the issue.
On Wed, Oct 6, 2021 at 2:54 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Wed, Oct 6, 2021 at 12:25 PM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please review the attached patch which fixes:
>> 1. Unable to create trigger for partition table. Fixes #6867.
>> 2. Unable to create index, RLS policy, rules, triggers for partition.
>> Fixes #6868.
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Software Architect | *edbpostgres.com*
>> <http://edbpostgres.com;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | *edbpostgres.com*
<http://edbpostgres.com;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[application/octet-stream] RM6868.part2.patch (2.6K, 3-RM6868.part2.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js
index 2d1348305..917666161 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.js
@@ -158,7 +158,7 @@ define('pgadmin.node.index', [
tablespaceList: ()=>getNodeListByName('tablespace', treeNodeInfo, itemNodeData, {}, (m)=>{
return (m.label != 'pg_global');
}),
- amnameList : ()=>getNodeAjaxOptions('get_access_methods', nodeObj, treeNodeInfo, itemNodeData),
+ amnameList : ()=>getNodeAjaxOptions('get_access_methods', nodeObj, treeNodeInfo, itemNodeData, {jumpAfterNode: 'schema'}),
columnList: ()=>getNodeListByName('column', treeNodeInfo, itemNodeData, {}),
},
{
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js
index 73f8eda22..5eab1b66f 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/static/js/index.ui.js
@@ -263,7 +263,6 @@ export default class IndexSchema extends BaseUISchema {
readonly: function (state) {
return !indexSchemaObj.isNew(state);
},
- url_jump_after_node: 'schema',
group: gettext('Definition'),
type: () => {
return {
diff --git a/web/pgadmin/browser/static/js/node_view.jsx b/web/pgadmin/browser/static/js/node_view.jsx
index fbb922058..e67a500d8 100644
--- a/web/pgadmin/browser/static/js/node_view.jsx
+++ b/web/pgadmin/browser/static/js/node_view.jsx
@@ -25,7 +25,7 @@ export function getNodeView(nodeType, treeNodeInfo, actionType, itemNodeData, fo
let serverInfo = treeNodeInfo && ('server' in treeNodeInfo) &&
pgAdmin.Browser.serverInfo && pgAdmin.Browser.serverInfo[treeNodeInfo.server._id];
let inCatalog = treeNodeInfo && ('catalog' in treeNodeInfo);
- let urlBase = generateNodeUrl.call(nodeObj, treeNodeInfo, actionType, itemNodeData, false, null);
+ let urlBase = generateNodeUrl.call(nodeObj, treeNodeInfo, actionType, itemNodeData, false, nodeObj.url_jump_after_node);
const api = getApiInstance();
const url = (isNew)=>{
return urlBase + (isNew ? '' : itemNodeData._id);
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][patch] Partition node related fixes
In-Reply-To: <CAM9w-_nykH8mrdGUa9MNrErZ=WVaNVE9WuzU55cxHY1bUSDtJQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox