Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmvtu-0001l1-Qo for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Dec 2020 09:36:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kmvtM-0003ru-TB for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Dec 2020 09:36:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmvtM-0003qf-EP for pgadmin-hackers@lists.postgresql.org; Wed, 09 Dec 2020 09:36:12 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kmvmf-00009K-5e for pgadmin-hackers@postgresql.org; Wed, 09 Dec 2020 09:29:19 +0000 Received: by mail-ej1-x631.google.com with SMTP id bo9so1069326ejb.13 for ; Wed, 09 Dec 2020 01:29:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5CEUGIR+Usa4+vzahC56shhzcXDsNoMgtg0gp6yAvNs=; b=kCIa50lqCECk1RzOnWRbG2ggoOI3R2mKFknG/cQfpHyGeYKr4sFX1b1t1PJP8PwUuI m/XUggFskxqxtHdHBi5+sPJlulMJY6JSLQFamnkNKlvDrrAN9yHkZyrVS5gTWbwhCj33 3h1pls4LdOayzrNmBpDkee1s/Y86zf4E+bviVNLzyJxg72Hq6QY8iVsVefWz7GNICzch 7+LgiQoSMvsmSG0oJSLr3Q5OxVIaZoO39yP9/P7+c4LFX1rdvLjYj1w40wvqj0R7vAOr BbjFLWmRrUcgZUKveNS7TXZbHy22T9EBPDuCbCp8KSBqnPzCOYXokHpmZ7b0JA7eb7uZ 6HDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5CEUGIR+Usa4+vzahC56shhzcXDsNoMgtg0gp6yAvNs=; b=eq+uoozHVhRULKPCWaJ9Q4UCbKCfdARSDZ1Yh1SEoxy9DB4bRppvdAfRDFmEGbX58i +Wg7bcaUTlsiRmbkHzWQPAhgzRyG/FiVHhaAebqmtVv5b77PCOSrSPcqWB1GTT1xqO3B 74dzVLAYQo/ctqtaGkZnsmIhMtqr23gzyTDUr2ghPBwHIzRRQSkgZrjk1lbp7aq3s7t7 fI8IGwygE63wT+SbzMInBeYS7F/pJqj7Rl5UARYw54ZDZfNO/rzgUwEqv1uVLMD+iN4S GDS4PlDecuKAf6TVYXnRJc+paVL4BAsmIxIR903bI7+fuo/1ub+1D5B+hGoB20CglKFb EzUQ== X-Gm-Message-State: AOAM531uEBPVv4dGV5UKeVRzmSvwGYUm52vrcGwRKMNIVGmIO5tX9Yni wNaC3dVgqmnXgmO9YcdthYJhHx0jzjwJhsMYtZc4arNbrR/iZHhS5OYEMVcHyumH1RkaF9Mv9OI xHqc2WBiPqKEjVw7R6WdZSuAmWxWFW7TxWZlnGhuN3y/5jY55qyeN7SC3XdT0MWfg4knUjqxy8q LF6y+N9OQU20xgoEutx2Msdt4SJbcP9t1LvoShvTSnCAys/6B4bAmARWCkRg== X-Google-Smtp-Source: ABdhPJyaCpKFfSzK7JC2VJDD1KwZgB0vtgFV1UI+i3kpuOXUpIARZ1cvdk7uae1ptFerH5y/I0fN3TqwnpJLb4R3fj0= X-Received: by 2002:a17:906:2b50:: with SMTP id b16mr1230958ejg.255.1607506154001; Wed, 09 Dec 2020 01:29:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Aditya Toshniwal Date: Wed, 9 Dec 2020 14:58:38 +0530 Message-ID: Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results To: Rahul Shirsat Cc: pgadmin-hackers , Akshay Joshi Content-Type: multipart/alternative; boundary="00000000000048b23605b604b1ea" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000048b23605b604b1ea Content-Type: text/plain; charset="UTF-8" Hello Rahul, Found below issues: 1) The data grid is not fetching more than 1000 records now, gives a console error: sqleditor.js:1264 Uncaught TypeError: self.enable_disable_download_btn is not a function at child.fetch_next (sqleditor.js:1264) 2) The sqleditor test cases are failing. 3) Fix pep8 issues. 4) Fix linter issues. 5) Please check the doc changes again, it's not clear to me. I didn't check but make sure the GUI tests for the sqleditor runs fine since the behaviour has changed now. On Wed, Dec 9, 2020 at 1:53 PM Akshay Joshi wrote: > Hi Aditya > > Can you please review this patch? > > On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat < > rahul.shirsat@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the updated patch below. >> >> On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat < >> rahul.shirsat@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch which resolves the issue of macros query >>> results download, have used async cursor to achieve this functionality, >>> where for downloading the results, cursor is scrolled back to 0 and end of >>> the records, and reset again while user scrolling on Data Output table. >>> >>> QA/Reviewer needs to observe below issues if it occurs: >>> >>> 1. If records are more like 5000 or 10000, try to fetch records by >>> scrolling at least (2000), now save the results by clicking the download >>> button, it should save the file, and now try scrolling again, the data >>> should be shown continuously and not any abrupt end or unexpected records >>> order. >>> 2. Also, the download button is now "Save results to CSV/TXT" where >>> it will only get enabled when there are valid records in the Data Output. >>> >>> >>> Also a minor fix of the add folder icon issue is also added into this >>> patch. >>> >>> -- >>> *Rahul Shirsat* >>> Senior Software Engineer | EnterpriseDB Corporation. >>> >> >> >> -- >> *Rahul Shirsat* >> Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" --00000000000048b23605b604b1ea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Rahul,

Found below issues:
1) The data grid is not f= etching more than 1000 records now, gives a console error:
sqleditor.js:12= 64 Uncaught TypeError: self.enable_disable_download_btn is not a function=C2=A0 =C2=A0 at child.fetch_next (sqleditor.js:1264)

2) The sql= editor test cases are failing.
3) Fix pep8 issues.
4) Fix linter issues.
5)= Please check the doc changes again, it's not clear to me.

I didn&= #39;t check but make sure the GUI tests for the sqleditor runs fine since t= he behaviour has changed now.

On Wed, Dec 9, 2020 at 1:53 PM Akshay Jo= shi <akshay.joshi@enter= prisedb.com> wrote:
Hi Aditya

Can you please rev= iew this patch?

On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat <rahul.shirsa= t@enterprisedb.com> wrote:
Hi Hackers,

Pleas= e find the updated patch below.

<= div dir=3D"ltr" class=3D"gmail_attr">On Mon, Dec 7, 2020 at 2:55 PM Rahul S= hirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of macros qu= ery results download, have used async cursor to achieve this functionality,= where for downloading the results, cursor is scrolled back to 0 and end of= the records, and reset again while user scrolling on Data Output table.

QA/Reviewer needs to observe below issues if it occu= rs:
  1. If records are more like 5000 or 10000, try to fetch = records by scrolling at least=C2=A0(2000), now save the results by clicking= the download button, it should save the file, and now try scrolling again,= the data should be shown continuously and not any abrupt end or unexpected= records order.
  2. Also, the download button is now "Save results= to CSV/TXT" where it will only get enabled when there are valid recor= ds in the Data Output.

Also a minor fix = of the add folder icon issue is also added into this patch.
=
--
Rahul Shirsat
Senior Software Engineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corpora= tion.


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker=C2=A0| Sr. Softwa= re Engineer | edbpostgres.com<= /font>
"Don't Complain about Heat, Plant a TREE&qu= ot;
--00000000000048b23605b604b1ea--