public inbox for [email protected]  

help / color / mirror / Atom feed

From: Rushabh Lathia <[email protected]>
To: Dave Page <[email protected]>
Cc: Ashesh Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [PGAGENT] Upgrade pgAgent from unpackaged version
Date: Thu, 14 Jun 2018 10:19:27 +0530
Message-ID: <CAMBO3tUqYuONeAzs4YStKvj4etSDKD0xKKvU=xSMA-7-9yGCMQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxow82kcAP2-GNy9PQrxz5GP-XXsjusWRoY1yLTFGOYsnNg@mail.gmail.com>
References: <CAG7mmow-QXT+toi7NwVjj9vdYeH3w9R_jQ=n8GKKX9=sv782vA@mail.gmail.com>
	<CA+OCxow82kcAP2-GNy9PQrxz5GP-XXsjusWRoY1yLTFGOYsnNg@mail.gmail.com>

Thanks Ashesh and Dave.

I verified the changes and it looks good to me.  I found that newly
added unpackaged file still have old file header comment.  Which
require change with new file name.

PFA patch to fix the same.

Thanks,


On Wed, Jun 13, 2018 at 6:10 PM, Dave Page <[email protected]> wrote:

> Thanks, applied.
>
> On Wed, Jun 13, 2018 at 5:11 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> As per my conversation with Rushabh, we need to rename the
>> pgagent--unpackaged--3.4.sql to pgagent--unpackaged--4.0.sql as it the
>> current version has changed. We also need to update the schema version
>> function for the unpackaged extension.
>>
>> Please find the attached patch for the same.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
--

Rushabh Lathia
Database Architect
EnterpriseDB Corporation
The Enterprise Postgres Company

Phone: +91-20-30589494

Website: http://www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterprisedb


Attachments:

  [text/x-patch] unpackaged_file_header_change.patch (531B, 3-unpackaged_file_header_change.patch)
  download | inline diff:
diff --git a/sql/pgagent--unpackaged--4.0.sql b/sql/pgagent--unpackaged--4.0.sql
index 302dde4..b0e2cce 100644
--- a/sql/pgagent--unpackaged--4.0.sql
+++ b/sql/pgagent--unpackaged--4.0.sql
@@ -4,7 +4,7 @@
 // Copyright (C) 2002 - 2018 The pgAdmin Development Team
 // This software is released under the PostgreSQL Licence
 //
-// pgagent--unpackaged--3.4.sql - Convert pgAgent existing tables and functions to an extension
+// pgagent--unpackaged--4.0.sql - Convert pgAgent existing tables and functions to an extension
 //
 */
 

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PGAGENT] Upgrade pgAgent from unpackaged version
  In-Reply-To: <CAMBO3tUqYuONeAzs4YStKvj4etSDKD0xKKvU=xSMA-7-9yGCMQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox