public inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH] Add `headerscheck` run_target to meson
2+ messages / 2 participants
[nested] [flat]

* [PATCH] Add `headerscheck` run_target to meson
@ 2025-11-26 18:55  Miłosz Bieniek <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Miłosz Bieniek @ 2025-11-26 18:55 UTC (permalink / raw)
  To: [email protected]

Hi,
While reviewing a patch I noticed that we have a `make -s headerscheck` but
there is no equivalent in meson.
I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
targets.

Best Regards,
Miłosz Bieniek


Attachments:

  [application/octet-stream] 0001-Add-headerscheck-run_target-to-meson.patch (993B, 3-0001-Add-headerscheck-run_target-to-meson.patch)
  download | inline diff:
From 2c5029bad0c2a5fdc621de9beb1bbbf4d532b087 Mon Sep 17 00:00:00 2001
From: moozzi <[email protected]>
Date: Wed, 26 Nov 2025 13:05:44 +0100
Subject: [PATCH] Add `headerscheck` run_target to meson

---
 meson.build | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/meson.build b/meson.build
index 6e7ddd74683..8d4839ae64b 100644
--- a/meson.build
+++ b/meson.build
@@ -3900,6 +3900,20 @@ endif
 
 
 
+###############################################################
+# headerscheck
+###############################################################
+
+run_target('headerscheck',
+  command: [meson.project_source_root() / 'src/tools/pginclude/headerscheck']
+)
+
+run_target('cpluspluscheck',
+  command: [meson.project_source_root() / 'src/tools/pginclude/headerscheck', '--cplusplus']
+)
+
+
+
 ###############################################################
 # The End, The End, My Friend
 ###############################################################
-- 
2.49.0



^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: [PATCH] Add `headerscheck` run_target to meson
@ 2025-11-27 09:24  Akshay Joshi <[email protected]>
  parent: Miłosz Bieniek <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Akshay Joshi @ 2025-11-27 09:24 UTC (permalink / raw)
  To: Miłosz Bieniek <[email protected]>; +Cc: [email protected]

Can you please send this patch to pgsql-hackers list. This is the
pgadmin-hackers list.

On Thu, Nov 27, 2025 at 2:20 PM Miłosz Bieniek <[email protected]>
wrote:

> Hi,
> While reviewing a patch I noticed that we have a `make -s headerscheck`
> but there is no equivalent in meson.
> I prepared a small patch that adds `headerscheck` and `cpluspluscheck`
> targets.
>
> Best Regards,
> Miłosz Bieniek
>


^ permalink  raw  reply  [nested|flat] 2+ messages in thread

end of thread, other threads:[~2025-11-27 09:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-11-26 18:55 [PATCH] Add `headerscheck` run_target to meson Miłosz Bieniek <[email protected]>
2025-11-27 09:24 ` Akshay Joshi <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox