MIME-Version: 1.0
References: 
 <CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com>
 <CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com>
 <CA+OCxoxiy6xc9V9qUOP0f5LSA22PwHyNFWXjMvBT10EHjF5F+g@mail.gmail.com>
 <CABscKViG4=vECzrEhQNKbwGKJwPrWDn3isw-mPA5fNphw-G6=Q@mail.gmail.com>
 <CA+OCxoxOzUKjPF8pC=z4vjVKegBzNUDtGtwc5tewmtz2MfMhMw@mail.gmail.com>
 <CABscKViS50079irxJfgL5ARtd5g4D86z+OwJ7huY7nRJbB2rLQ@mail.gmail.com>
 <CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com>
 <CA+OCxoy5Mz53vyebx+2V0U3KH9f+Pd-p-HWoM7dMnUYNrjP-nw@mail.gmail.com>
In-Reply-To: 
 <CA+OCxoy5Mz53vyebx+2V0U3KH9f+Pd-p-HWoM7dMnUYNrjP-nw@mail.gmail.com>
From: Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>
Date: Fri, 6 Sep 2024 10:09:13 +0530
Message-ID: 
 <CAMa=N=M2O2jpszMtdZ6YEUOWPxvrcH-ipOQe_0rQNdx-ATkvzA@mail.gmail.com>
Subject: Re: Require suggestions for Issue #2874
To: Dave Page <dpage@pgadmin.org>, Rohit Bhati <rohit.bhati@enterprisedb.com>,
	pgadmin-hackers@postgresql.org
Content-Type: multipart/alternative; boundary="000000000000652fa106216bfff7"
Archived-At: 
 <https://www.postgresql.org/message-id/CAMa%3DN%3DM2O2jpszMtdZ6YEUOWPxvrcH-ipOQe_0rQNdx-ATkvzA%40mail.gmail.com>
Precedence: bulk

--000000000000652fa106216bfff7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 5, 2024 at 7:11=E2=80=AFPM Dave Page <dpage@pgadmin.org> wrote:
Hi,

Hi
>
> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <rohit.bhati@enterprisedb.com>
> wrote:
>
>> Hi,
>>
>> I have made changes for issue #7863
>> <https://github.com/pgadmin-org/pgadmin4/issues/7863> based on theme
>> requirements.
>>
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current color does not fit well with the theme or if you have any
>> suggestions for improvements, please let me know.
>>
>
> Is the colour contrast high enough on the row numbers for selected rows i=
n
> the high contrast theme? The black on grey seems like it might not be to
> me, but I haven't tested.
>
> I wonder also if we should make the row numbers bold all the time.
> Thoughts?
>

Yes. We should.


> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>

--000000000000652fa106216bfff7
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif;font-size:small"><br></div><br></div><br><div c=
lass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Sep 5, 2=
024 at 7:11=E2=80=AFPM Dave Page &lt;<a href=3D"mailto:dpage@pgadmin.org">d=
page@pgadmin.org</a>&gt; wrote:<br></div><div dir=3D"ltr" class=3D"gmail_at=
tr"><div style=3D"font-family:verdana,sans-serif;font-size:small" class=3D"=
gmail_default">Hi,</div><br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;=
border-left-color:rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>=
Hi</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr=
">On Thu, 5 Sept 2024 at 14:38, Rohit Bhati &lt;<a href=3D"mailto:rohit.bha=
ti@enterprisedb.com" target=3D"_blank">rohit.bhati@enterprisedb.com</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:r=
gb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi,<div><br>I have made =
changes for issue <a href=3D"https://github.com/pgadmin-org/pgadmin4/issues=
/7863" target=3D"_blank">#7863</a>=C2=A0based on theme requirements.<br><br=
>I have attached screenshots showing how the updates look across all themes=
 for your reference.<br><br>If the current color does not fit well with the=
 theme or if you have any suggestions for improvements, please let me know.=
<br></div></div></blockquote><div><br></div><div>Is the colour contrast hig=
h enough on the row numbers for selected rows in the high contrast theme? T=
he black on grey seems like it might not be to me, but I haven&#39;t tested=
.</div><div>=C2=A0</div><div>I wonder also if we should make the row number=
s bold all the time. Thoughts?</div></div></div></blockquote><div><br></div=
><div style=3D"font-family:verdana,sans-serif;font-size:small" class=3D"gma=
il_default">Yes. We should.</div><div style=3D"font-family:verdana,sans-ser=
if;font-size:small" class=3D"gmail_default"><br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border=
-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex"><div=
 dir=3D"ltr"><div><br></div><span class=3D"gmail_signature_prefix">-- </spa=
n><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Dave Page=
<div>pgAdmin: <a href=3D"https://www.pgadmin.org" target=3D"_blank">https:/=
/www.pgadmin.org</a></div><div>PostgreSQL: <a href=3D"https://www.postgresq=
l.org" target=3D"_blank">https://www.postgresql.org</a><br><div>EDB:=C2=A0<=
a href=3D"https://www.enterprisedb.com" target=3D"_blank">https://www.enter=
prisedb.com</a></div><div><br></div><div>PGDay UK 2024, 11th September, Lon=
don: <a href=3D"https://2024.pgday.uk/" target=3D"_blank">https://2024.pgda=
y.uk/</a></div><div><br></div></div></div></div></div>
</blockquote></div></div>

--000000000000652fa106216bfff7--