Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUS9z-0005uo-An for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Apr 2021 10:45:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lUS9x-0007A6-Sh for pgadmin-hackers@arkaria.postgresql.org; Thu, 08 Apr 2021 10:45:13 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lUS9x-00077V-JA for pgadmin-hackers@lists.postgresql.org; Thu, 08 Apr 2021 10:45:13 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lUS9u-0003qy-NI for pgadmin-hackers@postgresql.org; Thu, 08 Apr 2021 10:45:12 +0000 Received: by mail-lf1-x132.google.com with SMTP id b4so3171867lfi.6 for ; Thu, 08 Apr 2021 03:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kMPOop8e5GFSos3DyZwTi5lJe34GBfSZddo/UPxhjA8=; b=GyItestp0naLaszC58RFeT1coaagXwPKcJg3IQCJ22pd6mO2/zqZ3yKMCy31usCX2a A2ou59OC8JV1ou9rDklfSoSLkE51NVLoITdyulmLBse2o6P+QbE0mkuEVCwjlAhBrThc iZSEP8t+sf47jGsxQDuVJg59bW1g6Om4WiuWvbeayo27jJA/2SqBxKrjWDpFd+Six4G7 THOiuxm5aVJNyroVZQbEITd84eqHo9jLihD3GfO8bnIcrOOk8Qmw1cMIOVuZkV/nWmo1 e4dUxWetUZJDjJ1NNsKO3KhkahNSYrE9ZrFLw5Q50y2YTim3PB9n/fw7D7PYk0V6hKvO pQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kMPOop8e5GFSos3DyZwTi5lJe34GBfSZddo/UPxhjA8=; b=ZFJMTQNgn/kLu52/5JuqW24GvLUNK6w1yZWR6+mMfcFybsSMFA9JtwAwzwk4Rd6q6Q r85ygXZbl4AzKrZ+rh61wQ8UeYRHK2bihybLht9dvknrpxKZUVo9eIzo/I0/qSr6hdmc kMwMOyJUhpi8Gy7a7xJtIko1Ra3AUMU6nf441srJsPWVg4pAQ+nVcyfw2XmwF2C0/0HP c25/MdwIATLoX4vvsrIUVjVM6rg9tyffj7urPp2tGGZNeYcPwOpH+GjOSka7eGA6OSa7 QGZgFnomtxGEpyIMR0jxKNhklenWb7QOECmmZynaL+SAw67xTej1PgOn3Da+jJboC5fV dANQ== X-Gm-Message-State: AOAM5309q3i3/ChlD+6MuWPBZz5l+ihOiaB1ohH2lwu4KQjnqZizAR9a sbKX+lft4xfHq03a5TAQ+5B74nk8n+3n4oeAnYzHfjFX2X7np5xrIU/1RgxleNAs1YolnDlekhY 2VKa0ZsTVCaonRGFtyOeaCN5f3ecrFyRM1p6ZYS7Dpu99r0tV6IfkmSD1nUVHOqKcsv0/x6m01a 8n5YX8YnNV2uygJX0oCTbA+6gdNe9nz9URV1iTiWCcoCKYmrbiCoqJUmcpEOtktwwEJw== X-Google-Smtp-Source: ABdhPJyAnjPO5wuiHLt85JJaG4TVSTsNQ2mha9hrpj0sMeaikoOZjq+sTpfBm7rIpX+Rrg9wUGBmS9m/fw8s4O1Bzyk= X-Received: by 2002:a19:e34c:: with SMTP id c12mr5760958lfk.555.1617878708368; Thu, 08 Apr 2021 03:45:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yogesh Mahajan Date: Thu, 8 Apr 2021 16:14:30 +0530 Message-ID: Subject: Re: [pgAdmin][Patch] RM 6082 - Able to change connection when a long query is running To: pgadmin-hackers Cc: Akshay Joshi Content-Type: multipart/mixed; boundary="000000000000b4b0de05bf73bd61" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000b4b0de05bf73bd61 Content-Type: multipart/alternative; boundary="000000000000b4b0db05bf73bd5f" --000000000000b4b0db05bf73bd5f Content-Type: text/plain; charset="UTF-8" Hi, Please discard the previous patch. Here is the latest patch. This also fixes the issue of disappearing the connection bar from the query tool on the resize pgAdmin window. Thanks, Yogesh Mahajan EnterpriseDB On Wed, Apr 7, 2021 at 1:40 PM Yogesh Mahajan < yogesh.mahajan@enterprisedb.com> wrote: > Hello, > > Sorry for the inconvenience. > Please update the patch. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Tue, Apr 6, 2021 at 4:07 PM Akshay Joshi > wrote: > >> Hi Yogesh >> >> The issue is not fixed yet. I am able to change the connection while the >> transaction is in progress. Please check and resend the patch. >> >> On Tue, Apr 6, 2021 at 1:43 PM Yogesh Mahajan < >> yogesh.mahajan@enterprisedb.com> wrote: >> >>> Hello, >>> >>> Please find a patch which diables change of connection from query tool >>> while query tool transaction is in progress. >>> >>> >>> Thanks, >>> Yogesh Mahajan >>> EnterpriseDB >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > --000000000000b4b0db05bf73bd5f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Please= discard the previous patch.
Here is the latest patch. This= also fixes the issue of disappearing the connection bar from the query too= l on the resize pgAdmin window.


Thanks,
Yogesh Mahajan
= EnterpriseDB


On Wed, Apr 7, 2021 at 1:40 PM Yogesh Mahajan <yogesh.mahajan@enterprisedb.com>= ; wrote:
Hello,
=

Sorry for the inconvenience.
Please update the patch.

=
Thanks,
Yogesh Mahajan
EnterpriseDB

On Tue, Apr 6, 2021 at 4:07 PM Akshay Joshi <akshay.joshi@enterprisedb.com&= gt; wrote:
Hi=C2=A0Yogesh
The issue is not fixed=C2=A0yet. I am able to change the conne= ction while the transaction is in progress. Please check and resend the pat= ch.

On Tue, Apr 6, 2021 at 1:43 PM Yogesh Mahajan <yogesh.mahajan@enterpr= isedb.com> wrote:
Hello,

Please find a patch whi= ch diables change of connection from query tool while query tool transactio= n is in progress.


Thanks,
Yogesh Mahajan
= EnterpriseDB


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--000000000000b4b0db05bf73bd5f-- --000000000000b4b0de05bf73bd61 Content-Type: application/octet-stream; name="RM6082_v3.patch" Content-Disposition: attachment; filename="RM6082_v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kn8r5sp90 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zcWxlZGl0b3IvZXhlY3V0ZV9xdWVy eS5qcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9zcWxlZGl0b3IvZXhlY3V0ZV9xdWVyeS5qcwpp bmRleCAyYzk2NjU1MGMuLjJlZTljMzIxZiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGlj L2pzL3NxbGVkaXRvci9leGVjdXRlX3F1ZXJ5LmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9q cy9zcWxlZGl0b3IvZXhlY3V0ZV9xdWVyeS5qcwpAQCAtMTMsNiArMTMsNyBAQCBpbXBvcnQgdXJs X2ZvciBmcm9tICcuLi91cmxfZm9yJzsKIGltcG9ydCBheGlvcyBmcm9tICdheGlvcyc7CiBpbXBv cnQgKiBhcyBodHRwRXJyb3JIYW5kbGVyIGZyb20gJy4vcXVlcnlfdG9vbF9odHRwX2Vycm9yX2hh bmRsZXInOwogaW1wb3J0ICogYXMgcXVlcnlUeG5TdGF0dXMgZnJvbSAnc291cmNlcy9zcWxlZGl0 b3IvcXVlcnlfdHhuX3N0YXR1c19jb25zdGFudHMnOworaW1wb3J0ICogYXMgU3FsRWRpdG9yVXRp bHMgZnJvbSAnc291cmNlcy9zcWxlZGl0b3JfdXRpbHMnOwogCiBjbGFzcyBMb2FkaW5nU2NyZWVu IHsKICAgY29uc3RydWN0b3Ioc3FsRWRpdG9yKSB7CkBAIC03Niw2ICs3Nyw5IEBAIGNsYXNzIEV4 ZWN1dGVRdWVyeSB7CiAgICAgICAgIGlmIChFeGVjdXRlUXVlcnkuaXNTcWxDb3JyZWN0KGh0dHBN ZXNzYWdlRGF0YSkpIHsKICAgICAgICAgICBzZWxmLmxvYWRpbmdTY3JlZW4uc2V0TWVzc2FnZSgn V2FpdGluZyBmb3IgdGhlIHF1ZXJ5IHRvIGNvbXBsZXRlLi4uJyk7CiAKKyAgICAgICAgICAvLyBE aXNhYmxlIGRyb3AgZG93biBhcnJvdyB0byBjaGFuZ2UgY29ubmVjdGlvbnMKKyAgICAgICAgICBT cWxFZGl0b3JVdGlscy5kaXNhYmxlX2Nvbm5lY3Rpb25fZHJvcGRvd24odHJ1ZSk7CisKICAgICAg ICAgICBzZWxmLnVwZGF0ZVNxbEVkaXRvclN0YXRlV2l0aEluZm9ybWF0aW9uRnJvbVNlcnZlciho dHRwTWVzc2FnZURhdGEuZGF0YSk7CiAKICAgICAgICAgICAvLyBJZiBzdGF0dXMgaXMgVHJ1ZSB0 aGVuIHBvbGwgdGhlIHJlc3VsdC4KQEAgLTE2MSw2ICsxNjUsMTAgQEAgY2xhc3MgRXhlY3V0ZVF1 ZXJ5IHsKICAgICAgICAgICBzZWxmLmxvYWRpbmdTY3JlZW4uaGlkZSgpOwogICAgICAgICAgIHNl bGYuc3FsU2VydmVyT2JqZWN0LnVwZGF0ZV9tc2dfaGlzdG9yeShmYWxzZSwgJ0V4ZWN1dGlvbiBD YW5jZWxsZWQhJywgdHJ1ZSk7CiAgICAgICAgIH0KKyAgICAgICAgLy8gRW5hYmxlIGNvbm5lY3Rp b24gbGlzdCBkcm9wIGRvd24gYWdhaW4gZm9yIHF1ZXJ5IHRvb2wgb25seQorICAgICAgICBpZihz ZWxmLnNxbFNlcnZlck9iamVjdC5pc19xdWVyeV90b29sICYmICFFeGVjdXRlUXVlcnkuaXNRdWVy eVN0aWxsUnVubmluZyhodHRwTWVzc2FnZSkpeworICAgICAgICAgIFNxbEVkaXRvclV0aWxzLmRp c2FibGVfY29ubmVjdGlvbl9kcm9wZG93bihmYWxzZSk7CisgICAgICAgIH0KICAgICAgIH0KICAg ICApLmNhdGNoKAogICAgICAgZXJyb3IgPT4gewpAQCAtMTcxLDYgKzE3OSw3IEBAIGNsYXNzIEV4 ZWN1dGVRdWVyeSB7CiAgICAgICAgIHNlbGYuc3FsU2VydmVyT2JqZWN0LnNldElzUXVlcnlSdW5u aW5nKGZhbHNlKTsKICAgICAgICAgaWYgKHNlbGYuc3FsU2VydmVyT2JqZWN0LmlzX3F1ZXJ5X3Rv b2wpIHsKICAgICAgICAgICBzZWxmLmVuYWJsZVNRTEVkaXRvckJ1dHRvbnMoKTsKKyAgICAgICAg ICBTcWxFZGl0b3JVdGlscy5kaXNhYmxlX2Nvbm5lY3Rpb25fZHJvcGRvd24oZmFsc2UpOwogICAg ICAgICB9CiAKICAgICAgICAgaWYoZXJyb3IucmVzcG9uc2UpIHsKZGlmZiAtLWdpdCBhL3dlYi9w Z2FkbWluL3N0YXRpYy9qcy9zcWxlZGl0b3JfdXRpbHMuanMgYi93ZWIvcGdhZG1pbi9zdGF0aWMv anMvc3FsZWRpdG9yX3V0aWxzLmpzCmluZGV4IDVmNWIxNDllMC4uZTUxY2FiNTdiIDEwMDY0NAot LS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvc3FsZWRpdG9yX3V0aWxzLmpzCisrKyBiL3dlYi9w Z2FkbWluL3N0YXRpYy9qcy9zcWxlZGl0b3JfdXRpbHMuanMKQEAgLTU3LDYgKzU3LDE3IEBAIGRl ZmluZShbJ2pxdWVyeScsICd1bmRlcnNjb3JlJywgJ3NvdXJjZXMvZ2V0dGV4dCcsICdzb3VyY2Vz L3VybF9mb3InXSwKICAgICAgICAgcmV0dXJuIHN0cmluZy5jaGFyQXQoMCkudG9VcHBlckNhc2Uo KSArIHN0cmluZy5zbGljZSgxKTsKICAgICAgIH0sCiAKKyAgICAgIC8vIERpc2FibGVzIGFycm93 IHRvIGNoYW5nZSBjb25uZWN0aW9uCisgICAgICBkaXNhYmxlX2Nvbm5lY3Rpb25fZHJvcGRvd246 IGZ1bmN0aW9uIChzdGF0dXMpIHsKKyAgICAgICAgaWYgKHN0YXR1cyl7CisgICAgICAgICAgJCgn LmNvbm4taW5mby1kZCcpLnByb3AoJ2Rpc2FibGVkJyx0cnVlKTsKKyAgICAgICAgICAkKCcuY29u bmVjdGlvbi1kYXRhJykuY3NzKHtwb2ludGVyRXZlbnRzOiAnbm9uZScsIGN1cnNvcjogJ2Fycm93 J30pOworICAgICAgICB9ZWxzZXsKKyAgICAgICAgICAkKCcuY29ubi1pbmZvLWRkJykucHJvcCgn ZGlzYWJsZWQnLGZhbHNlKTsKKyAgICAgICAgICAkKCcuY29ubmVjdGlvbi1kYXRhJykuY3NzKHtw b2ludGVyRXZlbnRzOiAnYXV0bycsIGN1cnNvcjogJ3BvaW50ZXInfSk7CisgICAgICAgIH0KKyAg ICAgIH0sCisKICAgICAgIC8vIFN0YXR1cyBmbGFnCiAgICAgICBwcmV2aW91c1N0YXR1czogbnVs bCwKIApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9zY3Nz L19zcWxlZGl0b3Iuc2NzcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvc2Nz cy9fc3FsZWRpdG9yLnNjc3MKaW5kZXggOWQ1YmE0ZGViLi44YmEzZTVlYmQgMTAwNjQ0Ci0tLSBh L3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvc2Nzcy9fc3FsZWRpdG9yLnNjc3MK KysrIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL3N0YXRpYy9zY3NzL19zcWxlZGl0b3Iu c2NzcwpAQCAtNTIsOCArNTIsNiBAQAogCiAjZWRpdG9yLXBhbmVsIHsKICAgei1pbmRleDogMDsK LSAgcG9zaXRpb246IGFic29sdXRlOwotICB0b3A6ICRzcWwtZWRpdG9yLXBhbmVsLXRvcDsKICAg Ym90dG9tOiAwOwogICBsZWZ0OiAwOwogICByaWdodDogMDsK --000000000000b4b0de05bf73bd61--