public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yogesh Mahajan <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table.
Date: Mon, 12 Apr 2021 10:57:51 +0530
Message-ID: <CAMa=N=NSGwPK=D_BCvFopndMEsOZLOjkqn-+EkdF2DY1MdUuiA@mail.gmail.com> (raw)

Hi,

Please find the attached patch which fixes the error while selecting the
row which was deleted just before selection operation.


Thanks,
Yogesh Mahajan
EnterpriseDB


Attachments:

  [application/octet-stream] RM6306_v1.patch (661B, 3-RM6306_v1.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/selection/active_cell_capture.js b/web/pgadmin/static/js/selection/active_cell_capture.js
index 442766ce0..c183cf1ef 100644
--- a/web/pgadmin/static/js/selection/active_cell_capture.js
+++ b/web/pgadmin/static/js/selection/active_cell_capture.js
@@ -108,7 +108,7 @@ define([
         }
 
         if (isClickingLastClickedHeader(rowClicked, 1)) {
-          if (isSingleRangeSelected()) {
+          if (isSingleRangeSelected() || grid.getSelectionModel().getSelectedRanges().length === 0) {
             grid.resetActiveCell();
           } else {
             grid.setActiveCell(retrievePreviousSelectedRange().fromRow, 1);

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][Patch] RM 6306 - UI issue in Delete records form data output table.
  In-Reply-To: <CAMa=N=NSGwPK=D_BCvFopndMEsOZLOjkqn-+EkdF2DY1MdUuiA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox