public inbox for [email protected]help / color / mirror / Atom feed
#7076 - Keychain access on Mac 7+ messages / 3 participants [nested] [flat]
* #7076 - Keychain access on Mac @ 2024-08-05 12:27 Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Yogesh Mahajan @ 2024-08-05 12:27 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has been reported by many Mac users. Issue has popped up when python binary version is changed for the pgadmin. To save server passwords, pgadmin uses os level secret storage (in case of Mac it is keyring) and adds an entry for each save password. Whenever the python binary version is changed, keychain (python lib used to access keychain) asks for a password 2 times for accessing each entry. If you have 10 servers, then it will ask for 20 times. To fix the issue, pgadmin will follow the same approach as chrome. 1.An encryption key will be auto-generated and will be stored in the keychain. 2.Whenever save password request is received, encryption key will be used to encrypt password and encrypted password will be saved in the pgadmin database. 3.Similarly, while retrieving the password, encryption will be pulled from the keychain and will be used to decrypt the password. This will reduce password asks to 2 times on python binary version change. Kindly share your inputs/suggestions/thoughts. Thanks, Yogesh Mahajan EnterpriseDB ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> @ 2024-08-08 12:27 ` Dave Page <[email protected]> 2024-08-08 12:37 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2024-08-08 12:27 UTC (permalink / raw) To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan <[email protected]> wrote: > Hi Hackers, > > Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has > been reported by many Mac users. Issue has popped up when python binary > version is changed for the pgadmin. > > To save server passwords, pgadmin uses os level secret storage (in case of > Mac it is keyring) and adds an entry for each save password. Whenever the > python binary version is changed, keychain (python lib used to access > keychain) asks for a password 2 times for accessing each entry. If you have > 10 servers, then it will ask for 20 times. > > To fix the issue, pgadmin will follow the same approach as chrome. > 1.An encryption key will be auto-generated and will be stored in the > keychain. > 2.Whenever save password request is received, encryption key will be used > to encrypt password and encrypted password will be saved in the pgadmin > database. > 3.Similarly, while retrieving the password, encryption will be pulled from > the keychain and will be used to decrypt the password. > This will reduce password asks to 2 times on python binary version change. > That sounds almost like returning to the way things used to work with the master password, except we auto-generate it, and store that in the keychain. I assume we'd do the same on all platforms, using whatever the equivalent store is on each? Any idea why it asks for the login password twice per access on macOS? -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> @ 2024-08-08 12:37 ` Yogesh Mahajan <[email protected]> 2024-08-08 12:44 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Yogesh Mahajan @ 2024-08-08 12:37 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi, On Thu, Aug 8, 2024 at 5:58 PM Dave Page <[email protected]> wrote: > > > On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan < > [email protected]> wrote: > >> Hi Hackers, >> >> Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has >> been reported by many Mac users. Issue has popped up when python binary >> version is changed for the pgadmin. >> >> To save server passwords, pgadmin uses os level secret storage (in case >> of Mac it is keyring) and adds an entry for each save password. Whenever >> the python binary version is changed, keychain (python lib used to access >> keychain) asks for a password 2 times for accessing each entry. If you have >> 10 servers, then it will ask for 20 times. >> >> To fix the issue, pgadmin will follow the same approach as chrome. >> 1.An encryption key will be auto-generated and will be stored in the >> keychain. >> 2.Whenever save password request is received, encryption key will be used >> to encrypt password and encrypted password will be saved in the pgadmin >> database. >> 3.Similarly, while retrieving the password, encryption will be pulled >> from the keychain and will be used to decrypt the password. >> This will reduce password asks to 2 times on python binary version change. >> > > That sounds almost like returning to the way things used to work with the > master password, except we auto-generate it, and store that in the keychain. > Yeah. > I assume we'd do the same on all platforms, using whatever the equivalent > store is on each? > Yes we will be doing the same on all supported platforms. > > Any idea why it asks for the login password twice per access on macOS? > This <https://github.com/jaraco/keyring/issues/644; is a known issue for keyring python lib. And this <https://github.com/jaraco/keyring/issues/619; one where the keychain asks for a password for accessing each entry. > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ > Thanks, Yogesh Mahajan EnterpriseDB ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 2024-08-08 12:37 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> @ 2024-08-08 12:44 ` Dave Page <[email protected]> 2024-08-08 12:46 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:47 ` Re: #7076 - Keychain access on Mac Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 7+ messages in thread From: Dave Page @ 2024-08-08 12:44 UTC (permalink / raw) To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers On Thu, 8 Aug 2024 at 13:38, Yogesh Mahajan <[email protected]> wrote: > > > Hi, > > On Thu, Aug 8, 2024 at 5:58 PM Dave Page <[email protected]> wrote: > >> >> >> On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has >>> been reported by many Mac users. Issue has popped up when python binary >>> version is changed for the pgadmin. >>> >>> To save server passwords, pgadmin uses os level secret storage (in case >>> of Mac it is keyring) and adds an entry for each save password. Whenever >>> the python binary version is changed, keychain (python lib used to access >>> keychain) asks for a password 2 times for accessing each entry. If you have >>> 10 servers, then it will ask for 20 times. >>> >>> To fix the issue, pgadmin will follow the same approach as chrome. >>> 1.An encryption key will be auto-generated and will be stored in the >>> keychain. >>> 2.Whenever save password request is received, encryption key will be >>> used to encrypt password and encrypted password will be saved in the >>> pgadmin database. >>> 3.Similarly, while retrieving the password, encryption will be pulled >>> from the keychain and will be used to decrypt the password. >>> This will reduce password asks to 2 times on python binary version >>> change. >>> >> >> That sounds almost like returning to the way things used to work with the >> master password, except we auto-generate it, and store that in the keychain. >> > > Yeah. > > >> I assume we'd do the same on all platforms, using whatever the equivalent >> store is on each? >> > > Yes we will be doing the same on all supported platforms. > > >> >> Any idea why it asks for the login password twice per access on macOS? >> > > This <https://github.com/jaraco/keyring/issues/644; is a known issue for > keyring python lib. And this > <https://github.com/jaraco/keyring/issues/619; one where the keychain > asks for a password for accessing each entry. > OK, thanks. -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 2024-08-08 12:37 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:44 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> @ 2024-08-08 12:46 ` Yogesh Mahajan <[email protected]> 2024-08-08 13:02 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 1 sibling, 1 reply; 7+ messages in thread From: Yogesh Mahajan @ 2024-08-08 12:46 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Hi Dave, Should I proceed with this approach? Thanks, Yogesh Mahajan EnterpriseDB On Thu, Aug 8, 2024 at 6:14 PM Dave Page <[email protected]> wrote: > > > On Thu, 8 Aug 2024 at 13:38, Yogesh Mahajan < > [email protected]> wrote: > >> >> >> Hi, >> >> On Thu, Aug 8, 2024 at 5:58 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has >>>> been reported by many Mac users. Issue has popped up when python binary >>>> version is changed for the pgadmin. >>>> >>>> To save server passwords, pgadmin uses os level secret storage (in case >>>> of Mac it is keyring) and adds an entry for each save password. Whenever >>>> the python binary version is changed, keychain (python lib used to access >>>> keychain) asks for a password 2 times for accessing each entry. If you have >>>> 10 servers, then it will ask for 20 times. >>>> >>>> To fix the issue, pgadmin will follow the same approach as chrome. >>>> 1.An encryption key will be auto-generated and will be stored in the >>>> keychain. >>>> 2.Whenever save password request is received, encryption key will be >>>> used to encrypt password and encrypted password will be saved in the >>>> pgadmin database. >>>> 3.Similarly, while retrieving the password, encryption will be pulled >>>> from the keychain and will be used to decrypt the password. >>>> This will reduce password asks to 2 times on python binary version >>>> change. >>>> >>> >>> That sounds almost like returning to the way things used to work with >>> the master password, except we auto-generate it, and store that in the >>> keychain. >>> >> >> Yeah. >> >> >>> I assume we'd do the same on all platforms, using whatever the >>> equivalent store is on each? >>> >> >> Yes we will be doing the same on all supported platforms. >> >> >>> >>> Any idea why it asks for the login password twice per access on macOS? >>> >> >> This <https://github.com/jaraco/keyring/issues/644; is a known issue for >> keyring python lib. And this >> <https://github.com/jaraco/keyring/issues/619; one where the keychain >> asks for a password for accessing each entry. >> > > OK, thanks. > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ > > ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 2024-08-08 12:37 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:44 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 2024-08-08 12:46 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> @ 2024-08-08 13:02 ` Dave Page <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: Dave Page @ 2024-08-08 13:02 UTC (permalink / raw) To: Yogesh Mahajan <[email protected]>; +Cc: pgadmin-hackers On Thu, 8 Aug 2024 at 13:46, Yogesh Mahajan <[email protected]> wrote: > Hi Dave, > > Should I proceed with this approach? > Sure, go ahead. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Thu, Aug 8, 2024 at 6:14 PM Dave Page <[email protected]> wrote: > >> >> >> On Thu, 8 Aug 2024 at 13:38, Yogesh Mahajan < >> [email protected]> wrote: >> >>> >>> >>> Hi, >>> >>> On Thu, Aug 8, 2024 at 5:58 PM Dave Page <[email protected]> wrote: >>> >>>> >>>> >>>> On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan < >>>> [email protected]> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has >>>>> been reported by many Mac users. Issue has popped up when python binary >>>>> version is changed for the pgadmin. >>>>> >>>>> To save server passwords, pgadmin uses os level secret storage (in >>>>> case of Mac it is keyring) and adds an entry for each save password. >>>>> Whenever the python binary version is changed, keychain (python lib used to >>>>> access keychain) asks for a password 2 times for accessing each entry. If >>>>> you have 10 servers, then it will ask for 20 times. >>>>> >>>>> To fix the issue, pgadmin will follow the same approach as chrome. >>>>> 1.An encryption key will be auto-generated and will be stored in the >>>>> keychain. >>>>> 2.Whenever save password request is received, encryption key will be >>>>> used to encrypt password and encrypted password will be saved in the >>>>> pgadmin database. >>>>> 3.Similarly, while retrieving the password, encryption will be pulled >>>>> from the keychain and will be used to decrypt the password. >>>>> This will reduce password asks to 2 times on python binary version >>>>> change. >>>>> >>>> >>>> That sounds almost like returning to the way things used to work with >>>> the master password, except we auto-generate it, and store that in the >>>> keychain. >>>> >>> >>> Yeah. >>> >>> >>>> I assume we'd do the same on all platforms, using whatever the >>>> equivalent store is on each? >>>> >>> >>> Yes we will be doing the same on all supported platforms. >>> >>> >>>> >>>> Any idea why it asks for the login password twice per access on macOS? >>>> >>> >>> This <https://github.com/jaraco/keyring/issues/644; is a known issue >>> for keyring python lib. And this >>> <https://github.com/jaraco/keyring/issues/619; one where the keychain >>> asks for a password for accessing each entry. >>> >> >> OK, thanks. >> -- >> Dave Page >> pgAdmin: https://www.pgadmin.org >> PostgreSQL: https://www.postgresql.org >> EDB: https://www.enterprisedb.com >> >> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ >> >> -- Dave Page pgAdmin: https://www.pgadmin.org PostgreSQL: https://www.postgresql.org EDB: https://www.enterprisedb.com PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: #7076 - Keychain access on Mac 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> 2024-08-08 12:37 ` Re: #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:44 ` Re: #7076 - Keychain access on Mac Dave Page <[email protected]> @ 2024-08-08 12:47 ` Aditya Toshniwal <[email protected]> 1 sibling, 0 replies; 7+ messages in thread From: Aditya Toshniwal @ 2024-08-08 12:47 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: Yogesh Mahajan <[email protected]>; pgadmin-hackers Hi Dave, On Thu, Aug 8, 2024 at 6:14 PM Dave Page <[email protected]> wrote: > > > On Thu, 8 Aug 2024 at 13:38, Yogesh Mahajan < > [email protected]> wrote: > >> >> >> Hi, >> >> On Thu, Aug 8, 2024 at 5:58 PM Dave Page <[email protected]> wrote: >> >>> >>> >>> On Mon, 5 Aug 2024 at 13:27, Yogesh Mahajan < >>> [email protected]> wrote: >>> >>>> Hi Hackers, >>>> >>>> Issue #7076 <https://github.com/pgadmin-org/pgadmin4/issues/7076; has >>>> been reported by many Mac users. Issue has popped up when python binary >>>> version is changed for the pgadmin. >>>> >>>> To save server passwords, pgadmin uses os level secret storage (in case >>>> of Mac it is keyring) and adds an entry for each save password. Whenever >>>> the python binary version is changed, keychain (python lib used to access >>>> keychain) asks for a password 2 times for accessing each entry. If you have >>>> 10 servers, then it will ask for 20 times. >>>> >>>> To fix the issue, pgadmin will follow the same approach as chrome. >>>> 1.An encryption key will be auto-generated and will be stored in the >>>> keychain. >>>> 2.Whenever save password request is received, encryption key will be >>>> used to encrypt password and encrypted password will be saved in the >>>> pgadmin database. >>>> 3.Similarly, while retrieving the password, encryption will be pulled >>>> from the keychain and will be used to decrypt the password. >>>> This will reduce password asks to 2 times on python binary version >>>> change. >>>> >>> >>> That sounds almost like returning to the way things used to work with >>> the master password, except we auto-generate it, and store that in the >>> keychain. >>> >> >> Yeah. >> >> >>> I assume we'd do the same on all platforms, using whatever the >>> equivalent store is on each? >>> >> >> Yes we will be doing the same on all supported platforms. >> >> >>> >>> Any idea why it asks for the login password twice per access on macOS? >>> >> >> This <https://github.com/jaraco/keyring/issues/644; is a known issue for >> keyring python lib. And this >> <https://github.com/jaraco/keyring/issues/619; one where the keychain >> asks for a password for accessing each entry. >> > This is not a keyring issue. It is MacOS SDK behavior. The issue was raised to keyring but even they're helpless. > > OK, thanks. > -- > Dave Page > pgAdmin: https://www.pgadmin.org > PostgreSQL: https://www.postgresql.org > EDB: https://www.enterprisedb.com > > PGDay UK 2024, 11th September, London: https://2024.pgday.uk/ > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com* <https://www.enterprisedb.com/; "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-08-08 13:02 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-08-05 12:27 #7076 - Keychain access on Mac Yogesh Mahajan <[email protected]> 2024-08-08 12:27 ` Dave Page <[email protected]> 2024-08-08 12:37 ` Yogesh Mahajan <[email protected]> 2024-08-08 12:44 ` Dave Page <[email protected]> 2024-08-08 12:46 ` Yogesh Mahajan <[email protected]> 2024-08-08 13:02 ` Dave Page <[email protected]> 2024-08-08 12:47 ` Aditya Toshniwal <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox