public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yogesh Mahajan <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [Patch] - Feature Test Fix
Date: Mon, 7 Mar 2022 15:32:29 +0530
Message-ID: <CAMa=N=Nd9A402W-gZ6udM3YHKeB-WDP+bE00yhj8VOVy=ha18g@mail.gmail.com> (raw)
Hi,
Please find the attached patch which fixes the feature test failures.
Thanks,
Yogesh Mahajan
EnterpriseDB
Attachments:
[application/octet-stream] Feature_Test_Fix_React_Porting_v1.patch (2.2K, 3-Feature_Test_Fix_React_Porting_v1.patch)
download | inline diff:
diff --git a/web/pgadmin/feature_tests/file_manager_test.py b/web/pgadmin/feature_tests/file_manager_test.py
index 83a927a81..63eaa699d 100644
--- a/web/pgadmin/feature_tests/file_manager_test.py
+++ b/web/pgadmin/feature_tests/file_manager_test.py
@@ -76,7 +76,7 @@ class CheckFileManagerFeatureTest(BaseFeatureTest):
self.page.find_by_css_selector(QueryToolLocators.btn_save_file) \
.click()
# Set the XSS value in input
- WebDriverWait(self.driver, 10).until(EC.presence_of_element_located(
+ WebDriverWait(self.driver, 15).until(EC.presence_of_element_located(
(By.CSS_SELECTOR, ".change_file_types")))
self.page.find_by_css_selector('.change_file_types')
self.page.fill_input_by_css_selector(
diff --git a/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py b/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py
index fd497ea0d..6f40fbc8a 100644
--- a/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py
+++ b/web/pgadmin/feature_tests/pg_utilities_maintenance_test.py
@@ -82,7 +82,7 @@ class PGUtilitiesMaintenanceFeatureTest(BaseFeatureTest):
self.page.click_modal('OK', True)
self.page.wait_for_element_to_disappear(
lambda driver: driver.find_element(
- By.XPATH, NavMenuLocators.maintenance_operation))
+ By.XPATH, NavMenuLocators.maintenance_operation), 10)
# Wait for the backup status alertfier
self.wait.until(EC.visibility_of_element_located(
diff --git a/web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py b/web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py
index 998c6d8a5..3f54a23c3 100644
--- a/web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py
+++ b/web/pgadmin/feature_tests/xss_checks_pgadmin_debugger_test.py
@@ -78,7 +78,7 @@ class CheckDebuggerForXssFeatureTest(BaseFeatureTest):
try:
wait = WebDriverWait(self.page.driver, 2)
is_error = wait.until(EC.presence_of_element_located(
- (By.XPATH, "//div[@class ='MuiDialogTitle-root']"
+ (By.XPATH, "//div[contains(@class,'MuiDialogTitle-root')]"
"//div[text()='Debugger Error']")
))
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [Patch] - Feature Test Fix
In-Reply-To: <CAMa=N=Nd9A402W-gZ6udM3YHKeB-WDP+bE00yhj8VOVy=ha18g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox