public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yogesh Mahajan <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [Patch] - Bug #7059 - pgAdmin throws internal server error for OAuth2 after some random idle time
Date: Tue, 15 Mar 2022 15:12:55 +0530
Message-ID: <CAMa=N=NwPr98x4JsLUjx65VLoBq3zRec+0EFYuS4_h=7O7KuoQ@mail.gmail.com> (raw)

Hi,

Please find the patch which fixes the error shown on logout when auth
sources include  'oauth2'.

Thanks,
Yogesh Mahajan
EnterpriseDB


Attachments:

  [application/octet-stream] RM_7059_v1.patch (724B, 3-RM_7059_v1.patch)
  download | inline diff:
diff --git a/web/pgadmin/authenticate/__init__.py b/web/pgadmin/authenticate/__init__.py
index c62fbe22b..d637e32dd 100644
--- a/web/pgadmin/authenticate/__init__.py
+++ b/web/pgadmin/authenticate/__init__.py
@@ -43,6 +43,11 @@ def get_logout_url() -> str:
             KERBEROS:
         return _URL_WITH_NEXT_PARAM.format(url_for(
             'kerberos.logout'), url_for(BROWSER_INDEX))
+    elif config.SERVER_MODE and\
+            session['auth_source_manager']['current_source'] == \
+            OAUTH2:
+        return _URL_WITH_NEXT_PARAM.format(url_for(
+            'oauth2.logout'), url_for(BROWSER_INDEX))
 
     return _URL_WITH_NEXT_PARAM.format(
         url_for('security.logout'), url_for(BROWSER_INDEX))

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Patch] - Bug #7059 - pgAdmin throws internal server error for OAuth2 after some random idle time
  In-Reply-To: <CAMa=N=NwPr98x4JsLUjx65VLoBq3zRec+0EFYuS4_h=7O7KuoQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox