public inbox for [email protected]
help / color / mirror / Atom feedFrom: Yogesh Mahajan <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: Re: Feature Test Fix - React porting
Date: Mon, 22 Nov 2021 12:57:34 +0530
Message-ID: <CAMa=N=OHsVoYaTYdspiVHnYXhmD=Q074D8awZdTpswRuj-xgFg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDf2pZExvAawcMcM_Bn-5D=g6iWzVEG0dWsuu-qPnAZYig@mail.gmail.com>
References: <CAMa=N=M7TmEsEk0tD787z-obnN_805R4QyegZtFspjfddLKbug@mail.gmail.com>
<CANxoLDfH2YoCG1aVFPuzWCR95FTFgJczceH1Z-eFg2Oo24tzLA@mail.gmail.com>
<CAMa=N=Op8hASK9hRBfDXHiwrVsDn-NaH-0hUk+7gGF6L_80mHQ@mail.gmail.com>
<CANxoLDe_meHYN8DU4kc5p+6wpiKivSyyJLW26idD+7h7=wi+2A@mail.gmail.com>
<CAMa=N=MyQWGD_YwRBRXKtEVq3B1wqwCDHcOjn88XLQm+dw-Hhw@mail.gmail.com>
<CANxoLDf2pZExvAawcMcM_Bn-5D=g6iWzVEG0dWsuu-qPnAZYig@mail.gmail.com>
Hi,
Please find the attached patch which adds flexibility to wait for launching
pgAdmin.
Thanks,
Yogesh Mahajan
EnterpriseDB
On Thu, Nov 18, 2021 at 5:15 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Thu, Nov 18, 2021 at 3:23 PM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi,
>>
>> Please find the attached patch which fixes the problem related to
>> feature tests.
>>
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Fri, Nov 12, 2021 at 11:59 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Thu, Nov 11, 2021 at 10:04 PM Yogesh Mahajan <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch which uses selenium 4.0.0a6 which works
>>>> with python 3.6.8.
>>>> Selenium 4.0.0 requires python 3.7+
>>>>
>>>> Thanks,
>>>> Yogesh Mahajan
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Wed, Nov 10, 2021 at 11:59 AM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Thanks, the patch applied. but Jenkins is failing with the below error:
>>>>> ERROR: No matching distribution found for selenium==4.0.0
>>>>> ERROR: Failed to install Python requirements.
>>>>>
>>>>> On Tue, Nov 9, 2021 at 2:48 PM Yogesh Mahajan <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch which fixes feature tests broken due
>>>>>> to react porting changes.
>>>>>>
>>>>>> Thanks,
>>>>>> Yogesh Mahajan
>>>>>> EnterpriseDB
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Principal Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Attachments:
[application/octet-stream] Feature_Test_Fix_React_Porting_v4.patch (2.0K, 3-Feature_Test_Fix_React_Porting_v4.patch)
download | inline diff:
diff --git a/web/regression/runtests.py b/web/regression/runtests.py
index bbd03ca95..a15deeab6 100644
--- a/web/regression/runtests.py
+++ b/web/regression/runtests.py
@@ -604,7 +604,7 @@ def run_parallel_tests(url_client, servers_details, parallel_tests_lists,
ser['name'])
# Launch client url in browser
test_utils.launch_url_in_browser(
- driver_object, url_client, 60)
+ driver_object, url_client, timeout=60)
# Add name for thread
thread_name = "parallel_tests" + ser['name']
@@ -847,10 +847,14 @@ if __name__ == '__main__':
client_url = app_starter_local.start_app()
if config.DEBUG:
+ pgAdmin_wait_time = \
+ selenoid_config['pgAdmin_max_up_time']
print('pgAdmin is launched with DEBUG=True, '
- 'hence sleeping for 50 seconds.',
+ 'hence sleeping for %s seconds.',
+ pgAdmin_wait_time,
file=sys.stderr)
- time.sleep(50)
+
+ time.sleep(int(pgAdmin_wait_time))
# Running Parallel tests
if len(parallel_tests) > 0:
diff --git a/web/regression/test_config.json.in b/web/regression/test_config.json.in
index 4d6b41f69..7ed0847a2 100644
--- a/web/regression/test_config.json.in
+++ b/web/regression/test_config.json.in
@@ -85,6 +85,7 @@
}],
"selenoid_config": {
"pgAdmin_default_server":"IP address of machine where source code is going to be executed",
+ "pgAdmin_max_up_time": 90,
"max_parallel_sessions": "3",
"selenoid_url": "http://<IP address of Selenoid Installed machine>:4444/wd/hub",
"browsers_list":[
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: Feature Test Fix - React porting
In-Reply-To: <CAMa=N=OHsVoYaTYdspiVHnYXhmD=Q074D8awZdTpswRuj-xgFg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox