public inbox for [email protected]  

help / color / mirror / Atom feed

From: Yogesh Mahajan <[email protected]>
To: Dave Page <[email protected]>
Cc: Pravesh Sharma <[email protected]>
Cc: [email protected]
Subject: Re: Require suggestions on issue #7811
Date: Tue, 3 Sep 2024 15:01:31 +0530
Message-ID: <CAMa=N=Oe4sGDxM_s1kng7H1VQjFYR+4tNEjvVanbbPwEx-7Zag@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxozY5-_TZP=T+GfO8up6JVhmJ-aokbV1ZOcq3KWR5wY9kA@mail.gmail.com>
References: <CA+36bxGk6z0A9gvQayub6wmT7fbv6rP_bbjs6Ff37Kxb1cegkA@mail.gmail.com>
	<CA+OCxowvD+kUSm19KijKTNzY9CNBPE=oRS1T84vCmSjqOX4y0Q@mail.gmail.com>
	<CA+36bxFPzSFDYBVpkuXDQM01b=xijGKoA2jzDga5UZguA-AM3w@mail.gmail.com>
	<CA+OCxozY5-_TZP=T+GfO8up6JVhmJ-aokbV1ZOcq3KWR5wY9kA@mail.gmail.com>

Hi Dave,

This isn't the issue in the case of sqlite db while using persistent
storage. Issue appears only if external database is used as pgadmin
configuration db. Just having different way of persistent storage( in this
case backend database) behaviour should not be different.

Also, on restart admin user specified while container is not recreated.
Can't we fix on similar lines?

Thanks,
Yogesh Mahajan
EnterpriseDB


On Tue, Sep 3, 2024 at 2:05 PM Dave Page <[email protected]> wrote:

>
>
> On Tue, 3 Sept 2024 at 09:29, Pravesh Sharma <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Tue, Sep 3, 2024 at 1:47 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Tue, 3 Sept 2024 at 09:10, Pravesh Sharma <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> I am working on issue #7811
>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7811;, where using an
>>>> external database for storing pgAdmin configuration results in duplicate
>>>> server entries when a container with a mapped servers.json file is
>>>> restarted.
>>>>
>>>> The proposed solution is to implement a check when loading servers. We
>>>> would verify the server’s name, host, port, and username to determine if
>>>> the server already exists in the database. If it does, we would skip
>>>> registering it again.
>>>>
>>>>
>>>> Please share any suggestions or feedback on this approach.
>>>>
>>>
>>> I would say "Won't fix". If someone is using persistent storage for
>>> settings, why launch containers to import the same servers over and over
>>> again? Just load them once, manually.
>>>
>> What if the container needs to be restarted? In that case it will again
>> import the server making a duplicate entry.
>>
>
> Not if the servers are manually imported rather than through servers.json.
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>

view thread (10+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Require suggestions on issue #7811
  In-Reply-To: <CAMa=N=Oe4sGDxM_s1kng7H1VQjFYR+4tNEjvVanbbPwEx-7Zag@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox