Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l92vv-0001AM-3v for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 09:34:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l92vu-00024g-2D for pgadmin-hackers@arkaria.postgresql.org; Mon, 08 Feb 2021 09:34:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l92vt-00024Z-Rm for pgadmin-hackers@lists.postgresql.org; Mon, 08 Feb 2021 09:34:13 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l92vs-0002hC-2i for pgadmin-hackers@postgresql.org; Mon, 08 Feb 2021 09:34:13 +0000 Received: by mail-lf1-x12f.google.com with SMTP id d24so1967971lfs.8 for ; Mon, 08 Feb 2021 01:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VngVMKD+mmKeJTMJxmVTAOngwCCk2cfzXRbQqUhGl80=; b=hWlWcQY0u0lZzWvflIpq9Hr2oy+ldTH5uOa5Y0uFQ2DgYbBJFr3SNivdFVF6j7nc1I HiYWvNJHPBecbnfb0YoMXPABXeRu0DSTMAvsYfD90Le82lW8Nu0BRz+CSuUNgSP9zNu/ NJhYhKCkqN4VB2i0SrRr4xr1Xhw7tl3lyJEka9IH0tk6/8sEQFZGTImwOATWYrtEvO6X PN5WqV03s1TifmEF/jrpidBZfBfJ+rWN/PP/qR4iCfv9FUrZheNoXmwQ4HKOPeyj9mpb q7V9c/sc9QgITQ4dsRxLS5bBoC7ar2Fz7H1duMtXoR7PC1czoX1Wpkx9Px0FHweGandY +9cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VngVMKD+mmKeJTMJxmVTAOngwCCk2cfzXRbQqUhGl80=; b=pyZtkI5QOe+N7FEJU7wplHrT+Eppe66QE64qrARXu3KGm6Ds2PhTrvhRjGTrGpnVeR W+H5bAhhro6T5FnJETnQVPwAaeDa9OhSCuE6K2v+JXi9CrL9Syn5ewF0drXsrY8yHzd8 iGQNpuu8uorbh6BtFrIZbfuJHd0ezTVYYMomwfsCu+HI3++uRCyll0z0BS01+1ZHrvfv wyFmprWgAYw4nf49rK4PoRQEgDcCgONHhugMkQPud5lmz4fDDZV8XcB3+qp7KeacscRY Rep31Rgr9OC7Lx03PiC+QIbpSFN/RqUXrIb5OYJTppMwgWIvePnUJUwDGzMXRByxurpj IHtg== X-Gm-Message-State: AOAM531xt7ZVelK96C3e7XXp0iLbtnPZ/2xKdifeJdMqDscgzUt+Vr6i glgaXqsxoy19e9zwoV1WH5gWP7bTqAQvpRkXkIy4qFE0krmhBbEazUnuDAG3SkHoJDM4HcRbPji +GBAyDnlrlihXS9aI23UNSIUF+BsnVPp67y//m+AVUbOZQifAGUE/m6/T3pEcBVTpfLnnDXWJ1a dPp1r0Eg7VKmpFTyKp1fnNv5o5JVsu285wrpKCic82z6qdux4kP3dM3Kwz4MyD+OFMaQ== X-Google-Smtp-Source: ABdhPJz89zom5qyEwhpHIORCTev0TLrywpR+nMBrJnidBOlz2N+AC36XoOLXt6MlCySSXgqSbRN86yiA0N1nF6Ov2HE= X-Received: by 2002:a05:6512:3763:: with SMTP id z3mr10169946lft.639.1612776850658; Mon, 08 Feb 2021 01:34:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Yogesh Mahajan Date: Mon, 8 Feb 2021 15:03:33 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch] - Feature Tests Failure Fix To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000004997d005bacfdfab" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004997d005bacfdfab Content-Type: multipart/alternative; boundary="0000000000004997ce05bacfdfa9" --0000000000004997ce05bacfdfa9 Content-Type: text/plain; charset="UTF-8" Hi, Please find the updated patch. Thanks, Yogesh Mahajan EnterpriseDB On Mon, Feb 8, 2021 at 2:36 PM Akshay Joshi wrote: > Hi Yogesh > > Please fix the PEP8 issues and send the patch again. > > On Mon, Feb 8, 2021 at 1:54 PM Yogesh Mahajan < > yogesh.mahajan@enterprisedb.com> wrote: > >> Hello, >> >> Please find a patch which fixes feature tests failures that occurred due >> to new feature logical replication. >> >> >> Thanks, >> Yogesh Mahajan >> EnterpriseDB >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --0000000000004997ce05bacfdfa9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Please= find the updated patch.

Thanks,
Yogesh Mahajan
EnterpriseDB


On Mon, Feb 8, 20= 21 at 2:36 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Yogesh

Please fix the PEP8 iss= ues and send the patch again.

On Mon, Feb 8, 2021 at 1:54 PM Yogesh Ma= hajan <yogesh.mahajan@enterprisedb.com> wrote:
Hello,<= /div>

Please find a patch which= fixes feature tests failures that occurred due to new feature logical repl= ication.
=

Thanks,
Yogesh M= ahajan
EnterpriseDB
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--0000000000004997ce05bacfdfa9-- --0000000000004997d005bacfdfab Content-Type: application/octet-stream; name="Feature_Tests_Fix_v2.0" Content-Disposition: attachment; filename="Feature_Tests_Fix_v2.0" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kkwdmwpt0 ZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2ZlYXR1cmVfdXRpbHMvdHJlZV9hcmVhX2xvY2F0 b3JzLnB5IGIvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy90cmVlX2FyZWFfbG9jYXRvcnMu cHkKaW5kZXggNjI3NTAzNmJmLi5kNjk2OGU3N2IgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNzaW9u L2ZlYXR1cmVfdXRpbHMvdHJlZV9hcmVhX2xvY2F0b3JzLnB5CisrKyBiL3dlYi9yZWdyZXNzaW9u L2ZlYXR1cmVfdXRpbHMvdHJlZV9hcmVhX2xvY2F0b3JzLnB5CkBAIC0xMDgsMjUgKzEwOCwyOSBA QCBjbGFzcyBUcmVlQXJlYUxvY2F0b3JzKCk6CiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBz dWJfbm9kZXNfb2Zfc2NoZW1hc19ub2RlKGRhdGFiYXNlX25hbWUpOgogICAgICAgICB4cGF0aCA9 ICIvL2RpdltkaXZbZGl2W2RpdltkaXZbc3BhbltzcGFuW3RleHQoKT0nJXMnXV1dXV1dXS8iIFwK LSAgICAgICAgICAgICAgICAiZm9sbG93aW5nLXNpYmxpbmc6OnVsL2xpWzddL3VsL2xpL2Rpdi8v ZGl2L3NwYW4vIiBcCi0gICAgICAgICAgICAgICAgInNwYW5bQGNsYXNzPSdhY2lUcmVlVGV4dCdd IiAlIGRhdGFiYXNlX25hbWUKKyAgICAgICAgICAgICAgICAiZm9sbG93aW5nLXNpYmxpbmc6OnVs L2xpWyIgXAorICAgICAgICAgICAgICAgICJAcm9sZT0ncHJlc2VudGF0aW9uJ10vdWwvbGkvZGl2 Ly9kaXYvc3Bhbi9zcGFuWyIgXAorICAgICAgICAgICAgICAgICJAY2xhc3M9J2FjaVRyZWVUZXh0 J10iICUgZGF0YWJhc2VfbmFtZQogICAgICAgICByZXR1cm4geHBhdGgKIAogICAgIEBzdGF0aWNt ZXRob2QKICAgICBkZWYgc3ViX25vZGVzX29mX3NjaGVtYXNfbm9kZV9leHBfc3RhdHVzKGRhdGFi YXNlX25hbWUpOgogICAgICAgICB4cGF0aCA9ICIvL2RpdltkaXZbZGl2W2RpdltkaXZbc3Bhbltz cGFuW3RleHQoKT0nJXMnXV1dXV1dXS8iIFwKLSAgICAgICAgICAgICAgICAiZm9sbG93aW5nLXNp Ymxpbmc6OnVsL2xpWzddL3VsL2xpL2RpdiIgJSBkYXRhYmFzZV9uYW1lCisgICAgICAgICAgICAg ICAgImZvbGxvd2luZy1zaWJsaW5nOjp1bC9saVtAcm9sZT0ncHJlc2VudGF0aW9uJ10vdWwvbGkv ZGl2IiBcCisgICAgICAgICAgICAgICAgJSBkYXRhYmFzZV9uYW1lCiAgICAgICAgIHJldHVybiB4 cGF0aAogCiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBzdWJfbm9kZXNfb2Zfc2NoZW1hX25v ZGUoZGF0YWJhc2VfbmFtZSk6CiAgICAgICAgIHhwYXRoID0gIi8vZGl2W2RpdltkaXZbZGl2W2Rp dltzcGFuW3NwYW5bdGV4dCgpPSclcyddXV1dXV1dLyIgXAotICAgICAgICAgICAgICAgICJmb2xs b3dpbmctc2libGluZzo6dWwvbGlbN10vdWwvbGkvdWwvbGkvZGl2Ly9kaXYvIiBcCi0gICAgICAg ICAgICAgICAgInNwYW5bMl0vc3BhblsyXSIgJSBkYXRhYmFzZV9uYW1lCisgICAgICAgICAgICAg ICAgImZvbGxvd2luZy1zaWJsaW5nOjp1bC9saVsiIFwKKyAgICAgICAgICAgICAgICAiQHJvbGU9 J3ByZXNlbnRhdGlvbiddL3VsL2xpL3VsL2xpL2Rpdi8vZGl2L3NwYW5bMl0vc3BhblsyXSIgXAor ICAgICAgICAgICAgICAgICUgZGF0YWJhc2VfbmFtZQogICAgICAgICByZXR1cm4geHBhdGgKIAog ICAgIEBzdGF0aWNtZXRob2QKICAgICBkZWYgc3ViX25vZGVzX29mX3NjaGVtYV9ub2RlX2V4cF9z dGF0dXMoZGF0YWJhc2VfbmFtZSk6CiAgICAgICAgIHhwYXRoID0gIi8vZGl2W2RpdltkaXZbZGl2 W2RpdltzcGFuW3NwYW5bdGV4dCgpPSclcyddXV1dXV1dLyIgXAotICAgICAgICAgICAgICAgICJm b2xsb3dpbmctc2libGluZzo6dWwvbGlbN10vdWwvbGkvdWwvbGkvZGl2IiAlIGRhdGFiYXNlX25h bWUKKyAgICAgICAgICAgICAgICAiZm9sbG93aW5nLXNpYmxpbmc6OnVsL2xpW0Byb2xlPSdwcmVz ZW50YXRpb24nXSIgXAorICAgICAgICAgICAgICAgICIvdWwvbGkvdWwvbGkvZGl2IiAlIGRhdGFi YXNlX25hbWUKICAgICAgICAgcmV0dXJuIHhwYXRoCg== --0000000000004997d005bacfdfab--