Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llVFZ-0007VY-4I for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 May 2021 11:29:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1llVFY-00064c-2b for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 May 2021 11:29:28 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llVFX-00064U-Ho for pgadmin-hackers@lists.postgresql.org; Tue, 25 May 2021 11:29:27 +0000 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1llVFQ-0003td-K6 for pgadmin-hackers@postgresql.org; Tue, 25 May 2021 11:29:26 +0000 Received: by mail-lj1-x235.google.com with SMTP id f12so37646122ljp.2 for ; Tue, 25 May 2021 04:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=icJa+ZbhXo8BMVzc0Po8fiVquZ+8CdMOXY4M0fNm8NQ=; b=F677PDj2FcusmLu9YpPgWlf8yv7rcbApLLtLBT+r2OTePjWQDwioFTtjTvW9aniZ8J /uSdqhP4IDNalmL3sYD06YYcepbXblbU56xFSM/LGmBu3oaDPO+/HAP25bI2gAl4Ti2O pv+X3x+tv0kB4BbgBjUwGEW5tt6eCB1jUkg/pp2lKF4jN7+gRSRUi1SzXHMB3Ziv+Z8L a3Ah5s2xKciukc5zfvxHPOQUwvsKBkulAxOwa0mey4sKqkkP2KheANmFdyZacSFiwrWB 19uW+GMSPcH7KPgIsHdkxGNd5R7wqhMZaoXPYcK6em0cna+QAbba81YByUEew1sjkigc A2FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=icJa+ZbhXo8BMVzc0Po8fiVquZ+8CdMOXY4M0fNm8NQ=; b=sQzbw+R5dZID3Ui3x6uX4VDHAO+HU43v5GPKnOgbzWFTdIzhqKjcoOusG5UNokneQD qd97ihI8z2AKpnlemOQpAStT7KOlpnoUhTgGcqPjg0uw7TFcGoA2Ax/96q4e9UfxFQzL /EPC03ZY57GvSblcjhHcjs0aIMrDasWD1Ryf4lHo3oGT/NfFYsqWm3AXPMUGm0tUhJuH MWnQFzvRILX6qi3pK+L9jpeM7xPja/c8IDJJoH4DliwLNQSw+Brv9UN3Uw1ZFP8d6+P1 38pDQxqM7/QBaE+npJAwZml3RSufXRkixAHteKGtqQH2IMKDShw9x7fm+kc1+kujTYEM oGhw== X-Gm-Message-State: AOAM531O4xlQa08RDOcEsyoMOJ7SKLhJpRQ9/jwfoS/7jRFodYQ+wSDI UNtyksclKPS26K9HmKOag0aX5SpBr30ALE94HKX0wsfnFqTltW4/iVUIJoZ/yBBa2t9uiOIxpfC AgR0bnjlJUo4fEBgcGrzi88F/vHfIu+jF9a0ZqjaKOwQGXT5kXaVERzac2LkF42hQf7wuFBnNn/ xUnn3bo6MaQUdGiTMz1pqrp8Sz7YM7iklPpLdM3shLZCcDxVTSYySLvIH4XmvAlXKacQ== X-Google-Smtp-Source: ABdhPJzddBl0oY5SrqAETgI9TVhdBBN6JeMcVCkNLKpFvYxBUjc30vIddrXZafSPXz6Wh4H4hH2yES1CtFQrKpfP1vQ= X-Received: by 2002:a2e:8946:: with SMTP id b6mr20641607ljk.389.1621942158289; Tue, 25 May 2021 04:29:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Yogesh Mahajan Date: Tue, 25 May 2021 16:58:42 +0530 Message-ID: Subject: Re: [pgAdmin][Patch] - Feature #6395 - Feature request: Log Rotation To: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000031468b05c325d6bf" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000031468b05c325d6bf Content-Type: multipart/alternative; boundary="00000000000031468905c325d6bd" --00000000000031468905c325d6bd Content-Type: text/plain; charset="UTF-8" Hello, Please find the attached file incorporated with the above comments except the 2nd one. Thanks, Yogesh Mahajan EnterpriseDB On Tue, May 25, 2021 at 1:09 PM Akshay Joshi wrote: > Hi Yogesh > > Following are the review comments: > > - LOG_ROTATION_MAX_LOGS should be renamed to LOG_ROTATION_MAX_LOG_FILES > - Rollover file name should have '.log' extension at the end instead > of "pgadmin4.log.2021-05-25_12-17-43" > - Add comments in the 'enhanced_log_rotation.py' file. > - 'enhanced_log_rotation.py' file line no 23 should be "max_bytes = > max_bytes * 1024 * 1024" instead of "max_bytes = max_bytes * 1000000" > > > On Tue, May 25, 2021 at 10:54 AM Yogesh Mahajan < > yogesh.mahajan@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch which rotates the pgadmin log file with >> context to the parameters specified in the config file. >> >> # Log rotation setting >> LOG_ROTATION_SIZE = 10 # In MBs >> LOG_ROTATION_AGE = 1440 # In minutes >> LOG_ROTATION_MAX_LOGS = 90 # Maximum number of backups to retain >> >> >> Thanks, >> Yogesh Mahajan >> EnterpriseDB >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --00000000000031468905c325d6bd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Pl= ease find the attached file incorporated with the above comments except the= 2nd one.

Thanks,
= Yogesh Mahajan
Enterpri= seDB


On Tue, May 25, 2021 at 1:09 PM = Akshay Joshi <akshay.jo= shi@enterprisedb.com> wrote:
Hi=C2=A0Yogesh

Following are the review comments:
  • LOG_ROTATION_MAX_LOGS should be rena= med to LOG_ROTATION_MAX_LOG_FILES
  • Rollover file name should have '.log' extension at the end instea= d of "pgadmin4.log.2021-05-25_12-17-43"
  • Add= comments in the 'enhanced_log_rotation.py' file.
  • =C2=A0= 9;enhanced_log_rotation.py' file line no 23 should=C2=A0be "max_by= tes =3D max_bytes * 1024 * 1024" instead of "m= ax_bytes =3D max_bytes * 1000000"

On Tue, May 25, 2021 at 10:54 AM Yogesh Mahajan <yogesh.mahajan@enterprisedb= .com> wrote:
Hi,

Please find the attached patch which rotates the p= gadmin log file with context to the parameters specified in the config file= .

# Log rotation setting
LOG_ROTATION_SIZE =3D 10  # In MBs
LOG_ROTATION_AGE =3D 1440  # In minutes
LOG_ROTATION_MAX_LOGS =3D 90  # Maximum number of backups to retain

Thanks,
Yogesh Mahajan
EnterpriseDB


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--00000000000031468905c325d6bd-- --00000000000031468b05c325d6bf Content-Type: application/octet-stream; name="RM6395_v2.patch" Content-Disposition: attachment; filename="RM6395_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kp3ybz510 ZGlmZiAtLWdpdCBhL3dlYi9jb25maWcucHkgYi93ZWIvY29uZmlnLnB5CmluZGV4IDRkMWY5ODY5 OC4uYmRiMmU2ZjNmIDEwMDY0NAotLS0gYS93ZWIvY29uZmlnLnB5CisrKyBiL3dlYi9jb25maWcu cHkKQEAgLTI4Niw2ICsyODYsMTMgQEAgaWYgU0VSVkVSX01PREUgYW5kIG5vdCBJU19XSU46CiBl bHNlOgogICAgIExPR19GSUxFID0gb3MucGF0aC5qb2luKERBVEFfRElSLCAncGdhZG1pbjQubG9n JykKIAorIyBMb2cgcm90YXRpb24gc2V0dGluZworIyBMb2cgZmlsZSB3aWxsIGJlIHJvdGF0ZWQg Y29uc2lkZXJpbmcgdmFsdWVzIGZvciBMT0dfUk9UQVRJT05fU0laRQorIyAmIExPR19ST1RBVElP Tl9BR0UuIFJvdGF0ZWQgZmlsZSB3aWxsIGJlIG5hbWVkIGluIGZvcm1hdAorIyAtIExPR19GSUxF LlktbS1kX0gtTS1TCitMT0dfUk9UQVRJT05fU0laRSA9IDEwICAjIEluIE1CcworTE9HX1JPVEFU SU9OX0FHRSA9IDE0NDAgICMgSW4gbWludXRlcworTE9HX1JPVEFUSU9OX01BWF9MT0dfRklMRVMg PSA5MCAgIyBNYXhpbXVtIG51bWJlciBvZiBiYWNrdXBzIHRvIHJldGFpbgogIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMKICMgU2VydmVyIENvbm5lY3Rpb24gRHJpdmVyIFNldHRpbmdzCiAjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vX19pbml0X18ucHkgYi93ZWIvcGdhZG1pbi9f X2luaXRfXy5weQppbmRleCBhNzMzMzUzNzEuLjRmZGMxZTAwOSAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vX19pbml0X18ucHkKQEAgLTI1Niw3 ICsyNTYsMTMgQEAgZGVmIGNyZWF0ZV9hcHAoYXBwX25hbWU9Tm9uZSk6CiAgICAgICAgIGNyZWF0 ZV9hcHBfZGF0YV9kaXJlY3RvcnkoY29uZmlnKQogCiAgICAgICAgICMgRmlsZSBsb2dnaW5nCi0g ICAgICAgIGZoID0gbG9nZ2luZy5GaWxlSGFuZGxlcihjb25maWcuTE9HX0ZJTEUsIGVuY29kaW5n PSd1dGYtOCcpCisgICAgICAgIGZyb20gcGdhZG1pbi51dGlscy5lbmhhbmNlZF9sb2dfcm90YXRp b24gaW1wb3J0IFwKKyAgICAgICAgICAgIEVuaGFuY2VkUm90YXRpbmdGaWxlSGFuZGxlcgorICAg ICAgICBmaCA9IEVuaGFuY2VkUm90YXRpbmdGaWxlSGFuZGxlcihjb25maWcuTE9HX0ZJTEUsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbmZpZy5MT0dfUk9UQVRJ T05fU0laRSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uZmln LkxPR19ST1RBVElPTl9BR0UsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbmZpZy5MT0dfUk9UQVRJT05fTUFYX0xPR19GSUxFUykKKwogICAgICAgICBmaC5zZXRM ZXZlbChjb25maWcuRklMRV9MT0dfTEVWRUwpCiAgICAgICAgIGZoLnNldEZvcm1hdHRlcihsb2dn aW5nLkZvcm1hdHRlcihjb25maWcuRklMRV9MT0dfRk9STUFUKSkKICAgICAgICAgYXBwLmxvZ2dl ci5hZGRIYW5kbGVyKGZoKQpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdXRpbHMvZW5oYW5jZWRf bG9nX3JvdGF0aW9uLnB5IGIvd2ViL3BnYWRtaW4vdXRpbHMvZW5oYW5jZWRfbG9nX3JvdGF0aW9u LnB5Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMC4uMDBjNWU5Mzk5Ci0tLSAv ZGV2L251bGwKKysrIGIvd2ViL3BnYWRtaW4vdXRpbHMvZW5oYW5jZWRfbG9nX3JvdGF0aW9uLnB5 CkBAIC0wLDAgKzEsNTkgQEAKKyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCisjCisjIHBnQWRtaW4gNCAtIFBv c3RncmVTUUwgVG9vbHMKKyMKKyMgQ29weXJpZ2h0IChDKSAyMDEzIC0gMjAyMSwgVGhlIHBnQWRt aW4gRGV2ZWxvcG1lbnQgVGVhbQorIyBUaGlzIHNvZnR3YXJlIGlzIHJlbGVhc2VkIHVuZGVyIHRo ZSBQb3N0Z3JlU1FMIExpY2VuY2UKKyMKKyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCisKK2ltcG9ydCByZQor aW1wb3J0IGxvZ2dpbmcuaGFuZGxlcnMgYXMgaGFuZGxlcnMKKworCitjbGFzcyBFbmhhbmNlZFJv dGF0aW5nRmlsZUhhbmRsZXIoaGFuZGxlcnMuVGltZWRSb3RhdGluZ0ZpbGVIYW5kbGVyLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGhhbmRsZXJzLlJvdGF0aW5nRmlsZUhhbmRs ZXIpOgorICAgICIiIgorICAgIEhhbmRsZXIgZm9yIGxvZ2dpbmcgdG8gYSBzZXQgb2YgZmlsZXMs IHdoaWNoIHN3aXRjaGVzIGZyb20gb25lIGZpbGUKKyAgICB0byB0aGUgbmV4dCB3aGVuIHRoZSBj dXJyZW50IGZpbGUgcmVhY2hlcyBhIGNlcnRhaW4gc2l6ZSwgb3IgYXQgY2VydGFpbgorICAgIHRp bWVkIGludGVydmFscworICAgIEBmaWxlbmFtZSAtIGxvZyBmaWxlIG5hbWUKKyAgICBAbWF4X2J5 dGVzIC0gZmlsZSBzaXplIGluIGJ5dGVzIHRvIHJvdGF0ZSAgZmlsZQorICAgIEBpbnRlcnZhbCAt IER1cmF0aW9uIHRvIHJvdGF0ZSBmaWxlCisgICAgQGJhY2t1cF9jb3VudCAtIE1heGltdW0gbnVt YmVyIG9mIGZpbGVzIHRvIHJldGFpbgorICAgIEBlbmNvZGluZyAtIGZpbGUgZW5jb2RpbmcKKyAg ICBAd2hlbiAtICAnd2hlbicgZXZlbnRzIHN1cHBvcnRlZDoKKyAgICAgICAgICAgICMgUyAtIFNl Y29uZHMKKyAgICAgICAgICAgICMgTSAtIE1pbnV0ZXMKKyAgICAgICAgICAgICMgSCAtIEhvdXJz CisgICAgICAgICAgICAjIEQgLSBEYXlzCisgICAgICAgICAgICAjIG1pZG5pZ2h0IC0gcm9sbCBv dmVyIGF0IG1pZG5pZ2h0CisgICAgICAgICAgICAjIFd7MC02fSAtIHJvbGwgb3ZlciBvbiBhIGNl cnRhaW4gZGF5OyAwIC0gTW9uZGF5CisgICAgSGVyZSB3ZSBhcmUgZGVmYXVsdGluZyByb3RhdGlv biB3aXRoIG1pbnV0ZXMgaW50ZXJ2YWwKKyAgICAiIiIKKyAgICBkZWYgX19pbml0X18oc2VsZiwg ZmlsZW5hbWUsIG1heF9ieXRlcz0xLCBpbnRlcnZhbD02MCwgYmFja3VwX2NvdW50PTAsCisgICAg ICAgICAgICAgICAgIGVuY29kaW5nPU5vbmUsIHdoZW49J00nKToKKyAgICAgICAgbWF4X2J5dGVz ID0gbWF4X2J5dGVzICogMTAyNCAqIDEwMjQKKyAgICAgICAgaGFuZGxlcnMuVGltZWRSb3RhdGlu Z0ZpbGVIYW5kbGVyLl9faW5pdF9fKHNlbGYsIGZpbGVuYW1lPWZpbGVuYW1lLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgd2hlbj13aGVuLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZXJ2YWw9 aW50ZXJ2YWwsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBiYWNrdXBDb3VudD1iYWNrdXBfY291bnQsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlbmNvZGluZz1lbmNvZGluZykKKworICAgICAgICBo YW5kbGVycy5Sb3RhdGluZ0ZpbGVIYW5kbGVyLl9faW5pdF9fKHNlbGYsIGZpbGVuYW1lPWZpbGVu YW1lLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1vZGU9 J2EnLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1heEJ5 dGVzPW1heF9ieXRlcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBiYWNrdXBDb3VudD1iYWNrdXBfY291bnQsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgZW5jb2Rpbmc9ZW5jb2RpbmcpCisKKyAgICAjIFRpbWUgJiBT aXplIGNvbWJpbmVkIHJvbGxvdmVyCisgICAgZGVmIHNob3VsZFJvbGxvdmVyKHNlbGYsIHJlY29y ZCk6CisgICAgICAgIHJldHVybiBoYW5kbGVycy5UaW1lZFJvdGF0aW5nRmlsZUhhbmRsZXIuc2hv dWxkUm9sbG92ZXIoc2VsZiwgcmVjb3JkKSBcCisgICAgICAgICAgICBvciBoYW5kbGVycy5Sb3Rh dGluZ0ZpbGVIYW5kbGVyLnNob3VsZFJvbGxvdmVyKHNlbGYsIHJlY29yZCkKKworICAgICMgUm9s bCBvdmVycyBjdXJyZW50IGZpbGUKKyAgICBkZWYgZG9Sb2xsb3ZlcihzZWxmKToKKyAgICAgICAg c2VsZi5zdWZmaXggPSAiJVktJW0tJWRfJUgtJU0tJVMiCisgICAgICAgIHNlbGYuZXh0TWF0Y2gg PSByIl5cZHs0fS1cZHsyfS1cZHsyfV9cZHsyfS1cZHsyfS1cZHsyfShcLlx3Kyk/JCIKKyAgICAg ICAgc2VsZi5leHRNYXRjaCA9IHJlLmNvbXBpbGUoc2VsZi5leHRNYXRjaCwgcmUuQVNDSUkpCisg ICAgICAgIGhhbmRsZXJzLlRpbWVkUm90YXRpbmdGaWxlSGFuZGxlci5kb1JvbGxvdmVyKHNlbGYp Cg== --00000000000031468b05c325d6bf--