Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8l8W-0002R4-A3 for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 09:11:24 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b8l8V-0001XP-Nh for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 09:11:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b8l8U-0001XG-3Z for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 09:11:22 +0000 Received: from mail-qt0-x235.google.com ([2607:f8b0:400d:c0d::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b8l8J-0004gN-Hu for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 09:11:21 +0000 Received: by mail-qt0-x235.google.com with SMTP id d51so9795101qte.2 for ; Fri, 03 Jun 2016 02:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=eKvNudjY7Zpk7ND5LgMogLB6vvzFIhYyQHjsMlR+ySM=; b=nUmEvVjOAZHsGngq0d6RvXP2is5oQbh+FS1nHrXRiUJcp6CdhnQgAe7yEGcNDNcNyb oPYTIs72GueP4sqfbSyo8sZLfCGsyLSitPQD1sO1y38GFHPJvZx/Xf8fOtyz5qEDyJva /C16ftuEVWPTw39ZvHACB13FUkaG8aZlIBzwEUNIRKqpAIDrdtdljAkhzj6UMqHe0Mep to7th0eNBbQDyCDgvSK/R2zcufEEyBa+nhqAXQ8MneQi7O4F3SGZaRipD42RNeRsHpAt /7Y+s6s9EYHpUIYf6WW0S/FAdQMqshwb6iT8CiYdplMjE7HDb4FgRRyWDyuQ7cYhmG0C dWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=eKvNudjY7Zpk7ND5LgMogLB6vvzFIhYyQHjsMlR+ySM=; b=OqVPJf41zJUXuyzkI5Dfp1owUeR7mPuP1HA+yfyZLApyYGQ4QJ8UmITeEamUFZbIrI 12diWeN49PSnjmcUY2E87nHEmBVcsVe/7pdeXoWkK7LPJaP7KvZtbVTdnhvdKNNvS/+G KIdI2iBuWf261SqJ1P659tNjQKD/uOKbVftm2wcH2IBpWhyTtu75Jh0fIt0Y1d0asquZ /Jy+jxhHTnLi3I2XvZNtKlYcsd4Ecj7Zpsp5mSpoL7UinZ9kfwU+PqQWsyPHDSIEyDtj Kuud2Sq7EsiPvN0ygEdLSJA+jOrpun3v8rYILyEb2MmECDDzSbgQ5VJaZBd4ProvmCp7 f/4A== X-Gm-Message-State: ALyK8tK1KkDAaFapFUsgq+wNhHVr0yZR+TkBeJcgzowWg410bRxQxF5Vfq8FsdBGxTM4QXLUPEeBL3gnr8Wovmqk MIME-Version: 1.0 X-Received: by 10.200.47.6 with SMTP id j6mr2183411qta.85.1464945069361; Fri, 03 Jun 2016 02:11:09 -0700 (PDT) Received: by 10.140.101.198 with HTTP; Fri, 3 Jun 2016 02:11:09 -0700 (PDT) In-Reply-To: References: Date: Fri, 3 Jun 2016 14:41:09 +0530 Message-ID: Subject: Re: Patch for pgAdmin4 RPM package From: Sandeep Thakkar To: Dave Page Cc: pgadmin-hackers , Hamid Quddus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary=001a1136f16c79c58705345c1ad3 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1136f16c79c58705345c1ad3 Content-Type: text/plain; charset=UTF-8 Thanks Dave. On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: > Hi > > On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar > wrote: > > Hi Devrim, Hi Dave, > > > > I have updated the patch. The earlier patch may fail because of app > bundle > > commit in git. > > > > For testing, you may define the source tarball location as : > > Source0: > > > http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz > > > > Known issue that I'm still working on: > > 1. web rpm has a dependency on doc. But, even if I install doc, the web > > still complains. Here is the scenario: > > [root@localhost tmp]# rpm -ivh > > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm > > error: Failed dependencies: > > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch > > ... ( trimmed the python dependencies list here...) > > > > [root@localhost tmp]# rpm -ivh > > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm > > Preparing... ################################# > > [100%] > > Updating / installing... > > 1:pgadmin4-docs-1.0_dev-1.rhel7 ################################# > > [100%] > > > > > > [root@localhost tmp]# yum list | grep pgadmin4-docs > > pgadmin4-docs.noarch 1.0_dev-1.rhel7 > > installed > > > > > > [root@localhost tmp]# rpm -ivh > > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm > > error: Failed dependencies: > > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch > > You have a typo - the Requires line is for pgadmin4-doc, but the RPM > is pgadmin4-docs. > > Oh, right. > Other review comments: > > - We have multiple identical pgadmin4.spec.in's in the patch. We need > to get that down to a single file. > > - In fact, why do we need a directory for each distro at all? As far > as I can see, the only difference is the $DIST definition, which is > surely something we can get programmatically very easily. It seems to > me we could reduce this all to 3 files - Makefile, README and > pgadmin4.spec.in > > Agree. I copied the structure from somewhere thinking this is good to have more OS specific changes. > - make rpm has a dependency on make prep. This has 2 issues as far as I > can see: > > - It does a git pull, which is bad. If I'm making an RPM from within > the source tree, I want it for the current source. The git pull only > makes sense for external builds, i.e. in a much larger automated build > system. > > - It goes and grabs the source code and patches from the FTP site. > Again, this is not what I want for an "in-tree" build. I want to use > the source code as I have it now. > > Okay. got it. Will remove downloading the tarballs and build the cloned source. > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sandeep Thakkar --001a1136f16c79c58705345c1ad3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks Dave.=C2=A0

On Fri, Jun 3, 2016 at 2:08 PM, Dave Page <dpage@p= gadmin.org> wrote:
Hi

On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
<sandeep.thakkar@ent= erprisedb.com> wrote:
> Hi Devrim, Hi Dave,
>
> I have updated the patch. The earlier patch may fail because of app bu= ndle
> commit in git.
>
> For testing, you may define the source tarball location as :
> Source0:
> http://bugatti.pn= .in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz
>
> Known issue that I'm still working on:
> 1. web rpm has a dependency on doc. But, even if I install doc, the we= b
> still complains. Here is the scenario:
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch
> ... ( trimmed the python dependencies list here...)
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> Preparing...=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #################################
> [100%]
> Updating / installing...
>=C2=A0 =C2=A0 1:pgadmin4-docs-1.0_dev-1.rhel7=C2=A0 =C2=A0 ############= #####################
> [100%]
>
>
> [root@localhost tmp]# yum list | grep pgadmin4-docs
> pgadmin4-docs.noarch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 1.0_dev-1.rhel7
> installed
>
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch

You have a typo - the Requires line is for pgadmin4-doc, but th= e RPM
is pgadmin4-docs.

Oh, right.
=C2=A0
Other review comments:

- We have multiple identical pgadmin4.spec.in's in the patch. We need=
to get that down to a single file.

- In fact, why do we need a directory for each distro at all? As far
as I can see, the only difference is the $DIST definition, which is
surely something we can get programmatically very easily. It seems to
me we could reduce this all to 3 files - Makefile, README and
pg= admin4.spec.in

Agree. I copied the structure from somewhere thinking= this is good to have more OS specific changes.
=C2=A0
- make rpm has a dependency on make prep. This has 2 issues as far as I can= see:

=C2=A0 - It does a git pull, which is bad. If I'm making an RPM from wi= thin
the source tree, I want it for the current source. The git pull only
makes sense for external builds, i.e. in a much larger automated build
system.

=C2=A0 - It goes and grabs the source code and patches from the FTP site. Again, this is not what I want for an "in-tree" build. I want to = use
the source code as I have it now.

O= kay. got it. Will remove downloading the tarballs and build the cloned sour= ce.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
=
Sandeep Thakkar

--001a1136f16c79c58705345c1ad3--