public inbox for [email protected]
help / color / mirror / Atom feedFrom: Sandeep Thakkar <[email protected]>
To: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Hamid Quddus <[email protected]>
Subject: Re: Patch for pgAdmin4 package on Mac OS X
Date: Thu, 2 Jun 2016 18:35:54 +0530
Message-ID: <CANFyU94sG07rBdyGKTRstKS-JxYmA563JoFSQgu05TTBoj9kjQ@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxoyAeLWFJocjud5D4OKDLbgZVAdKw78YnrE8Rry23zxzVg@mail.gmail.com>
References: <CANFyU95gNg6AznegkT1=zXZNcFmaahPtO5_e-RpfuyLEu0c7dA@mail.gmail.com>
<CA+OCxowni+YFdwSgf7d4OPN1c-8waJvfu4QCV2pLdw+YO433iA@mail.gmail.com>
<CANFyU96f4a9Zn2czw3Ch_k0w1cyiwiY4KDdyScQgWnW9vQsM-A@mail.gmail.com>
<CA+OCxox=MSTfMNB8WR5CEAjbSheVNTx_7jmUdpyzjOW5f4RDUQ@mail.gmail.com>
<CANFyU95BNuQkGTBoLY-LYHS1mRMWQF3zERQuv0bnHhR395SQxA@mail.gmail.com>
<CA+OCxozgWgaa_HsbYRRRNoQOGr0tC48GW8f2PB1Q0d17zKBiZQ@mail.gmail.com>
<CANFyU97jAp2xYyYBo9nfpMVcVa=Dv05uBXWX5L8kLiTVmicghA@mail.gmail.com>
<CA+OCxozZBvL4v8dRdOWhfm2DqwSg7L_MiuJj-L4mbsr8Hg4CyQ@mail.gmail.com>
<CANFyU95gbc7etZebjvnYGhjs2=kz8=0Gd6s0qzm280ZNR2Fbrg@mail.gmail.com>
<CA+OCxowbiq_04h3ain47nkBNY=5brPtrW4=9yft042Ju9GtReQ@mail.gmail.com>
<CANFyU94GTupD+a_CzdTvJ7-fjrinD-PvhRRmo2soLavLBvpveA@mail.gmail.com>
<CA+OCxoxFap1FVqsrcHG4QU2zDUu6v_5WkyYO3xYyS2yufbq5AA@mail.gmail.com>
<CANFyU970rjd+thJ0+DThkurNCE5Xg-Zv3y0sp96od7yihQrsgg@mail.gmail.com>
<CA+OCxowVMN3btVYwBiOq2BtNdRKaFoN950F_ZTm5hmekLZtPdA@mail.gmail.com>
<CANFyU94k1AbRnMLMtze9GMpxMmtG4D_aitiemzvbTHmC9dzG_Q@mail.gmail.com>
<CANFyU97a-top6G2S=8-PqqDmHKaSCKM6PK4RJPgUM9aGgBmqOw@mail.gmail.com>
<CANFyU96iUVCo5ySGiimmi9NV9rS72nvzuT9BJcHjFcJwyADooQ@mail.gmail.com>
<CA+OCxowGK1-Q_XQ-ZimQTDnusSXjS+6aYAVEV9OjALW0Kt7S4g@mail.gmail.com>
<CANFyU95OCXvqouhUZUzdQajXV8kymKNce1yFmv27eE=dF3e-kQ@mail.gmail.com>
<CA+OCxoyr9+e4=EehNR_wRZWB4hRNS-NS8bRyFfaMhCjUb4i-Zw@mail.gmail.com>
<CA+OCxowH3VuE4vbLvjw58JpMzJSoZQ5mT-hQcK6at4XR9V+TyA@mail.gmail.com>
<CANFyU96JMJTOESZZ72UAV8RJa2ZdnfKEPsrm-nA3K2n5mq2F+w@mail.gmail.com>
<CANFyU960RSj89b1BgnV9S3n37YXURfSF40p2xaEDBrBKEZOVTA@mail.gmail.com>
<CA+OCxoxvaV0V9QMMvVO0YCfPPmVVH+F_CWkgpnzo29tOU51OOw@mail.gmail.com>
<CANFyU95VN6meqnHAERq21V4QSuVsLEEvw_QDpDXBM6n9nvxxcA@mail.gmail.com>
<CA+OCxoyAeLWFJocjud5D4OKDLbgZVAdKw78YnrE8Rry23zxzVg@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Thanks Dave!
I saw the runtime code and observed one change (prepend -> append) . Was it
not saving the location because of this?
On Thu, Jun 2, 2016 at 6:27 PM, Dave Page <[email protected]> wrote:
> Thanks - applied with some tweaks to the runtime code (i.e. not saving
> the location of the venv in the appbundle).
>
> On Tue, May 31, 2016 at 6:37 PM, Sandeep Thakkar
> <[email protected]> wrote:
> > Hi Dave,
> >
> >
> > On Tue, May 31, 2016 at 9:29 PM, Dave Page <[email protected]> wrote:
> >>
> >> Hi,
> >>
> >> On the first run, I get:
> >>
> >> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin
> >> 4.app
> >> ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
> >> Cleaning up
> >> Copying data into temporary directory
> >> cp: ./../mac-build/pgAdmin 4.app: No such file or directory
> >> create-dmg.sh failed
> >> make: *** [appbundle] Error 1
> >>
> >> If I run it again, I get:
> >>
> >> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin
> >> 4.app
> >> ./pkg/mac/create-dmg.sh: line 6: cd: dist: No such file or directory
> >> Directory ./pgadmin4-1.0-dev.dmg.src already exists. Please delete it
> >> manually.
> >> create-dmg.sh failed
> >> make: *** [appbundle] Error 1
> >>
> >> If I manually create $SRC/dist, it's much happier.
> >>
> > I have used variable for dist. It will create the directory if doesn't
> > exist. The clean-appbunde will also remove the .src directory in dist
> just
> > in case it is present.
> >
> >> Other issues:
> >>
> >> - Your changes to the runtime don't seem to help. I've been staring at
> >> the code for an hour or so now, and I can't see the issue though. We
> >> may need some fresh eyes.
> >>
> > yeah, I also spent more time to see the code and test it. Infact, I could
> > hardly reproduce it 1 or 2 times.
> >
> >>
> >> - pkg/mac/create-dmg.sh is mixing upper and lower case variable names
> >> and with/without _, e.g. $dmgname vs $DMG_NAME
> >>
> > not sure, why I used lower case, I prefer upper case always. I have made
> the
> > changes now to use upper case for all variables.
> >
> >>
> >> - Shoudn't DMG_NAME be initialised to `grep "^APP_NAME" web/config.py
> >> | cut -d"=" -f2 | sed "s/'//g"` ?
> >>
> > yes, I have used the couple of more variables that gives proper
> > understanding.
> >
> > Thanks! I have attached the updated patch. (runtime changes remains
> same).
> >>
> >>
> >> On Tue, May 31, 2016 at 1:19 PM, Sandeep Thakkar
> >> <[email protected]> wrote:
> >> > Somehow the patch skipped the Makefile changes. Attached is the
> updated
> >> > patch.
> >> >
> >> > On Mon, May 30, 2016 at 6:00 PM, Sandeep Thakkar
> >> > <[email protected]> wrote:
> >> >>
> >> >> Thanks. I have fixed all the issues.
> >> >>
> >> >> Regarding the app not running from within the DMG for the first
> time, I
> >> >> was unable to reproduce it on Zilan's machine which didn't have the
> >> >> development env. On Murali's machine, it was reproducible for 1 time
> >> >> after
> >> >> couple of attempts.
> >> >>
> >> >> So, I just added the sync statement after settings the pythonpath
> value
> >> >> in
> >> >> the settings. May be this will resolve the issue. Please confirm.
> >> >> settings.sync();
> >> >>
> >> >> Attached is the updated patch. Thanks.
> >> >>
> >> >> On Fri, May 27, 2016 at 9:28 PM, Dave Page <[email protected]>
> wrote:
> >> >>>
> >> >>> On Fri, May 27, 2016 at 4:48 PM, Dave Page <[email protected]>
> wrote:
> >> >>> >
> >> >>> >
> >> >>> > On Fri, May 27, 2016 at 1:11 PM, Sandeep Thakkar
> >> >>> > <[email protected]> wrote:
> >> >>> >>
> >> >>> >> Sure. Thanks.
> >> >>> >>
> >> >>> >> There is a typo in pkg/mac/build.sh. i.e
> >> >>> >>
> >> >>> >> s/HTML_HELP/HELP_PATH/
> >> >>> >>
> >> >>> >>
> >> >>> >> On Fri, May 27, 2016 at 5:26 PM, Dave Page <[email protected]>
> >> >>> >> wrote:
> >> >>> >>>
> >> >>> >>> Not entirely - we definitely need to improve it. I'll review the
> >> >>> >>> code
> >> >>> >>> as
> >> >>> >>> it is now though.
> >> >>> >
> >> >>> >
> >> >>> > OK, review time :-)
> >> >>> >
> >> >>> > - The appbundle name should be created from APP_NAME.app in
> >> >>> > config.py,
> >> >>> > e.g.
> >> >>> > 'pgAdmin 4.app'
> >> >>> >
> >> >>> > - The DMG name should be created from
> >> >>> > to_lower(remove_spaces(APP_NAME-APP_VERSION)) in config.py, e.g.
> >> >>> > pgadmin4-1.0-dev.dmg
> >> >>> >
> >> >>> > - Use #ifdef Q_OS_MAC in the QT code for Mac-specific code.
> There's
> >> >>> > no
> >> >>> > need
> >> >>> > to define another macro.
> >> >>> >
> >> >>> > - Please add "MINIFY_HTML = False" to config_local.py (and have
> >> >>> > Paresh
> >> >>> > do
> >> >>> > the same on his packages). This works around a code issue with the
> >> >>> > docs
> >> >>> > that
> >> >>> > I'll log a bug for.
> >> >>> >
> >> >>> > - In testing, I found that running the app from within the DMG
> >> >>> > doesn't
> >> >>> > seem
> >> >>> > to work the first time - it prompts for the path, then exits.
> Once I
> >> >>> > save
> >> >>> > the path it offers, it's fine on subsequent runs.
> >> >>> >
> >> >>> > - Once copied to my laptop, I saw the same issue as above.
> >> >>> >
> >> >>> > Once these issues are resolved, I think we're good to commit.
> >> >>>
> >> >>> Oh, a couple more things:
> >> >>>
> >> >>> - There should not be a copy of the app bundle in dist/ following
> the
> >> >>> build. Only the dmg should be there.
> >> >>>
> >> >>> - I think mac-build/ should be removed following a successful build,
> >> >>> rather than waiting for make clean (please talk to Paresh - his code
> >> >>> should do the same).
> >> >>>
> >> >>> --
> >> >>> Dave Page
> >> >>> Blog: http://pgsnake.blogspot.com
> >> >>> Twitter: @pgsnake
> >> >>>
> >> >>> EnterpriseDB UK: http://www.enterprisedb.com
> >> >>> The Enterprise PostgreSQL Company
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Sandeep Thakkar
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Sandeep Thakkar
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
> >
> >
> > --
> > Sandeep Thakkar
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Sandeep Thakkar
view thread (26+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Patch for pgAdmin4 package on Mac OS X
In-Reply-To: <CANFyU94sG07rBdyGKTRstKS-JxYmA563JoFSQgu05TTBoj9kjQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox