Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9qeH-0004rU-Sm for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Jun 2016 09:16:42 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b9qeH-0004fA-9B for pgadmin-hackers@arkaria.postgresql.org; Mon, 06 Jun 2016 09:16:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b9qeG-0004f4-79 for pgadmin-hackers@postgresql.org; Mon, 06 Jun 2016 09:16:40 +0000 Received: from mail-qg0-x232.google.com ([2607:f8b0:400d:c04::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b9qeC-0001uA-Ek for pgadmin-hackers@postgresql.org; Mon, 06 Jun 2016 09:16:38 +0000 Received: by mail-qg0-x232.google.com with SMTP id q32so39090205qgq.3 for ; Mon, 06 Jun 2016 02:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=gJe8uaBJpaZeVvCRojFgcpRc4uLyDhkITVFAbxLC2Ek=; b=nIrRtjWCVY5tb6e9mhSrHIrQld0NglcRxdikXXNLkwUVirgOmk52W3iWGx0hLZ5DjI QtdgjCBM2XV1xqSrlK+48oYHNbFctpLq149gL3bVIeIKg5M7PuIFv5pwze7Qy/67lP9Y i8uxGIA6lmjENiztCPsPhhSTzRLwjxHF+3Om/+Is88FUA5ovPhD6KRoJsGGNq7xXDIcX KBvSGM/AfOgMPNiiCRknVzSYWCfmSKjSOfWJSJkKQUWUeQ1vtHeQLnPLBYFmCeOSp4yz BQjPFxJj1Mp0YMbK/2aAmf2CNfthp7i+XaRhioRyBJ3a6+NN6M54gFsmWTPR7bB68Yxd pfxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=gJe8uaBJpaZeVvCRojFgcpRc4uLyDhkITVFAbxLC2Ek=; b=a3OAXSFLCw1mDp+bs7fFsaEQjhaxZiTfYL1AWSii72sUcNOdAx/zs3+3CkKo0YBeVk YDTlYIzXbFJ40O3O7hi5+M0mOmkHzsqr0TfWwJoEavVkvOo4nRoGgl4qTnVVHlAo+vOj Cx9ptQ+rSVFo2ahvmEMi7ZkxF/ODy+T9idRG+oLDzQZlgOof3Lt/GI0zNziN7gPzQe22 P2hrDqJSd2ur8ypvAyqrXxclAiXaMaxBnmzs1KpV1qqWnCnhpJ5s5DB/LGtW6SwqRwF1 4qhpKqVincwZF0lu6uiXVePAofucvtlqgp9PFL3C+WbRxzFinnerznoorHPfHGGYYSAj BiHQ== X-Gm-Message-State: ALyK8tLLIrn87peIEvBlF7+xaFe4Wg4cw7U29fvLMGol/PtJw+fXDAhGsHzzWopbEBlh4cxs1D+IXqQSOQEIVW49 MIME-Version: 1.0 X-Received: by 10.140.91.244 with SMTP id z107mr2727009qgd.82.1465204595622; Mon, 06 Jun 2016 02:16:35 -0700 (PDT) Received: by 10.140.101.198 with HTTP; Mon, 6 Jun 2016 02:16:35 -0700 (PDT) In-Reply-To: References: Date: Mon, 6 Jun 2016 14:46:35 +0530 Message-ID: Subject: Re: Patch for pgAdmin4 RPM package From: Sandeep Thakkar To: Dave Page , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Cc: pgadmin-hackers , Hamid Quddus Content-Type: multipart/alternative; boundary=001a113a74d2721a1b05349887a1 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113a74d2721a1b05349887a1 Content-Type: text/plain; charset=UTF-8 --Adding back Devrim :-) On Mon, Jun 6, 2016 at 2:44 PM, Dave Page wrote: > Hmm, virtualenv's a good point. > > I wonder if for the RPMs (and DEBs) we're just trying too hard. Is there > any good reason to support SxS there? Stability I suppose, but then we > don't support back-branches long term anyway. > > Does anyone think we need to support side-by-side RPM/DEB installation of > multiple major versions of pgAdmin? Devrim? Hamid? > > The config file would be part of the web package. > > On Mon, Jun 6, 2016 at 10:09 AM, Sandeep Thakkar < > sandeep.thakkar@enterprisedb.com> wrote: > >> I already asked them about the APIs, though I didn't ask them about what >> is the best way to handle SxS installation. Will check with them. >> >> PIP package for pgadmin4 doesn't support SxS as it creates the directory >> with the name 'pgadmin4' only. Googling about the SxS with PIP says that >> people use virtualenv to achieve it. >> >> Regarding pgadmin4-v1.conf - will it be a part of pgadmin4-docs RPM? >> Needed for Debian also? >> >> On Mon, Jun 6, 2016 at 1:53 PM, Dave Page wrote: >> >>> I have no idea. I would ask one of the Python guru's sitting next to you >>> (as well as whether the way we'd handle side-by-side packages is >>> appropriate). Also, look at what the PIP package does (does that even work >>> properly in a SxS scenario? I don't know if we thought to check that). >>> >>> BTW; on the RPMs - we also need to include a config snippet for Apache, >>> e.g. /etc/httpd/conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a >>> section on configuring that. >>> >>> >>> >>> On Mon, Jun 6, 2016 at 9:15 AM, Sandeep Thakkar < >>> sandeep.thakkar@enterprisedb.com> wrote: >>> >>>> Yeah, I got the point. To distinguish between v1 and v2, we can have >>>> blank __init__.py in the v1 and v2 directories. I tried it and could >>>> successfully import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4" >>>> and "import pgadmin4_web_v2.pgAdmin4". Please note that I had to rename >>>> hyphen to underscore in the directories to achieve this. >>>> >>>> But, I spent enough time to find the API that can get me the location >>>> for "pgadmin4_web_v1.pgAdmin4" module, but couldn't find it. Do you have an >>>> idea? >>>> >>>> >>>> On Fri, Jun 3, 2016 at 8:24 PM, Dave Page wrote: >>>> >>>>> My point is that the runtime uses the platform supplied Python >>>>> interpreter, which presumably knows where to search for packages. Mind you, >>>>> I suppose the issue there is that it wouldn't be able to distinguish >>>>> between v1 and v2 then... >>>>> >>>>> I don't have a major issue with your suggested code - I just want to >>>>> make sure we need it. >>>>> >>>>> >>>>> On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar < >>>>> sandeep.thakkar@enterprisedb.com> wrote: >>>>> >>>>>> Do you mean to say when a python app is launched, it imports some >>>>>> modules automatically and in that sense it knows about where it's >>>>>> site-packages are? May be, but how the pgAdmin4 runtime will know where the >>>>>> Web App is installed? >>>>>> >>>>>> The changes that I have done to the runtime is to let it know the >>>>>> path of the Web App which is present in >>>>>> "/site-packages/pgadmin4-web-v1/pgAdmin4.py" The changes done are not to >>>>>> set the PythonPath like we did for appbundle because I thought it is not >>>>>> needed and it will automatically load the modules from the site-packages, >>>>>> but it is to set the ApplicationPath. >>>>>> >>>>>> I missed something? or misunderstood something? >>>>>> >>>>>> On Fri, Jun 3, 2016 at 7:39 PM, Dave Page wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> Well, I have to wonder why we need the changes to the runtime? We're >>>>>>> linking the runtime with the same build of Python that's already on the >>>>>>> system - doesn't it know where it's site-packages are already? I could see >>>>>>> us needing this is we were using a distro-independent build of Python and >>>>>>> wanted to find the OS site-packages location, but we're not. >>>>>>> >>>>>>> >>>>>>> On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar < >>>>>>> sandeep.thakkar@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi Dave, >>>>>>>> >>>>>>>> how about changes in the pgadmin4 source code for conf.py and >>>>>>>> Server.cpp? Looks okay? >>>>>>>> >>>>>>>> On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < >>>>>>>> sandeep.thakkar@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Thanks Dave. >>>>>>>>> >>>>>>>>> On Fri, Jun 3, 2016 at 2:08 PM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar >>>>>>>>>> wrote: >>>>>>>>>> > Hi Devrim, Hi Dave, >>>>>>>>>> > >>>>>>>>>> > I have updated the patch. The earlier patch may fail because of >>>>>>>>>> app bundle >>>>>>>>>> > commit in git. >>>>>>>>>> > >>>>>>>>>> > For testing, you may define the source tarball location as : >>>>>>>>>> > Source0: >>>>>>>>>> > >>>>>>>>>> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >>>>>>>>>> > >>>>>>>>>> > Known issue that I'm still working on: >>>>>>>>>> > 1. web rpm has a dependency on doc. But, even if I install doc, >>>>>>>>>> the web >>>>>>>>>> > still complains. Here is the scenario: >>>>>>>>>> > [root@localhost tmp]# rpm -ivh >>>>>>>>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>>>>>>>>> > error: Failed dependencies: >>>>>>>>>> > pgadmin4-doc = 1.0_dev is needed by >>>>>>>>>> pgadmin4-web-1.0_dev-1.rhel7.noarch >>>>>>>>>> > ... ( trimmed the python dependencies list here...) >>>>>>>>>> > >>>>>>>>>> > [root@localhost tmp]# rpm -ivh >>>>>>>>>> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm >>>>>>>>>> > Preparing... >>>>>>>>>> ################################# >>>>>>>>>> > [100%] >>>>>>>>>> > Updating / installing... >>>>>>>>>> > 1:pgadmin4-docs-1.0_dev-1.rhel7 >>>>>>>>>> ################################# >>>>>>>>>> > [100%] >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > [root@localhost tmp]# yum list | grep pgadmin4-docs >>>>>>>>>> > pgadmin4-docs.noarch 1.0_dev-1.rhel7 >>>>>>>>>> > installed >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> > [root@localhost tmp]# rpm -ivh >>>>>>>>>> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >>>>>>>>>> > error: Failed dependencies: >>>>>>>>>> > pgadmin4-doc = 1.0_dev is needed by >>>>>>>>>> pgadmin4-web-1.0_dev-1.rhel7.noarch >>>>>>>>>> >>>>>>>>>> You have a typo - the Requires line is for pgadmin4-doc, but the >>>>>>>>>> RPM >>>>>>>>>> is pgadmin4-docs. >>>>>>>>>> >>>>>>>>>> Oh, right. >>>>>>>>> >>>>>>>>> >>>>>>>>>> Other review comments: >>>>>>>>>> >>>>>>>>>> - We have multiple identical pgadmin4.spec.in's in the patch. We >>>>>>>>>> need >>>>>>>>>> to get that down to a single file. >>>>>>>>>> >>>>>>>>>> - In fact, why do we need a directory for each distro at all? As >>>>>>>>>> far >>>>>>>>>> as I can see, the only difference is the $DIST definition, which >>>>>>>>>> is >>>>>>>>>> surely something we can get programmatically very easily. It >>>>>>>>>> seems to >>>>>>>>>> me we could reduce this all to 3 files - Makefile, README and >>>>>>>>>> pgadmin4.spec.in >>>>>>>>>> >>>>>>>>>> Agree. I copied the structure from somewhere thinking this is >>>>>>>>> good to have more OS specific changes. >>>>>>>>> >>>>>>>>> >>>>>>>>>> - make rpm has a dependency on make prep. This has 2 issues as >>>>>>>>>> far as I can see: >>>>>>>>>> >>>>>>>>>> - It does a git pull, which is bad. If I'm making an RPM from >>>>>>>>>> within >>>>>>>>>> the source tree, I want it for the current source. The git pull >>>>>>>>>> only >>>>>>>>>> makes sense for external builds, i.e. in a much larger automated >>>>>>>>>> build >>>>>>>>>> system. >>>>>>>>>> >>>>>>>>>> - It goes and grabs the source code and patches from the FTP >>>>>>>>>> site. >>>>>>>>>> Again, this is not what I want for an "in-tree" build. I want to >>>>>>>>>> use >>>>>>>>>> the source code as I have it now. >>>>>>>>>> >>>>>>>>>> Okay. got it. Will remove downloading the tarballs and build the >>>>>>>>> cloned source. >>>>>>>>> >>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Sandeep Thakkar >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Sandeep Thakkar >>>>>>>> Lead Software Engineer >>>>>>>> >>>>>>>> >>>>>>>> Phone: +91.20.30589505 >>>>>>>> >>>>>>>> Website: www.enterprisedb.com >>>>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>>>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>>>>>>> >>>>>>>> This e-mail message (and any attachment) is intended for the use of >>>>>>>> the individual or entity to whom it is addressed. This message contains >>>>>>>> information from EnterpriseDB Corporation that may be privileged, >>>>>>>> confidential, or exempt from disclosure under applicable law. If you are >>>>>>>> not the intended recipient or authorized to receive this for the intended >>>>>>>> recipient, any use, dissemination, distribution, retention, archiving, or >>>>>>>> copying of this communication is strictly prohibited. If you have received >>>>>>>> this e-mail in error, please notify the sender immediately by reply e-mail >>>>>>>> and delete this message. >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sandeep Thakkar >>>>>> Lead Software Engineer >>>>>> >>>>>> >>>>>> Phone: +91.20.30589505 >>>>>> >>>>>> Website: www.enterprisedb.com >>>>>> EnterpriseDB Blog: http://blogs.enterprisedb.com/ >>>>>> Follow us on Twitter: http://www.twitter.com/enterprisedb >>>>>> >>>>>> This e-mail message (and any attachment) is intended for the use of >>>>>> the individual or entity to whom it is addressed. This message contains >>>>>> information from EnterpriseDB Corporation that may be privileged, >>>>>> confidential, or exempt from disclosure under applicable law. If you are >>>>>> not the intended recipient or authorized to receive this for the intended >>>>>> recipient, any use, dissemination, distribution, retention, archiving, or >>>>>> copying of this communication is strictly prohibited. If you have received >>>>>> this e-mail in error, please notify the sender immediately by reply e-mail >>>>>> and delete this message. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> >>>> -- >>>> Sandeep Thakkar >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Sandeep Thakkar >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sandeep Thakkar Lead Software Engineer Phone: +91.20.30589505 Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message. --001a113a74d2721a1b05349887a1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
--Adding back Devrim :-)


On Mon, Jun 6, 2016 at 2:44 PM, Dave= Page <dpage@pgadmin.org> wrote:
Hmm, virtualenv's a good point.

<= div>I wonder if for the RPMs (and DEBs) we're just trying too hard. Is = there any good reason to support SxS there? Stability I suppose, but then w= e don't support back-branches long term anyway.

Does anyone think we need to support side-by-side RPM/DEB installation of= multiple major versions of pgAdmin? Devrim? Hamid?

The config file would be part of the web package.

On Mon, Jun 6, 2016 at 10:09 AM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:
I already asked them about the APIs, tho= ugh I didn't ask them about what is the best way to handle SxS installa= tion. Will check with them.

PIP package for pgadmin4 doe= sn't support SxS as it creates the directory with the name 'pgadmin= 4' only. Googling about the SxS with PIP says that people use virtualen= v to achieve it.

Regarding pgadmin4-v1.conf - will= it be a part of pgadmin4-docs RPM? Needed for Debian also?

On Mon, Jun = 6, 2016 at 1:53 PM, Dave Page <dpage@pgadmin.org> wrote:
=
I have no idea. I would ask= one of the Python guru's sitting next to you (as well as whether the w= ay we'd handle side-by-side packages is appropriate). Also, look at wha= t the PIP package does (does that even work properly in a SxS scenario? I d= on't know if we thought to check that).

BTW; on the = RPMs - we also need to include a config snippet for Apache, e.g. /etc/httpd= /conf.d/pgadmin4-v1.conf. The online docs for pgAdmin have a section on con= figuring that.



On Mon, Jun 6, 2016 at= 9:15 AM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com= > wrote:
Y= eah, I got the point. To distinguish between v1 and v2, we can have blank _= _init__.py in the v1 and v2 directories. I tried it and could successfully = import the pgAdmin4 using "import pgadmin4_web_v1.pgAdmin4" and &= quot;import pgadmin4_web_v2.pgAdmin4".=C2=A0 Please note that I had to= rename hyphen to underscore in the directories to achieve this.=C2=A0
=
But, I spent enough time to find the API that can get me the locat= ion for "pgadmin4_web_v1.pgAdmin4" module, but couldn't find = it. Do you have an idea?


On Fri, Jun 3, 2016 at 8:24 PM,= Dave Page <dpage@pgadmin.org> wrote:
My point is that the runtime uses the platfo= rm supplied Python interpreter, which presumably knows where to search for = packages. Mind you, I suppose the issue there is that it wouldn't be ab= le to distinguish between v1 and v2 then...

I don't = have a major issue with your suggested code - I just want to make sure we n= eed it.


On Fri, Jun 3, 2016 at 3:39 PM, Sandeep Thakkar = <s= andeep.thakkar@enterprisedb.com> wrote:
Do you mean to say when a python app is laun= ched, it imports some modules automatically and in that sense it knows abou= t where it's site-packages are? May be, but how the pgAdmin4 runtime wi= ll know where the Web App is installed?=C2=A0

The change= s that I have done to the runtime is to let it know the path of the Web App= which is present in "/site-packages/pgadmin4-web-v1/pgAdmin4.py"= The changes done are not to set the PythonPath like we did for appbundle b= ecause I thought it is not needed and it will automatically load the module= s from the site-packages, but it is to set the ApplicationPath.
<= br>
I missed something? or misunderstood something?=C2=A0

On Fri, Jun 3, 2016 at 7:39 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi,

Well, I have to wonder why we need the changes to the runtime? We&= #39;re linking the runtime with the same build of Python that's already= on the system - doesn't it know where it's site-packages are alrea= dy? I could see us needing this is we were using a distro-independent build= of Python and wanted to find the OS site-packages location, but we're = not.


On Fri, Jun 3, 2016 at 10:15 AM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:
Hi Dave,=C2=A0

<= div>how about changes in the pgadmin4 source code for conf.py and Server.cp= p? Looks okay?

On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com> wrote:
Thanks Dave.=C2=A0

On Fri, Jun 3, 2016 = at 2:08 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
<s= andeep.thakkar@enterprisedb.com> wrote:
> Hi Devrim, Hi Dave,
>
> I have updated the patch. The earlier patch may fail because of app bu= ndle
> commit in git.
>
> For testing, you may define the source tarball location as :
> Source0:
> http://bu= gatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >
> Known issue that I'm still working on:
> 1. web rpm has a dependency on doc. But, even if I install doc, the we= b
> still complains. Here is the scenario:
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch
> ... ( trimmed the python dependencies list here...)
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> Preparing...=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #################################
> [100%]
> Updating / installing...
>=C2=A0 =C2=A0 1:pgadmin4-docs-1.0_dev-1.rhel7=C2=A0 =C2=A0 ############= #####################
> [100%]
>
>
> [root@localhost tmp]# yum list | grep pgadmin4-docs
> pgadmin4-docs.noarch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 1.0_dev-1.rhel7
> installed
>
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch

You have a typo - the Requires line is for pgadmin4-doc, but th= e RPM
is pgadmin4-docs.

Oh, right.
=C2=A0
Other review comments:

- We have multiple identical pgadmin4.spec.in's in the patch. We need=
to get that down to a single file.

- In fact, why do we need a directory for each distro at all? As far
as I can see, the only difference is the $DIST definition, which is
surely something we can get programmatically very easily. It seems to
me we could reduce this all to 3 files - Makefile, README and
pg= admin4.spec.in

Agree. I copied the structure from somewhere t= hinking this is good to have more OS specific changes.
=C2= =A0
- make rpm has a dependency on make prep. This has 2 issues as far as I can= see:

=C2=A0 - It does a git pull, which is bad. If I'm making an RPM from wi= thin
the source tree, I want it for the current source. The git pull only
makes sense for external builds, i.e. in a much larger automated build
system.

=C2=A0 - It goes and grabs the source code and patches from the FTP site. Again, this is not what I want for an "in-tree" build. I want to = use
the source code as I have it now.

Okay. got it. Will remov= e downloading the tarballs and build the cloned source.
=C2= =A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sandeep Thakkar




-= -
Sandeep Thakkar
Lead Software Engineer


Phone: +91.20.30589505

Website: www.enterprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: http://www.t= witter.com/enterprisedb

This e-mail message (and any attachment)= is intended for the use of the individual or entity to whom it is addresse= d. This message contains information from EnterpriseDB Corporation that may= be privileged, confidential, or exempt from disclosure under applicable la= w. If you are not the intended recipient or authorized to receive this for = the intended recipient, any use, dissemination, distribution, retention, ar= chiving, or copying of this communication is strictly prohibited. If you ha= ve received this e-mail in error, please notify the sender immediately by r= eply e-mail and delete this message.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



--
Sandeep = Thakkar
Lead Software Engineer
<= br>
Phone: +91.20.30589505

Website: www.enterprisedb.com
EnterpriseDB = Blog: http://b= logs.enterprisedb.com/
Follow us on Twitter: http://www.twitter.com/enterpris= edb

This e-mail message (and any attachment) is intended for the= use of the individual or entity to whom it is addressed. This message cont= ains information from EnterpriseDB Corporation that may be privileged, conf= idential, or exempt from disclosure under applicable law. If you are not th= e intended recipient or authorized to receive this for the intended recipie= nt, any use, dissemination, distribution, retention, archiving, or copying = of this communication is strictly prohibited. If you have received this e-m= ail in error, please notify the sender immediately by reply e-mail and dele= te this message.



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



<= font color=3D"#888888">--
Sandeep Thakkar




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



<= /div>--
Sandeep Thakkar




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @= pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL= Company



--
=
Sandeep Thakkar
Lead Software Engineer


Phone: +91.20.30589505
Website: www.ent= erprisedb.com
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us o= n Twitter: http://www.twitter.com/enterprisedb

This e-mail message (and a= ny attachment) is intended for the use of the individual or entity to whom = it is addressed. This message contains information from EnterpriseDB Corpor= ation that may be privileged, confidential, or exempt from disclosure under= applicable law. If you are not the intended recipient or authorized to rec= eive this for the intended recipient, any use, dissemination, distribution,= retention, archiving, or copying of this communication is strictly prohibi= ted. If you have received this e-mail in error, please notify the sender im= mediately by reply e-mail and delete this message.
<= /div>
--001a113a74d2721a1b05349887a1--