Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8lDA-0002p4-VZ for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 09:16:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b8lDA-00028o-IG for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Jun 2016 09:16:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b8lCx-0001uh-DN for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 09:15:59 +0000 Received: from mail-qk0-x230.google.com ([2607:f8b0:400d:c09::230]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b8lCt-0004rk-0T for pgadmin-hackers@postgresql.org; Fri, 03 Jun 2016 09:15:58 +0000 Received: by mail-qk0-x230.google.com with SMTP id s186so18905597qkc.1 for ; Fri, 03 Jun 2016 02:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=zRD5hWNoV0QTjMJylkjtZ6pCPVz/lLIembY9oDleXok=; b=jtDU9+xQHBy7grhtTvCShxGNfEcZfTd/Edly4+jk2hRmrvRURBM6XWDZyAuEvSTINR MeqqoZXBpdPKgT8C7+5VdOm0ZPa4OSgAlLNiGSuH25Qtl+A7YJHUpk00M8xBUoDWO9zZ w3V+y/xijBBFtAOHdLZvNuUt9av+eAXe04gziMQT7h8evL0RylsEcHrSm1Neez4JnGpg A34kDy8wfxgOYNxzPz956BOEmDIdyUYzJFPqaq9Bv4U2SumfRmO/3D5VM4rlCy8YSkwN 37qDCAOb6BpknHaz4qFvcqLPucdD2MPcuqdJqkUBUwBB9/y9jqdeGejfxzfVcJVRxPGo cCdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=zRD5hWNoV0QTjMJylkjtZ6pCPVz/lLIembY9oDleXok=; b=RJZT2GnjqHAbqK+zpQ+N8/cPImZoyXOCku0LWjg1KWs9eMV1MngQX1gfZqbnbhAo4k JPFUgGM2z8vJSuIsIhdW8QeJ2zoUizSDwlOpP5pmMHWEVIwOLexIREDAilr9crFvYsNt +rs7jAf15HaN8ceEn6+n/CCS9uZmqLh5mNzgAeUpQ5zDG4pb0teQWKO1p8JMwPOj9L2R genrcpoLklfHKbf6XxuH6T3ncLwkE6AzMZopaw1w53hLUits3gL7MH05xQ/Lhla7sbRf +A5hxXdhkQj04IG1oMjXZVr3Q7LduXN2JD5OS2yOD5AjkanTthrtVpMwB0RDRTB5PBcG ldqQ== X-Gm-Message-State: ALyK8tKCAvjQ6eJJmB3yD4C2YJufv7ebSgfvrqhwdadxO7E++cfPpTGx3QzzFUogjntjJHZE6xQbOXX3B7WlDDix MIME-Version: 1.0 X-Received: by 10.55.18.80 with SMTP id c77mr2100465qkh.199.1464945353108; Fri, 03 Jun 2016 02:15:53 -0700 (PDT) Received: by 10.140.101.198 with HTTP; Fri, 3 Jun 2016 02:15:53 -0700 (PDT) In-Reply-To: References: Date: Fri, 3 Jun 2016 14:45:53 +0530 Message-ID: Subject: Re: Patch for pgAdmin4 RPM package From: Sandeep Thakkar To: Dave Page Cc: pgadmin-hackers , Hamid Quddus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= Content-Type: multipart/alternative; boundary=001a113fe3ee63443305345c2ba1 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113fe3ee63443305345c2ba1 Content-Type: text/plain; charset=UTF-8 Hi Dave, how about changes in the pgadmin4 source code for conf.py and Server.cpp? Looks okay? On Fri, Jun 3, 2016 at 2:41 PM, Sandeep Thakkar < sandeep.thakkar@enterprisedb.com> wrote: > Thanks Dave. > > On Fri, Jun 3, 2016 at 2:08 PM, Dave Page wrote: > >> Hi >> >> On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar >> wrote: >> > Hi Devrim, Hi Dave, >> > >> > I have updated the patch. The earlier patch may fail because of app >> bundle >> > commit in git. >> > >> > For testing, you may define the source tarball location as : >> > Source0: >> > >> http://bugatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >> > >> > Known issue that I'm still working on: >> > 1. web rpm has a dependency on doc. But, even if I install doc, the web >> > still complains. Here is the scenario: >> > [root@localhost tmp]# rpm -ivh >> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >> > error: Failed dependencies: >> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch >> > ... ( trimmed the python dependencies list here...) >> > >> > [root@localhost tmp]# rpm -ivh >> > dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm >> > Preparing... ################################# >> > [100%] >> > Updating / installing... >> > 1:pgadmin4-docs-1.0_dev-1.rhel7 ################################# >> > [100%] >> > >> > >> > [root@localhost tmp]# yum list | grep pgadmin4-docs >> > pgadmin4-docs.noarch 1.0_dev-1.rhel7 >> > installed >> > >> > >> > [root@localhost tmp]# rpm -ivh >> > dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm >> > error: Failed dependencies: >> > pgadmin4-doc = 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noarch >> >> You have a typo - the Requires line is for pgadmin4-doc, but the RPM >> is pgadmin4-docs. >> >> Oh, right. > > >> Other review comments: >> >> - We have multiple identical pgadmin4.spec.in's in the patch. We need >> to get that down to a single file. >> >> - In fact, why do we need a directory for each distro at all? As far >> as I can see, the only difference is the $DIST definition, which is >> surely something we can get programmatically very easily. It seems to >> me we could reduce this all to 3 files - Makefile, README and >> pgadmin4.spec.in >> >> Agree. I copied the structure from somewhere thinking this is good to > have more OS specific changes. > > >> - make rpm has a dependency on make prep. This has 2 issues as far as I >> can see: >> >> - It does a git pull, which is bad. If I'm making an RPM from within >> the source tree, I want it for the current source. The git pull only >> makes sense for external builds, i.e. in a much larger automated build >> system. >> >> - It goes and grabs the source code and patches from the FTP site. >> Again, this is not what I want for an "in-tree" build. I want to use >> the source code as I have it now. >> >> Okay. got it. Will remove downloading the tarballs and build the cloned > source. > > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Sandeep Thakkar > > -- Sandeep Thakkar Lead Software Engineer Phone: +91.20.30589505 Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message. --001a113fe3ee63443305345c2ba1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,=C2=A0

how about changes in the= pgadmin4 source code for conf.py and Server.cpp? Looks okay?

On Fri, Jun 3, 2016= at 2:41 PM, Sandeep Thakkar <sandeep.thakkar@enterprisedb.= com> wrote:
Thanks Dave.=C2=A0

On Fri, Jun 3, 2016 at 2:08 PM, Dave Page <d= page@pgadmin.org> wrote:
Hi=

On Thu, Jun 2, 2016 at 4:23 PM, Sandeep Thakkar
<s= andeep.thakkar@enterprisedb.com> wrote:
> Hi Devrim, Hi Dave,
>
> I have updated the patch. The earlier patch may fail because of app bu= ndle
> commit in git.
>
> For testing, you may define the source tarball location as :
> Source0:
> http://bu= gatti.pn.in.enterprisedb.com/temp/pgadmin4/%{name}-v%{version}.tar.gz >
> Known issue that I'm still working on:
> 1. web rpm has a dependency on doc. But, even if I install doc, the we= b
> still complains. Here is the scenario:
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch
> ... ( trimmed the python dependencies list here...)
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-docs-1.0_dev-1.rhel7.noarch.rpm
> Preparing...=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #################################
> [100%]
> Updating / installing...
>=C2=A0 =C2=A0 1:pgadmin4-docs-1.0_dev-1.rhel7=C2=A0 =C2=A0 ############= #####################
> [100%]
>
>
> [root@localhost tmp]# yum list | grep pgadmin4-docs
> pgadmin4-docs.noarch=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 1.0_dev-1.rhel7
> installed
>
>
> [root@localhost tmp]# rpm -ivh
> dist/noarch/pgadmin4-web-1.0_dev-1.rhel7.noarch.rpm
> error: Failed dependencies:
> pgadmin4-doc =3D 1.0_dev is needed by pgadmin4-web-1.0_dev-1.rhel7.noa= rch

You have a typo - the Requires line is for pgadmin4-doc, but th= e RPM
is pgadmin4-docs.

Oh, right.
=C2= =A0
Other review comments:

- We have multiple identical pgadmin4.spec.in's in the patch. We need=
to get that down to a single file.

- In fact, why do we need a directory for each distro at all? As far
as I can see, the only difference is the $DIST definition, which is
surely something we can get programmatically very easily. It seems to
me we could reduce this all to 3 files - Makefile, README and
pg= admin4.spec.in

Agree. I copied the structure from somewhere t= hinking this is good to have more OS specific changes.
=C2=A0
- make rpm has a dependency on make prep. This has 2 issues as far as I can= see:

=C2=A0 - It does a git pull, which is bad. If I'm making an RPM from wi= thin
the source tree, I want it for the current source. The git pull only
makes sense for external builds, i.e. in a much larger automated build
system.

=C2=A0 - It goes and grabs the source code and patches from the FTP site. Again, this is not what I want for an "in-tree" build. I want to = use
the source code as I have it now.

Okay. got it. Will remov= e downloading the tarballs and build the cloned source.
=C2=A0
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sandeep Thakkar
=



--
Sandeep Thakkar
Lead Software Engineer


Phone: +91.20.30589505

Website: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">www.enterprisedb.c= om
EnterpriseDB Blog: http://blogs.enterprisedb.com/
Follow us on Twitter: = http://ww= w.twitter.com/enterprisedb

This e-mail message (and any attachme= nt) is intended for the use of the individual or entity to whom it is addre= ssed. This message contains information from EnterpriseDB Corporation that = may be privileged, confidential, or exempt from disclosure under applicable= law. If you are not the intended recipient or authorized to receive this f= or the intended recipient, any use, dissemination, distribution, retention,= archiving, or copying of this communication is strictly prohibited. If you= have received this e-mail in error, please notify the sender immediately b= y reply e-mail and delete this message.
--001a113fe3ee63443305345c2ba1--