Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grg5h-0003KO-U7 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 09:35:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1grg5f-0007Z3-8I for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Feb 2019 09:35:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grg5e-0007Yt-Ua for pgadmin-hackers@lists.postgresql.org; Thu, 07 Feb 2019 09:35:27 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grg5b-0002Oe-9u for pgadmin-hackers@postgresql.org; Thu, 07 Feb 2019 09:35:26 +0000 Received: by mail-pg1-x52b.google.com with SMTP id d72so4246718pga.9 for ; Thu, 07 Feb 2019 01:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IqQr5j9tDLC485om8mVtdRBV6ZmAQ10Vkwkz67RTJ5M=; b=fcs6Qcq5gMuqeDJCROip7eX9zJ/NZj93oZ+dkm60FF4d9b4d0liMmKl8DG4XqSHXyO 7WPPJSkvXIFd/WmBaYDpMFLUZtUaj9Yqji9uL+ynd02AR7pJdvnP4XeFnlaxDHS3LYWt BFRJanO6fKPRaz0t9o7Qsdh4PjNBJ/y4OGsf7gBaakOFA5gd7E9wAgZcdlNCn78ztKcO 6cGSIJhfZ0cIImvvaCxHSGoysp+2jU0ycY8pRmwgIeDgVwicPiMShkynzVxBQ2PBbR4K soMV4YwbZY/Ob+nBbMY7FYGnzyGwpZwWglLfAs2PY0Lu3K/3Vw+ad+pKkEoFgXrdOhxy 6DHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IqQr5j9tDLC485om8mVtdRBV6ZmAQ10Vkwkz67RTJ5M=; b=bO2f1ku7+ZMJZiVK1u4+gtSVzTS1jA0KSRKltxmwY5WjLFoV6s/SZCcADPuMUFVz9o BjVHUdWmGMiUc2LFLvV66+uMUmvID7EeBvn3x0UJ1yoypNXXLATCNxNZ+hiLTCQkXBK4 R2ZxLK7E8rtJKfu99vTr2htUxLqxwlAFXmGp44UIg7JX6bCHDYtKd6H/KtcOukrA5QHV x38B6gOdhy+Lf3TiBDdceaoyhwZgJkqiY98+u0f4S8XvCh0ZuRKLeJB50bwweykExMEv jbGjxp18QEkjqlyi3OvHcukv+QsYRqNJipVh0bW3DfgiF1jJp9goIv+v1HXXK8skX2VC dH6g== X-Gm-Message-State: AHQUAuZM6gGWhSx+ZwXLVaj/im7jb95WBlbfyL0rB0+pETIw7oo3J/0l w/P7g71NlapfYDc4xWptkk7m4iP3YitUE5oe0JNwkw== X-Google-Smtp-Source: AHgI3IYCI2EKb6c7kEcPpq+QWKabpXpwecEEX1x+0jkK95L6o8DXQX8O1vsxlKtdlOtF+lvA/Pa0lSoukSbPvjyIkHM= X-Received: by 2002:a63:2406:: with SMTP id k6mr13478549pgk.229.1549532119671; Thu, 07 Feb 2019 01:35:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Sandeep Thakkar Date: Thu, 7 Feb 2019 15:05:08 +0530 Message-ID: Subject: Re: Packagers: Handling upgrade checks To: Dave Page Cc: Srinu Perabattula , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008fc13c05814a8f61" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008fc13c05814a8f61 Content-Type: text/plain; charset="UTF-8" On Tue, Feb 5, 2019 at 7:06 PM Dave Page wrote: > Hi > > On Tue, Feb 5, 2019 at 12:27 PM Sandeep Thakkar > wrote: > > > > Hi Dave, > > > > > > On Wed, Jan 2, 2019 at 6:44 PM Dave Page wrote: > >> > >> Packagers, > >> > >> As you probably know, pgAdmin 4 checks for updates upon startup, and > >> if a newer version is available, directs the user to www.pgadmin.org > >> to download it. > >> > >> The is a problem if your pgAdmin came with a PostgreSQL installer (as > >> you can't download them from our website), and potentially mildly > >> annoying if you're a .deb or .rpm user. > >> > >> There are a couple of ways to optimise the experience for users here > >> (one of which I just committed). I'll leave it up to each of you to > >> choose what you want to do (Sandeep, I would suggest that the EDB > >> installers use method 2). > >> > >> Method 1: Simply disable the upgrade check, and leave that to the > >> operating systems update tools. To do this, create (or edit) a > >> config_distro.py file that is installed alongside the config.py file > >> from the pgAdmin source and include the line; > >> > >> UPGRADE_CHECK_ENABLED = False > >> > >> Method 2: For well known and trusted distributions we can support a > >> custom check for your distribution. This involves 2 parts: > >> > >> 1) Let me know that you want a custom check, and I'll setup access for > >> you to manage the version data on the pgAdmin website. We'll agree on > >> a custom key for that data within the JSON file the website hosts. > >> > > We want that for PG and EPAS installers. Will you please share the > custom key? > > edb-pgadmin4 > > See: https://www.pgadmin.org/versions.json (let me know if I need to > change anything for testing etc). > > Nice! Thank you. > >> > >> 2) Create (or edit) a config_distro.py file that is installed > >> alongside the config.py file from the pgAdmin source and include the > >> line; > >> > >> UPGRADE_CHECK_KEY = '' > >> > >> With this method, a different section of the JSON datafile will be > >> checked by your distribution of pgAdmin, thus allowing you to control > >> both when it tells users a new version is available, and the URL to > >> which they are directed. > >> > > Makes sense. Will include this change in the upcoming PG and EPAS > updates that bundle pgAdmin. > > :-) > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sandeep Thakkar --0000000000008fc13c05814a8f61 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Feb 5, 2019 at 7:06 PM Dave P= age <dpage@pgadmin.org> wrot= e:
Hi

On Tue, Feb 5, 2019 at 12:27 PM Sandeep Thakkar
<s= andeep.thakkar@enterprisedb.com> wrote:
>
> Hi Dave,
>
>
> On Wed, Jan 2, 2019 at 6:44 PM Dave Page <dpage@pgadmin.org> wrote:
>>
>> Packagers,
>>
>> As you probably know, pgAdmin 4 checks for updates upon startup, a= nd
>> if a newer version is available, directs the user to www.pgadmin.org<= /a>
>> to download it.
>>
>> The is a problem if your pgAdmin came with a PostgreSQL installer = (as
>> you can't download them from our website), and potentially mil= dly
>> annoying if you're a .deb or .rpm user.
>>
>> There are a couple of ways to optimise the experience for users he= re
>> (one of which I just committed). I'll leave it up to each of y= ou to
>> choose what you want to do (Sandeep, I would suggest that the EDB<= br> >> installers use method 2).
>>
>> Method 1: Simply disable the upgrade check, and leave that to the<= br> >> operating systems update tools. To do this, create (or edit) a
>> config_distro.py file that is installed alongside the config.py fi= le
>> from the pgAdmin source and include the line;
>>
>> UPGRADE_CHECK_ENABLED =3D False
>>
>> Method 2: For well known and trusted distributions we can support = a
>> custom check for your distribution. This involves 2 parts:
>>
>> 1) Let me know that you want a custom check, and I'll setup ac= cess for
>> you to manage the version data on the pgAdmin website. We'll a= gree on
>> a custom key for that data within the JSON file the website hosts.=
>>
> We want that for PG and EPAS installers. Will you please share the cus= tom key?

edb-pgadmin4

See: https://www.pgadmin.org/versions.json (let me know if = I need to
change anything for testing etc).

Nice! Thank you.
=C2=A0
>>
>> 2) Create (or edit) a config_distro.py file that is installed
>> alongside the config.py file from the pgAdmin source and include t= he
>> line;
>>
>> UPGRADE_CHECK_KEY =3D '<your key>'
>>
>> With this method, a different section of the JSON datafile will be=
>> checked by your distribution of pgAdmin, thus allowing you to cont= rol
>> both when it tells users a new version is available, and the URL t= o
>> which they are directed.
>>
> Makes sense. Will include this change in the upcoming PG and EPAS upda= tes that bundle pgAdmin.

:-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sandeep Thakkar

--0000000000008fc13c05814a8f61--