MIME-Version: 1.0
From: Andrew Coleman <penguincoder@gmail.com>
Date: Thu, 20 Jun 2019 12:31:40 -0400
Message-ID: 
 <CANNh3aUNwnmYAAzFLL_vt1JRy9TH_TNXRtEHpBVZ9wYVytSdaA@mail.gmail.com>
Subject: change to Docker entrypoint.sh
To: pgadmin-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000024af04058bc3e287"
Precedence: bulk

--00000000000024af04058bc3e287
Content-Type: text/plain; charset="UTF-8"

Hi All!

I am new to this, so I apologize beforehand if it's not entirely kosher,
but I have a proposed change to the Dockerfile entrypoint.sh to allow for
configurable servers.json filename path.

The reasoning behind this is that I have a Kubernetes deployment of pgadmin
where I build a ConfigMap sort of dynamically. I can make the file appear
in /pgadmin4, but it removes the contents of the directory for me
(helpful!). Instead, I put it into a separate directory and set a new
environment variable that defaults to the old pathname
(backwards-compatible!) but allows me to set a custom environment variable
in my custom Helm chart for my deployment.

The code is here:
https://github.com/penguincoder/pgadmin4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318

Is this something that anyone is interested in?
Does it meet your coding standards?
What do I do next?

I would love to move back to the "official" pgadmin container.

Thanks for your time,

Andrew

--00000000000024af04058bc3e287
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi All!</div><div><br></div><div>I am new to this, so=
 I apologize beforehand if it&#39;s not entirely kosher, but I have a propo=
sed change to the Dockerfile entrypoint.sh to allow for configurable server=
s.json filename path.</div><div><br></div><div>The reasoning behind this is=
 that I have a Kubernetes deployment of pgadmin where I build a ConfigMap s=
ort of dynamically. I can make the file appear in /pgadmin4, but it removes=
 the contents of the directory for me (helpful!). Instead, I put it into a =
separate directory and set a new environment variable that defaults to the =
old pathname (backwards-compatible!) but allows me to set a custom environm=
ent variable in my custom Helm chart for my deployment.</div><div><br></div=
><div>The code is here:</div><div><a href=3D"https://github.com/penguincode=
r/pgadmin4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318">https://github.=
com/penguincoder/pgadmin4/commit/0865400385ac0d03bf69d183e8cd9aaec6dcf318</=
a></div><div><br></div><div>Is this something that anyone is interested in?=
</div><div>Does it meet your coding standards?<br></div><div>What do I do n=
ext?</div><div><br></div><div>I would love to move back to the &quot;offici=
al&quot; pgadmin container.</div><div><br></div><div>Thanks for your time,<=
/div><div><br></div><div>Andrew<br></div></div>

--00000000000024af04058bc3e287--