Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tEBdi-005mUe-TP for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2024 18:10:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tEBdg-000Be2-QW for pgadmin-hackers@arkaria.postgresql.org; Thu, 21 Nov 2024 18:10:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tEBdg-000Bdu-JI for pgadmin-hackers@lists.postgresql.org; Thu, 21 Nov 2024 18:10:48 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tEBde-00396f-6U for pgadmin-hackers@postgresql.org; Thu, 21 Nov 2024 18:10:48 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2e56750bb0dso1030292a91.0 for ; Thu, 21 Nov 2024 10:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732212644; x=1732817444; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VQyN/Ldd6NyS4WjProKx0DoxQCqkHBQKgKkXivEXXaQ=; b=AzNc5oszTK/BJfHSgPcctoAtwd8l2tcioRBrTSK8JujP16EJJ9XfczVnbSwsrIxfxZ ouhKM950s0kOJuSYpoE73kUGqWAhsi/RHwFV3lxn9JlTJn07EGT4qDppr0Qg4WT4k8vx Hpou6YjmUy4EHgrffY6e6C7XWbqI3G8LIsn/aWRUAkLZ4Om/gKip8E1+NNlkXtJ3eTMh UPm9ZF3/95tbEEHZUcJB7merIyjUFjaDP/qIxvGGSXYrP8Eo+FFuw7X9y2YvG/xRMsNT YoijfQGul/Sf+iQsK1f+sifay77h8EDgeRwT65jhZyE91KtCUxnx4TKUrZ84BCUJD9/8 ZNRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732212644; x=1732817444; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VQyN/Ldd6NyS4WjProKx0DoxQCqkHBQKgKkXivEXXaQ=; b=IuFQzAIL2ZWRcL4FZlVMtDYxD9x8Rl4iNsH9LvzyIDg1CWhMfZq0dU6HTxA7LlNmuP gQPNrdAxbPJIQMiPeZbYrdskor6Lub9eKhPydNGrNy8iZvVaVB7TiVW+a5yZ68b+72ec t1m80/JfoFoaP0sq2pw5SKdxWubNb6VkxqIrCZX5voEnX21CmZVmVkuAEjBLA8CTXi+T DlNZm+wlwKAePJcE2g0X7WkX0RWDTFFKCIk754DocoZI5f3X9bR+vN/0390kQORBCq1X VZqUV7G91gCWlSFkEWvmWSY9fjtQM3jCBl+AH3ecRZOOswz3tRcLLpbeO/XKI9LqxyJI VbMw== X-Gm-Message-State: AOJu0Yy8Ou9ANV6vgnZCYcwH0fNl8cYyc49TMKUijlErQuAbTkKztPZb VRuhjU5J6dF/GVTpDmt5LCZtjXGj/EH01yqOs1yerv7aK1DvHiRORbD3zG9OBxNyM857aBFWgmL gbYEj1hTS2lncv2A72mj0wKbCdWM= X-Gm-Gg: ASbGncvGxGLr3ajHrlt/ogPXGXweiLlu0coVKfXV/SSIj9E5MGzh/9obb9ezBcyooA5 ZIe/6KNZxtJt6OvaNmLQI1O1ZQtkoPBp7 X-Google-Smtp-Source: AGHT+IH4RdW6iFhXrXYaltHktl5Hdyg5KmiSOnHF3LOrqqmJqz+4uxXBvCp1mzEZoCp8RDCDCaO+CJHmV47pGIIE+5g= X-Received: by 2002:a17:90b:1b47:b0:2ea:a9ac:eedd with SMTP id 98e67ed59e1d1-2eaca70a89fmr9388811a91.9.1732212644068; Thu, 21 Nov 2024 10:10:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Usman Khan Date: Thu, 21 Nov 2024 23:10:33 +0500 Message-ID: Subject: Re: Require suggestion for issue #6513 To: Rohit Bhati Cc: pgadmin-hackers@postgresql.org Content-Type: multipart/alternative; boundary="0000000000005345b10627702f48" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000005345b10627702f48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, I think it would be nice to do it across all appropriate places. 'Disconnect' is available for Server and Database, while Delete is available across all database objects in the tree area. On Thu, Nov 21, 2024 at 12:48=E2=80=AFPM Rohit Bhati wrote: > Hi Hackers, > > I have been working on issue #6513 > and have > implemented some changes based on user suggestions. Here=E2=80=99s a summ= ary of the > modifications I made locally: > > 1. *Button Label Changes*: > - Updated the labels of the buttons to "Delete" or "Disconnect" for > affirmative actions. > - Changed the label "No" to "Cancel" for negative actions. > 2. *Icon Additions*: > - Added appropriate icons for the "Disconnect" and "Delete" actions= . > > I would like your input on whether these changes should be applied > universally across all delete and disconnect scenarios, or if they should > be limited to just the database delete and disconnect actions. > > Please find the attached screenshots showcasing the changes. > > > Thank you for your feedback! > > Best regards, > Rohit Bhati > > > --0000000000005345b10627702f48 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, I think it would be nice to do it across all app= ropriate places.
'Disconnect' is available for Serve= r and Database, while Delete is available across all database objects in th= e tree area.





On Thu, Nov 21, 2024 at 12:48=E2=80=AFPM Rohit B= hati <= rohit.bhati@enterprisedb.com> wrote:

Hi Hackers,

I have been working on issue #6513 and have implemented some changes based on user suggestions. Her= e=E2=80=99s a summary of the modifications I made locally:

  1. Button Lab= el Changes:
    • Updated the labels of the buttons to "Delet= e" or "Disconnect" for affirmative actions.
    • Changed the label "No" to "Cancel= " for negative actions.
  2. Icon Addit= ions:
    • Added appropriate icons for the "Disconnect= " and "Delete" actions.

I would l= ike your input on whether these changes should be applied universally acros= s all delete and disconnect scenarios, or if they should be limited to just= the database delete and disconnect actions.

Please find the attached screensh= ots showcasing the changes.


Thank you for your feedback!

Best regards,
Rohit Bhati

=C2=A0

--0000000000005345b10627702f48--