public inbox for [email protected]  

help / color / mirror / Atom feed

From: Usman Khan <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: Yogesh Mahajan <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: Require sugeestion for #1235
Date: Fri, 7 Feb 2025 11:42:53 +0500
Message-ID: <CANVC+RGs9oyL8uc0nM87CWk7xQ=i0n3e3_LCtxzSu08X2=jW_w@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_=z8+MqWF28OJeRTX0fGHcynDJB9tUZANXRoAm9Qmnm6A@mail.gmail.com>
References: <CAMa=N=MgC_2WACG-9D6s7LQUbKSRFY8_9MheCJCqud2Hnbdy9A@mail.gmail.com>
	<CAMa=N=PKMsR-fWSMtsUrQ6jyFP4BWOboSN1e=u_k3eCGq9KCcA@mail.gmail.com>
	<CAM9w-_=z8+MqWF28OJeRTX0fGHcynDJB9tUZANXRoAm9Qmnm6A@mail.gmail.com>

Hi Yogesh,

I am in favour of the third option you pointed out above but in that case I
suggest changing the icon accordingly as the current icon usually gives
clue about 'file-opening' operation.

Thanks

On Fri, Feb 7, 2025 at 11:31 AM Aditya Toshniwal <
[email protected]> wrote:

> Hi Yogesh,
>
> I am in favor of the "Combine all file operations menu in single dropdown"
> solution. It is more in-line with menus of other editors and is more
> intuitive.
>
> On Fri, Feb 7, 2025 at 11:27 AM Yogesh Mahajan <
> [email protected]> wrote:
>
>> Hi,
>>
>> Could you please provide your feedback/suggestions?
>>
>> Thanks,
>> Yogesh Mahajan
>> EnterpriseDB
>>
>>
>> On Thu, Jan 30, 2025 at 4:03 PM Yogesh Mahajan <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> For issue #1235 <https://github.com/pgadmin-org/pgadmin4/issues/1235; - Query
>>> Tool - Open file should open file in a new tab, here are two the options to
>>> set preference for opening file.
>>> 1.Provide split button beside Open file button -
>>> [image: Screenshot 2025-01-24 at 9.02.27 PM.png]
>>> Pros -
>>> a.Provides an easy way to set up the preference.
>>> Cons -
>>> a.One more addition of icon.
>>>
>>>
>>> 2.Provide option with save button dropdown -
>>> [image: Screenshot 2025-01-30 at 2.51.10 PM.png]
>>> Pros -
>>> a.No need to add a split button for the open icon.
>>> Cons -
>>> a.Open operation is listed under save options.
>>>
>>>
>>> 3.Combine all file operations menu in single dropdown -
>>> [image: Screenshot 2025-01-30 at 4.00.29 PM.png]
>>>
>>> Pros -
>>> a.All file related options are clubbed together like most of the editors.
>>> b.Allows to add more file operations with the same dropdown.(Like Open
>>> recent - however this is out of scope of this issue.)
>>> Cons -
>>> c.Can't think of any.
>>>
>>> Could you please share your suggestions?
>>>
>>> Thanks,
>>> Yogesh Mahajan
>>> EnterpriseDB
>>>
>>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Staff SDE II | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>


Attachments:

  [image/png] Screenshot 2025-01-24 at 9.02.27 PM.png (149.3K, 3-Screenshot%202025-01-24%20at%209.02.27%E2%80%AFPM.png)
  download | view image

  [image/png] Screenshot 2025-01-30 at 2.51.10 PM.png (162.3K, 4-Screenshot%202025-01-30%20at%202.51.10%E2%80%AFPM.png)
  download | view image

  [image/png] Screenshot 2025-01-30 at 4.00.29 PM.png (133.8K, 5-Screenshot%202025-01-30%20at%204.00.29%E2%80%AFPM.png)
  download | view image

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Require sugeestion for #1235
  In-Reply-To: <CANVC+RGs9oyL8uc0nM87CWk7xQ=i0n3e3_LCtxzSu08X2=jW_w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox