Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aH5IV-0004bj-4A for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jan 2016 07:47:51 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aH5IU-0003TW-N4 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jan 2016 07:47:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aH5IT-0003TA-RJ for pgadmin-hackers@postgresql.org; Thu, 07 Jan 2016 07:47:49 +0000 Received: from mail-io0-x233.google.com ([2607:f8b0:4001:c06::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aH5IK-0004ob-Ga for pgadmin-hackers@postgresql.org; Thu, 07 Jan 2016 07:47:48 +0000 Received: by mail-io0-x233.google.com with SMTP id g73so45863835ioe.3 for ; Wed, 06 Jan 2016 23:47:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=7SVLCEtSrY1FzTlC+BL88wSrvbgzTtxf8k5jgCpZ61k=; b=ahIBrM7PcEx5qJEmFSH7SJIYj/kfCvOlrX/2cZCkH0OaH1jycgPQ3+xhBfsJ5AC+HD krmifuyimf00mwGx5MF0Emtw9L2HiqAVLde3Po/H0Wtu6btltUkDy3F/PiiWYROoclxN ME3H55IJL4B1ju3vWemMbzvwOyG6LoMm1FSwl5StP61bDofz37JtVP1S4xfdA6tSuAJ4 Jqur9npoaC6LNqHaCKIImO3oHHJGYksjyqk7YMDDYBaKs876zHLAKLkxdZzhWB8iiZI8 BlYMepSTMuzGNrOWtemT/b3k/AaWwdXBfXmD7ygri98gcKC7oBIjQfM0Rk3KQT3rcD0b 5h1Q== MIME-Version: 1.0 X-Received: by 10.107.18.71 with SMTP id a68mr106853682ioj.107.1452152858523; Wed, 06 Jan 2016 23:47:38 -0800 (PST) Received: by 10.79.82.131 with HTTP; Wed, 6 Jan 2016 23:47:38 -0800 (PST) Reply-To: bjorn@wololo.org In-Reply-To: References: Date: Thu, 7 Jan 2016 08:47:38 +0100 Message-ID: Subject: Re: ]GTK 3 From: =?UTF-8?Q?Bj=C3=B6rn_Harrtell?= To: Dave Page Cc: Guillaume Lelarge , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113ed6c64abdb70528b9afcc X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113ed6c64abdb70528b9afcc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Yes, sorry, I made both the comments and the patch too hastily and agree that it should not be removed based on my findings. It should be noted though that wx3 or GTK3 by themselves is not to blame here, I'm guessing it should affect wx2 and GTK2 too because it's more of a logical problem in where a user created the server node in a light theme which will save a white color for the background... then if the user switches to a dark theme, the saved white color is problematic. I noticed work on pgadmin4 too and while interesting, I want to see pgadmin3 shine on linux desktops in the life it has left which might be quite some time (?). I see several distinct areas of work that I'd like to contribute efforts with: 1. Upgrade to latest stable wx 2. Compile with GTK+ 3.x as default on Linux (not sure it's ready for this, needs research and collaboration with dist packaging) 3. Evaluate which controls that can/need replacement (i.e replace with wxTreeListCtrl, wxDataViewCtrl and perhaps wxToolBar) 4. Refactor existing code to use the controls that pass evaulation Feedback and guidance on how to proceed is much appreciated! /Bj=C3=B6rn 2016-01-06 10:48 GMT+01:00 Dave Page : > On Wed, Jan 6, 2016 at 8:54 AM, Guillaume Lelarge > wrote: > > 2016-01-05 23:54 GMT+01:00 Bj=C3=B6rn Harrtell : > >> > >> Found the theme color issue. > >> > >> Server node color is customizable and new server nodes are created wit= h > >> background from window and saved in .pgadmin3. > >> > >> I don't see the usefulness of this feature so I've attached patch that > >> removes it. > >> > > > > -1 > > > > I didn't see either when it was commited, but I know many users who are > > really fond of the feature. It helps them track which kind of servers > > they're connected to (production, testing, dev, etc). > > Right - we're not removing functionality because it doesn't work > properly (yet) in wx3. FYI, I wrote and committed that feature at > PGCon one year. > > >> I see there is alot of work to be done to modernize the usage of > wxWidgets > >> to take advantage of new widgets for trees, lists and toolbar and > perhaps > >> even the grid. Any interest in contributions towards this? > >> > > > > I would say yes, but be aware that the next major release of pgAdmin (a= s > in > > pgAdmin IV) won't use wxwidgets. > > Correct. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113ed6c64abdb70528b9afcc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Yes, sorry, I made both the comments and the patch to= o hastily and agree that it should not be removed based on my findings.

It should be noted though that wx3 or GTK3 by themsel= ves is not to blame here, I'm guessing it should affect wx2 and GTK2 to= o because it's more of a logical problem in where a user created the se= rver node in a light theme which will save a white color for the background= ... then if the user switches to a dark theme, the saved white color is pro= blematic.

I noticed work on pgadmin4 too and w= hile interesting, I want to see pgadmin3 shine on linux desktops in the lif= e it has left which might be quite some time (?). I see several distinct ar= eas of work that I'd like to contribute efforts with:

1. Upgrade to latest stable wx
2. Compile with GTK+ 3.x a= s default on Linux (not sure it's ready for this, needs research and co= llaboration with dist packaging)
3. Evaluate which controls that = can/need replacement (i.e replace with wxTreeListCtrl,=C2=A0wxDataViewCtrl = and perhaps wxToolBar)
4. Refactor existing code to use the contr= ols that pass evaulation

Feedback and guidance on = how to proceed is much appreciated!

/Bj=C3=B6rn

201= 6-01-06 10:48 GMT+01:00 Dave Page <dpage@pgadmin.org>:
On Wed, Jan 6, 2016 at 8:54 AM, Guillaume L= elarge
<guillaume@lelarge.info>= ; wrote:
> 2016-01-05 23:54 GMT+01:00 Bj=C3=B6rn Harrtell <bjorn.harrtell@gmail.com>:
>>
>> Found the theme color issue.
>>
>> Server node color is customizable and new server nodes are created= with
>> background from window and saved in .pgadmin3.
>>
>> I don't see the usefulness of this feature so I've attache= d patch that
>> removes it.
>>
>
> -1
>
> I didn't see either when it was commited, but I know many users wh= o are
> really fond of the feature. It helps them track which kind of servers<= br> > they're connected to (production, testing, dev, etc).

Right - we're not removing functionality because it doesn't = work
properly (yet) in wx3. FYI, I wrote and committed that feature at
PGCon one year.

>> I see there is alot of work to be done to modernize the usage of w= xWidgets
>> to take advantage of new widgets for trees, lists and toolbar and = perhaps
>> even the grid. Any interest in contributions towards this?
>>
>
> I would say yes, but be aware that the next major release of pgAdmin (= as in
> pgAdmin IV) won't use wxwidgets.

Correct.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a113ed6c64abdb70528b9afcc--