Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aH9Bf-00069E-Le for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jan 2016 11:57:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aH9Bf-00022M-8O for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jan 2016 11:57:03 +0000 Received: from magus.postgresql.org ([87.238.57.229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aH9BR-0001ng-Fw for pgadmin-hackers@postgresql.org; Thu, 07 Jan 2016 11:56:49 +0000 Received: from mail-ig0-x22f.google.com ([2607:f8b0:4001:c05::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aH9BI-0002UP-Mb for pgadmin-hackers@postgresql.org; Thu, 07 Jan 2016 11:56:48 +0000 Received: by mail-ig0-x22f.google.com with SMTP id z14so32195240igp.1 for ; Thu, 07 Jan 2016 03:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=qbgOLhxsVaBduB44D6pPZ3xlzINvsFrzZ15o0GG1xgE=; b=iwORQWgqrIccYdViXCt0pa49zJapYtD5T3Su0zU7nLyshY+88/9N12PxG+5bWNjobs 877plVSEF6u2gJzLIPXy892W5FlmLOZ8zd2/l0MMzRzBS+4DZhNA8WFVp98YITBYrggr SLCtDsHfynMocz4mjAa3V/qle+hsPbzkaezHvncD/rBzKT1cAk+TZ+VBTIfBspgTv+Sg O170kl9j7thMDefOX288fKZKT9GVCubR+3GDAbQueRo6crBzaH53LpHi5M4F2ZaSi3Gb nUl4FVdDIU4ZOc3bVamQJ+/75tihrWq/3hA+nN9UVfsgfczJH11dh9uWMZqTSHzyNBk1 G9EQ== MIME-Version: 1.0 X-Received: by 10.50.61.132 with SMTP id p4mr15238675igr.55.1452167798786; Thu, 07 Jan 2016 03:56:38 -0800 (PST) Received: by 10.79.82.131 with HTTP; Thu, 7 Jan 2016 03:56:38 -0800 (PST) Reply-To: bjorn@wololo.org In-Reply-To: References: Date: Thu, 7 Jan 2016 12:56:38 +0100 Message-ID: Subject: Re: ]GTK 3 From: =?UTF-8?Q?Bj=C3=B6rn_Harrtell?= To: Dave Page Cc: Guillaume Lelarge , pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bdc15eacd13870528bd29f2 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bdc15eacd13870528bd29f2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2016-01-07 12:10 GMT+01:00 Dave Page : > On Thu, Jan 7, 2016 at 7:47 AM, Bj=C3=B6rn Harrtell > wrote: > > Yes, sorry, I made both the comments and the patch too hastily and agre= e > > that it should not be removed based on my findings. > > > > It should be noted though that wx3 or GTK3 by themselves is not to blam= e > > here, I'm guessing it should affect wx2 and GTK2 too because it's more > of a > > logical problem in where a user created the server node in a light them= e > > which will save a white color for the background... then if the user > > switches to a dark theme, the saved white color is problematic. > > Well the same applies in a more default theme if you use a dark > background. I guess the answer is to say "don't do that then" - I'd > certainly prefer not to have pgAdmin try to second guess what colours > might work against whatever the theme has for the current text colour. > Agreed. But what about saving the color only when making an active choice so that the current system window background color is used until the user have customized the color? > > > I noticed work on pgadmin4 too and while interesting, I want to see > pgadmin3 > > shine on linux desktops in the life it has left which might be quite so= me > > time (?). I see several distinct areas of work that I'd like to > contribute > > efforts with: > > > > 1. Upgrade to latest stable wx > > That should be largely done, at least as far as compilation/linking is > concerned. As far as I know the only outstanding issue is with > resource generation when creating a Mac package. > Great. Just upgrading will be beneficial. Looking forward especially to get an updated wxStyledTextCtrl for the query editor. Unfortunately I cannot help with Mac-issues. > > > 2. Compile with GTK+ 3.x as default on Linux (not sure it's ready for > this, > > needs research and collaboration with dist packaging) > > OK. > > > 3. Evaluate which controls that can/need replacement (i.e replace with > > wxTreeListCtrl, wxDataViewCtrl and perhaps wxToolBar) > > I think we'd want compelling reasons to use different controls with > wx3 - and they'd need to be compelling enough to warrant additional > code complexity that would be added to continue to support wx2. Agreed. If the changes required are very large and/or invasive it is probably not worth it, that's what I'm planning to look into. The main benefit as I see it is that the new controls are backed by native controls for the GTK and Mac versions of wx. > > > 4. Refactor existing code to use the controls that pass evaulation > > > > Feedback and guidance on how to proceed is much appreciated! > > Propose changes here, and justify why they're needed essentially. If > consensus is that a change is warranted, then work can start on a > patch. > > Please do bear in mind though that I have something like 10 people > working almost exclusively on pgAdmin 4 right now, pushing us to an > alpha state by the end of Q1 - and whilst I expect pgAdmin 3 to be > around for a while yet, my, and my teams focus will be primarily on > that work. > Understandable. I look forward to be able to try out that alpha, and to hopefully contribute to that project instead in the future. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --047d7bdc15eacd13870528bd29f2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016= -01-07 12:10 GMT+01:00 Dave Page <dpage@pgadmin.org>:
On Thu, Jan 7, 2016 at 7:47 AM, Bj=C3=B6rn H= arrtell <bjorn.harrtell@gmai= l.com> wrote:
> Yes, sorry, I made both the comments and the patch too hastily and agr= ee
> that it should not be removed based on my findings.
>
> It should be noted though that wx3 or GTK3 by themselves is not to bla= me
> here, I'm guessing it should affect wx2 and GTK2 too because it= 9;s more of a
> logical problem in where a user created the server node in a light the= me
> which will save a white color for the background... then if the user > switches to a dark theme, the saved white color is problematic.

Well the same applies in a more default theme if you use a dark
background. I guess the answer is to say "don't do that then"= - I'd
certainly prefer not to have pgAdmin try to second guess what colours
might work against whatever the theme has for the current text colour.
<= /blockquote>

Agreed. But what about saving the color onl= y when making an active choice so that the current system window background= color is used until the user have customized the color?

> I noticed work on pgadmin4 too and while interesting, I want to see pg= admin3
> shine on linux desktops in the life it has left which might be quite s= ome
> time (?). I see several distinct areas of work that I'd like to co= ntribute
> efforts with:
>
> 1. Upgrade to latest stable wx

That should be largely done, at least as far as compilation/linking = is
concerned. As far as I know the only outstanding issue is with
resource generation when creating a Mac package.

<= /div>
Great. Just upgrading will be beneficial. Looking forward especia= lly to get an updated wxStyledTextCtrl for the query editor. Unfortunately = I cannot help with Mac-issues.
=C2=A0

> 2. Compile with GTK+ 3.x as default on Linux (not sure it's ready = for this,
> needs research and collaboration with dist packaging)

OK.

> 3. Evaluate which controls that can/need replacement (i.e replace with=
> wxTreeListCtrl, wxDataViewCtrl and perhaps wxToolBar)

I think we'd want compelling reasons to use different controls w= ith
wx3 - and they'd need to be compelling enough to warrant additional
code complexity that would be added to continue to support wx2.

Agreed. If the changes required are very large and/or = invasive it is probably not worth it, that's what I'm planning to l= ook into. The main benefit as I see it is that the new controls are backed = by native controls for the GTK and Mac versions of wx.
=C2=A0

> 4. Refactor existing code to use the controls that pass evaulation
>
> Feedback and guidance on how to proceed is much appreciated!

Propose changes here, and justify why they're needed essentially= . If
consensus is that a change is warranted, then work can start on a
patch.

Please do bear in mind though that I have something like 10 people
working almost exclusively on pgAdmin 4 right now, pushing us to an
alpha state by the end of Q1 - and whilst I expect pgAdmin 3 to be
around for a while yet, my, and my teams focus will be primarily on
that work.

Understandable. I look forwa= rd to be able to try out that alpha, and to hopefully contribute to that pr= oject instead in the future.
=C2=A0

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--047d7bdc15eacd13870528bd29f2--