Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1aK4BT-0005rE-0u for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jan 2016 13:12:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1aK4BR-0007AY-KL for pgadmin-hackers@arkaria.postgresql.org; Fri, 15 Jan 2016 13:12:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1aK4BD-0006vg-LO for pgadmin-hackers@postgresql.org; Fri, 15 Jan 2016 13:12:39 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1aK4B5-0001zL-Ix for pgadmin-hackers@postgresql.org; Fri, 15 Jan 2016 13:12:39 +0000 Received: by mail-io0-x22d.google.com with SMTP id g73so292031106ioe.3 for ; Fri, 15 Jan 2016 05:12:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=3ywA4AM/cKYfEDBTcOhyc7xyOK9XLCUtL2/1m8tlHjs=; b=inMnokgl/iNPi/sCZj9NZfbxKbc51lDRzYBuO3tcZ0ccR7A8tQDtperWFEM4GnjCYQ sQ1so4RGj0QJ8mq1bSw1s+r1jRHw80xfurkM3zyW/z8xJScACbSHTFqExQn89zsjenXG jLU9JypipYxZPfJpfegHSKPBN08XBZpg5qVVgpmNKVkscn9j06K6uYLzZxGe1oY8U6Ar 8cPnC1RHkpy8GqcKJ6+kvxUBZJiPEIm5WqGyVhDeocJQHSVqWpqC45FaKIGmfw6RlDbp GNbyOOxYcjeRgOev1wV0jIkaq4Fyd3SXSLwfary2yL30y0JOSDZHoaJwZZj1vlWEviFi vs0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=3ywA4AM/cKYfEDBTcOhyc7xyOK9XLCUtL2/1m8tlHjs=; b=RREeJzUk+aTL5a5GMqsc6RGSVvT0uglxhWHx/Or/QfEBwgK1fzhhSHRhnXt6WBZc0N aNPnp6Ou6f0sj+Co9ifyQi9tKeM4YilEurdYGTmaiQmiO5By/sHH8l0ZBR4ff468U8Q6 +UG5NTfBhQWrADZ9+yvM910Dru0gMAVnkECcmEBcR3kTQbx3Y0YxVk8ennpYZWOLMXFB m2rg1pngSVJTdoxcVuF9nqXRgoB5CnfZSSHoNKG3Lvrtre2dZVIflamQRYqyTHlycefb RAIFrSSrL6i6YhWZ8dciaRYjKlG3+wl7UYT+YVsU4OuQZQYCP6LUGt7UiKTcS8pdpqML bmFg== X-Gm-Message-State: ALoCoQn3qtGkcP8JAbOcRVw8FZ06kn4blxB/3FjYTam6Bxrn8l0+ajpuo9NIVzaXTzsY0Smh3sOC1mmXkZI75WLYypySQmHI2w== MIME-Version: 1.0 X-Received: by 10.107.7.212 with SMTP id g81mr10026909ioi.81.1452863549282; Fri, 15 Jan 2016 05:12:29 -0800 (PST) Received: by 10.79.82.4 with HTTP; Fri, 15 Jan 2016 05:12:29 -0800 (PST) Reply-To: bjorn@wololo.org In-Reply-To: References: Date: Fri, 15 Jan 2016 14:12:29 +0100 Message-ID: Subject: Re: ]GTK 3 From: =?UTF-8?Q?Bj=C3=B6rn_Harrtell?= To: Dave Page Cc: Guillaume Lelarge , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f8c3ec31dbb05295f2763 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f8c3ec31dbb05295f2763 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable 2016-01-07 12:58 GMT+01:00 Dave Page : > On Thu, Jan 7, 2016 at 11:56 AM, Bj=C3=B6rn Harrtell > wrote: > > 2016-01-07 12:10 GMT+01:00 Dave Page : > >> > >> On Thu, Jan 7, 2016 at 7:47 AM, Bj=C3=B6rn Harrtell < > bjorn.harrtell@gmail.com> > >> wrote: > >> > Yes, sorry, I made both the comments and the patch too hastily and > agree > >> > that it should not be removed based on my findings. > >> > > >> > It should be noted though that wx3 or GTK3 by themselves is not to > blame > >> > here, I'm guessing it should affect wx2 and GTK2 too because it's mo= re > >> > of a > >> > logical problem in where a user created the server node in a light > theme > >> > which will save a white color for the background... then if the user > >> > switches to a dark theme, the saved white color is problematic. > >> > >> Well the same applies in a more default theme if you use a dark > >> background. I guess the answer is to say "don't do that then" - I'd > >> certainly prefer not to have pgAdmin try to second guess what colours > >> might work against whatever the theme has for the current text colour. > > > > > > Agreed. But what about saving the color only when making an active > choice so > > that the current system window background color is used until the user > have > > customized the color? > > That seems perfectly reasonable. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > To follow up, it seems it will be quite a long road before mainstream distributions can use wx3 with GTK3. Longer explanation available here: http://lists.alioth.debian.org/pipermail/freewx-maint/2016-January/001751.h= tml So it seems in short term the only thing worth doing is upgrading to wx3, built against GTK2 as usual for the Linux build. Please let me know if there is anything I can do to make that happen. /Bj=C3=B6rn --001a113f8c3ec31dbb05295f2763 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
2016= -01-07 12:58 GMT+01:00 Dave Page <dpage@pgadmin.org>:
On Thu, Jan 7, 2016 at 11:56 AM, Bj=C3=B6rn Harrtell
<bjorn.harr= tell@gmail.com> wrote:
> 2016-01-07 12:10 GMT+01:00 Dave Page <dpage@pgadmin.org>:
>>
>> On Thu, Jan 7, 2016 at 7:47 AM, Bj=C3=B6rn Harrtell <bjorn.harrtell@gmail.com>
>> wrote:
>> > Yes, sorry, I made both the comments and the patch too hastil= y and agree
>> > that it should not be removed based on my findings.
>> >
>> > It should be noted though that wx3 or GTK3 by themselves is n= ot to blame
>> > here, I'm guessing it should affect wx2 and GTK2 too beca= use it's more
>> > of a
>> > logical problem in where a user created the server node in a = light theme
>> > which will save a white color for the background... then if t= he user
>> > switches to a dark theme, the saved white color is problemati= c.
>>
>> Well the same applies in a more default theme if you use a dark >> background. I guess the answer is to say "don't do that t= hen" - I'd
>> certainly prefer not to have pgAdmin try to second guess what colo= urs
>> might work against whatever the theme has for the current text col= our.
>
>
> Agreed. But what about saving the color only when making an active cho= ice so
> that the current system window background color is used until the user= have
> customized the color?

That seems perfectly reasonable.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

<= div class=3D"gmail_extra">To follow up, it seems it will be quite a long ro= ad before mainstream distributions can use wx3 with GTK3. Longer explanatio= n available here:
http://li= sts.alioth.debian.org/pipermail/freewx-maint/2016-January/001751.html

So it s= eems in short term the only thing worth doing is upgrading to wx3, built ag= ainst GTK2 as usual for the Linux build. Please let me know if there is any= thing I can do to make that happen.

/Bj=C3=B6rn
--001a113f8c3ec31dbb05295f2763--