Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1kJcLk-0005wD-Qo
	for pgadmin-hackers@arkaria.postgresql.org; Sat, 19 Sep 2020 12:52:20 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgadmin-hackers-owner+archive@lists.postgresql.org>)
	id 1kJcLj-0004tO-K0
	for pgadmin-hackers@arkaria.postgresql.org; Sat, 19 Sep 2020 12:52:19 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <jv.cyril@gmail.com>)
	id 1kJcLj-0004tB-Cg
	for pgadmin-hackers@lists.postgresql.org; Sat, 19 Sep 2020 12:52:19 +0000
Received: from mail-vs1-xe2f.google.com ([2607:f8b0:4864:20::e2f])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <jv.cyril@gmail.com>)
	id 1kJcLh-0000qx-62
	for pgadmin-hackers@postgresql.org; Sat, 19 Sep 2020 12:52:18 +0000
Received: by mail-vs1-xe2f.google.com with SMTP id e14so5302910vsa.9
        for <pgadmin-hackers@postgresql.org>;
 Sat, 19 Sep 2020 05:52:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:from:date:message-id:subject:to;
        bh=SyebdHZ9RbAVnlwQ8Y2DXUckHG27HcSKviZwmDfZuBo=;
        b=oZ0+T+AM2CRA36fqYCM3pwi9dJVcPzdNDfBBn1wx9gwWupIN/ip/wEZpu41xFaGjFj
         8GsX5gS2Yf6J4LWm9iTISyUov7aB7sgkxLkenS/nRZ1povrWm/k68sXJNqGRUinTVOfg
         rWgTlj5zXp4YC/zbDkYEzMQj7lFZzl/He0rrndHM3NoWlzxvoMlsPcqAjjeD6JwszU0U
         v1knyun5l8YKAdoGV/1C2112Mi9gb0Vl+FSPryZ5r+ya9x/efJzSDmhOnAyLGdiR3x5p
         2NA/WD9rTYZ9d/EHaqwnNts956aq4XivzWuNwjQdAHHRG4tegGks0gYjwmrQiUkOZAWq
         Evkg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=SyebdHZ9RbAVnlwQ8Y2DXUckHG27HcSKviZwmDfZuBo=;
        b=i5zwm/6EJnbTetEY/VFUX1AhcNAr0n8iylYX6BcZQEB0GhD+BsxXHlyWBPv/BqeudO
         4qAo2W5wIjaMC90wNbH/FemkHbZXN1d2YdVRXJePm3MGYiHknCnXe8j95EqbO08utMUV
         v/OrKjeuKgFwOs+p2/7jNnyarFxxG54tgrxd8Ldo1eWfmRkQAgUpU6ppPb0szY+WWY2K
         D1KjAd3aDyn3TrEBGUQyTZ5oBXpiucEEecyGUFFJfUQV+6YQXE06EflhHEh++s01iOE3
         Ws0EnojSiqskB7NIC84V9ZiE1t3/Bpx6/KL9aybcgoXqaRqMCK2ep0Eszw6rfR+2zwEF
         TiWQ==
X-Gm-Message-State: AOAM53274gmo/fgac6lMlMmBS6n9Yxyw+gWAbo1y2Q0EnZJ1baWzlkqD
	jKo69rdOOQcZle2rSTqe8MRocoA1NOBq3GMAMxWohWRjXiDFfA==
X-Google-Smtp-Source: 
 ABdhPJxstPAKsWFJsZZVnB2mlE4ktK8kG1/RPuk+IaEvfbM0IEPexN3Q3HulsqXnBDX3V7KqtYOp/IGfVIrKqIetelw=
X-Received: by 2002:a05:6102:2f7:: with SMTP id
 j23mr13632550vsj.35.1600519935630;
 Sat, 19 Sep 2020 05:52:15 -0700 (PDT)
MIME-Version: 1.0
From: Cyril Jouve <jv.cyril@gmail.com>
Date: Sat, 19 Sep 2020 14:52:10 +0200
Message-ID: 
 <CANhjAHxpK_j_w1Zmu5Keofsqz4bbcpsnKR8ybNPZUqQNN-DANg@mail.gmail.com>
Subject: RM5841: server.username can be empty when using .pg_service.conf
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000383ce405afaa165d"
List-Id: <pgadmin-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgadmin-hackers@lists.postgresql.org>
List-Owner: <mailto:pgadmin-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgadmin-hackers>
Precedence: bulk

--000000000000383ce405afaa165d
Content-Type: multipart/alternative; boundary="000000000000383ce105afaa165b"

--000000000000383ce105afaa165b
Content-Type: text/plain; charset="UTF-8"

fix for https://redmine.postgresql.org/issues/5841

--000000000000383ce105afaa165b
Content-Type: text/html; charset="UTF-8"

<div dir="ltr">fix for <a href="https://redmine.postgresql.org/issues/5841">https://redmine.postgresql.org/issues/5841</a></div>

--000000000000383ce105afaa165b--

--000000000000383ce405afaa165d
Content-Type: application/octet-stream;
	name="0001-server.username-can-be-None-when-using-.pg_service.c.patch"
Content-Disposition: attachment;
	filename="0001-server.username-can-be-None-when-using-.pg_service.c.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kf9o81sk0>
X-Attachment-Id: f_kf9o81sk0

RnJvbSA2OGI3ODhkMTZlNzUwMDk3ZDFkZTExMTllZTA0M2Q2ZjM1M2E2YTJjIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBDeXJpbCBKb3V2ZSA8anYuY3lyaWxAZ21haWwuY29tPgpEYXRl
OiBTYXQsIDE5IFNlcCAyMDIwIDE0OjM5OjU2ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gc2VydmVy
LnVzZXJuYW1lIGNhbiBiZSBOb25lIHdoZW4gdXNpbmcgLnBnX3NlcnZpY2UuY29uZgoKLS0tCiB3
ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9fX2luaXRfXy5weSB8IDgg
LS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3dl
Yi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL19faW5pdF9fLnB5IGIvd2Vi
L3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19pbml0X18ucHkKaW5kZXgg
ZWQ4ZmFlMGYwLi5jY2I0N2YxZDMgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2Vy
dmVyX2dyb3Vwcy9zZXJ2ZXJzL19faW5pdF9fLnB5CisrKyBiL3dlYi9wZ2FkbWluL2Jyb3dzZXIv
c2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL19faW5pdF9fLnB5CkBAIC0xMjgwLDE0ICsxMjgwLDYgQEAg
Y2xhc3MgU2VydmVyTm9kZShQR0NoaWxkTm9kZVZpZXcpOgogICAgICAgICBpZiBzZXJ2ZXIgaXMg
Tm9uZToKICAgICAgICAgICAgIHJldHVybiBiYWRfcmVxdWVzdChzZWxmLm5vdF9mb3VuZF9lcnJv
cl9tc2coKSkKIAotICAgICAgICAjIFJldHVybiBpZiB1c2VybmFtZSBpcyBibGFuawotICAgICAg
ICBpZiBzZXJ2ZXIudXNlcm5hbWUgaXMgTm9uZToKLSAgICAgICAgICAgIHJldHVybiBtYWtlX2pz
b25fcmVzcG9uc2UoCi0gICAgICAgICAgICAgICAgc3RhdHVzPTIwMCwKLSAgICAgICAgICAgICAg
ICBzdWNjZXNzPTAsCi0gICAgICAgICAgICAgICAgZXJyb3Jtc2c9Z2V0dGV4dCgKLSAgICAgICAg
ICAgICAgICAgICAgdSJQbGVhc2UgZW50ZXIgdGhlIHNlcnZlciBkZXRhaWxzIHRvIGNvbm5lY3Qi
KQotICAgICAgICAgICAgKQogICAgICAgICBpZiBjdXJyZW50X3VzZXIgYW5kIGhhc2F0dHIoY3Vy
cmVudF91c2VyLCAnaWQnKToKICAgICAgICAgICAgICMgRmV0Y2ggVXNlciBEZXRhaWxzLgogICAg
ICAgICAgICAgdXNlciA9IFVzZXIucXVlcnkuZmlsdGVyX2J5KGlkPWN1cnJlbnRfdXNlci5pZCku
Zmlyc3QoKQotLSAKMi4yOC4wCgo=
--000000000000383ce405afaa165d--