Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD2Fo-0006BA-Ew for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Sep 2020 09:07:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kD2Fn-0000iU-Di for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Sep 2020 09:06:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD2Fn-0000iK-4B for pgadmin-hackers@lists.postgresql.org; Tue, 01 Sep 2020 09:06:59 +0000 Received: from mail-vk1-xa2d.google.com ([2607:f8b0:4864:20::a2d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kD2Fk-0003Jy-Bk for pgadmin-hackers@postgresql.org; Tue, 01 Sep 2020 09:06:58 +0000 Received: by mail-vk1-xa2d.google.com with SMTP id h23so158035vkn.4 for ; Tue, 01 Sep 2020 02:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vq02HzHtZlnU9g5eR2NHqibrtHWuVT1Q5N6/GTjqJwc=; b=QMO/Bef58pIozlS3r2Y01GWfioOKp7qpo3/KyVtjKOLC5cN2Bj6Ui6OdHAn1pGjT+Q QuwNkyAl2NTc3eR6af+fGq1k8XYH1K1YVTvJVpSCHJyRot7ZOl8C1ramJAfmlUEsl10H lu50+73P6jnkkuTUMu1E90XQFvnYIvq+92KBY0sHqk0WumpWUKAyYyIcPrisb/6mZoql DW5r1rLFdRF7q6AS+Djb/QEXNZ7czXA0hCvAlJZ9GLY5XLxQw6M/jFdK+CBPIPFVFiR7 sQYPB+lt8smT5D0R8vg9jNy3LRmHzZ5UWx2WS//4BRG3z7iMdnvCu9QDRfLozznkogO9 kgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vq02HzHtZlnU9g5eR2NHqibrtHWuVT1Q5N6/GTjqJwc=; b=eMU/mytrZRzGr0J2QrWmbt0hqvNWKkdMFwUePbQb9ZE2LkVHvpaqQ6kv5NUUnGcBDH FkzQkNG8lHchOHeawi2wM+R/EWRNoYVame6dIA9/njwMmPMAHwJuq3wJ6lwwutg586fI fgo0dOMAwRVYfrisGUFZVrDDMDnOP0uHxJy86/+cGML8TR8ibfQH8Vn04tGDmFSgfRx0 mkGyfNsnbTT9bg94yg+m02heazainTCUuLeOn5qqsQEOFv7LifXNe8qyoPPQIubFQKrC tLT4J7ZFRNcKpQcQsaxgWvRwFsLUzNsgkgcrD1N9pZUUH/j4c8pBkGgsR7GyugSxCYqc szKA== X-Gm-Message-State: AOAM532AN7DUsxZSyVuc+/E2O4cETuYtkwufwsBoDSZU7pUgoPFPyG2c +xmQiksegrAcQckv5X5t+igK5rE4c0/HIZcaET0= X-Google-Smtp-Source: ABdhPJwwGXAzrFj0be5rjdvsy0lu83yT8VCeg3R2fSOCFliugXkeZqLXgRV0iuyPwntMrYIA2RIoGpl7q9Sm/TmZvWc= X-Received: by 2002:a1f:4111:: with SMTP id o17mr330495vka.27.1598951213710; Tue, 01 Sep 2020 02:06:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Cyril Jouve Date: Tue, 1 Sep 2020 11:06:42 +0200 Message-ID: Subject: Re: More idiomatic python3 + fix some tests To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000001b417405ae3cd778" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000001b417405ae3cd778 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable thanks :) and sure, I'll run the linter next time! have you thought of automatic code formatters instead like yapf or black? Le lun. 31 ao=C3=BBt 2020 =C3=A0 13:18, Akshay Joshi a =C3=A9crit : > Hi Cyril > > Thanks, patch applied. Please make sure to run "yarn run pep8" before > sending the patch. > > On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve wrote: > >> Hello, >> >> patch 1 to 6 generated mostly using 2to3: >> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts >> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter >> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms >> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass >> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange >> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode >> >> patch 7 fixes change_password tests: >> Less that min length : min is 8 instead of 6 >> Valid password : use an user different than admin user / mock mail modul= e >> >> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using >> simplejson like in all other modules). >> >> Regards, >> Cyril >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --0000000000001b417405ae3cd778 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
thanks :)

and sure, I'll= run the linter next time!

have you thought of aut= omatic code formatters instead like yapf or black?



Le=C2=A0lun. 31 ao=C3=BBt 2020 =C3=A0=C2=A013:18, Akshay Joshi &= lt;akshay.joshi@enterprise= db.com> a =C3=A9crit=C2=A0:
Hi Cyril

= Thanks, patch applied. Please make sure to run "yarn run pep8" be= fore sending the patch.

On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouv= e <jv.cyril@gmai= l.com> wrote:
Hello,

patch 1 to 6 gen= erated mostly using 2to3:

patch 7 = fixes change_password tests:
Less that min length : min is 8 inst= ead of 6
Valid password : use an user different than admin user /= mock mail module

patc= h 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using simplejson like= in all other modules).

Regards,
Cyr= il


--
Thanks & R= egards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect=
= EDB Postgres
Mobile: +91 976-788-8246

--0000000000001b417405ae3cd778--