Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQfpt-00008g-HU for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jun 2018 21:19:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQfpo-0000Zj-6o for pgadmin-hackers@arkaria.postgresql.org; Wed, 06 Jun 2018 21:19:12 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQfpn-0000ZT-Uo for pgadmin-hackers@lists.postgresql.org; Wed, 06 Jun 2018 21:19:12 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQfph-0006wV-K8 for pgadmin-hackers@postgresql.org; Wed, 06 Jun 2018 21:19:07 +0000 Received: from pps.filterd (m0114583.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w56LAZC3004498 for ; Wed, 6 Jun 2018 21:19:03 GMT Received: from mail-it0-f70.google.com (mail-it0-f70.google.com [209.85.214.70]) by mx0a-00296801.pphosted.com with ESMTP id 2jbj0mcjr1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 06 Jun 2018 21:19:03 +0000 Received: by mail-it0-f70.google.com with SMTP id 8-v6so6328099itz.4 for ; Wed, 06 Jun 2018 14:19:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Rf97zlWYaf+tiGxxnGY/hKWI4FAh3PKnBP6zn3KHNUU=; b=XuNg/MwNlBsPVoxNoy7cRfRyHlMXs5FIBC9DTJrYjZou7kv/+lmh4ocSOeJ1ftvpBQ Zp9N4nDKkm0oJezoFy4PhI+okbRp+Dw7H9TFnVOOrWcJCH1/akV/mhFSEGLxAbe6N6ZN ylaM8N+gQEwm5SzCwb+yEroY2tEHEOhjps+aGv/c1M7T0j5L/Pf1HxofO1ZhahXzphyf MRTReR1+b9XDBLp2xWM+TkyARkuA+bUluh9pvQP8i6T7KsOJjNIxw9pCntE629ds6V5A /UsGnlUw3ZtZeSv6q9Ko9DwWwl4wnFI5IZMkCZWKXvfGNzk3+l/NaItG5lb3G9dIM9ie vLDA== X-Gm-Message-State: APt69E28/4Sbxgd27xWoNk1L3gc/XTezhQyJK39PLTfQMHYqpa2ID/fz ySNFR4hyTL2Fqht/bro2gnMJmxkkv3c+G0ILMSnf7ZLZcaZGZS2pvnGch7Ak25TtGA1q5jiumGM rFjaqakmaaZKnd1FiRBcaVlbN9/6cQ2m0G2qdRBx12zeKutZvllcvYit7Z0QoKvi33494 X-Received: by 2002:a6b:6f05:: with SMTP id k5-v6mr4711342ioc.55.1528319942288; Wed, 06 Jun 2018 14:19:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIP3VgQEoPw681FSBE25QgvETZCgfjP+4dMczYHBEdrN65aloZr9ZtwsPD9hK9LHMjkDCMDOMZ2BuZA+GSGu7o= X-Received: by 2002:a6b:6f05:: with SMTP id k5-v6mr4711333ioc.55.1528319942002; Wed, 06 Jun 2018 14:19:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Victoria Henry Date: Wed, 6 Jun 2018 17:18:51 -0400 Message-ID: Subject: Re: [pgAdmin4][RM#3404] Graphical explain plan do not display text under the node To: Murtuza Zabuawala Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003f2d2b056dffb7eb" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-06_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=9 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=979 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806060234 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000003f2d2b056dffb7eb Content-Type: text/plain; charset="UTF-8" Hi Murtuza, LGTM and passes tests: https://gpdb-dev.bosh.pivotalci.info/teams/pgadmin/pipelines/pgadmin-patch/jobs/run-tests/builds/119 Sincerely, Victoria On Wed, Jun 6, 2018 at 1:04 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA minor patch to fix the regression issue introduced with RM#3271 commit > due to which label is not displaying under the graphical explain node, I've > attached the screenshot in RM for your reference. > --0000000000003f2d2b056dffb7eb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Murtuza,

LGTM and passes tests:

Sincerely,

Victoria

On Wed, Jun 6, 201= 8 at 1:04 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA minor patch to fix the regression is= sue introduced with RM#3271 commit due to which label is not displaying und= er the graphical explain node, I've attached the screenshot in RM for y= our reference.
--0000000000003f2d2b056dffb7eb--