Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRIi1-0003Ln-EW for pgadmin-hackers@arkaria.postgresql.org; Fri, 08 Jun 2018 14:49:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fRIhz-0003Zn-8O for pgadmin-hackers@arkaria.postgresql.org; Fri, 08 Jun 2018 14:49:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRIhz-0003ZG-1z for pgadmin-hackers@lists.postgresql.org; Fri, 08 Jun 2018 14:49:43 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fRIht-0003pi-EX for pgadmin-hackers@postgresql.org; Fri, 08 Jun 2018 14:49:41 +0000 Received: from pps.filterd (m0114582.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w58EkYub016346 for ; Fri, 8 Jun 2018 14:49:33 GMT Received: from mail-io0-f197.google.com (mail-io0-f197.google.com [209.85.223.197]) by mx0a-00296801.pphosted.com with ESMTP id 2jbj04x6bt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 08 Jun 2018 14:49:33 +0000 Received: by mail-io0-f197.google.com with SMTP id i18-v6so568622iog.12 for ; Fri, 08 Jun 2018 07:49:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6ek6CY8FRBt2MRUMnBas/EU9uttb4I91dS+Gx4xYnxE=; b=FFmwh6hJ5VBXqUf87MObX55kGsJ2cILbFdl8ida0zt2DlJt6iDxpufUTjB3D/lfUh8 jcLZNHk9FFng1jyrqAsiF5IT2Ze14PQDTRf7g48Sw6bJnWQ9Kq1sJ99Hi2RsdcpSofgQ WRSxS+T9UklMdyjLJl38Jdo4YCkeKgfHqCAdexzkS766RxosUlW1K1qksiBgzthB+Tl4 IV5KuSdvtV62RXe6j1g2ivbqqY9SnabN9xSAYHLdF9V//ohTsqcshE/3H4URMfUfX9u1 XbEwFUelu8P4lvEw/7DSTXfmSHO0KlyWnAa9zAao9C8YldfBWCBHs62wQ4uw+E46TaE6 xFtg== X-Gm-Message-State: APt69E02mThKqNHBJBLpvCQCGjNMAoQZo6X/5L0gMb9whIR9VJ3Hg+9b JGBNmSlzhsJvhGn+GA8891qLAFIC9F8nGNk5uMC4tE5iO0dZjCzthFUQt4zlL1B/ZBzGbihXQmT w5n5GXfA0a0v/RKZpyBwRC2aYwNHBlLiWY7+eug9B3djb0LppbbsjhFpoX46dL2xGlToa X-Received: by 2002:a6b:2653:: with SMTP id m80-v6mr5438397iom.301.1528469371653; Fri, 08 Jun 2018 07:49:31 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJ+K8vsR87WTE2LWxaMjBQfM5IbuLdz6IvE1HssuV7PK2uZtbyhkN/hZTZHJAquMh2QTwAb2ASUjQs57RrrtWc= X-Received: by 2002:a6b:2653:: with SMTP id m80-v6mr5438373iom.301.1528469371301; Fri, 08 Jun 2018 07:49:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Victoria Henry Date: Fri, 8 Jun 2018 10:49:20 -0400 Message-ID: Subject: Re: [pgadmin][patch] Electron version 4.X To: Dave Page Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ed5a0d056e22818a" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-08_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=5 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806080166 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ed5a0d056e22818a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 5, 2018 at 12:28 PM Dave Page wrote: > Hi > > On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hi Hackers, >> >> Attached you can find the patch that introduces electron to our code bas= e. >> > Cool. FYI, I'd like to get this into rough shape and then push it to a de= v > branch for fine-tuning. I think it'll be easier to work that way. > Sure, you can create a dev branch and push this patch to it. Great. So here's my initial feedback: > > - The Mac build you provided doesn't work for me. It hangs on the loading > screen. > Could we get some more information about the machine? Using the python from the venv directory, are you able to run the app directly? cd /Applications/pgAdmin.app/Contents/Resources/app/ venv/bin/python web/pgAdmin4.py =E2=80=8B Do you get and error? We are setting PGADMIN_PORT, PGADMIN_KEY and SERVER_MODE environment variables prior to starting it. > > - A number of the changes are related to the naming of requirejs. I'd be > inclined to pull that out into a separate patch and get it committed to > master ASAP. > This change only makes sense in the Electron context. Neverthless fell free to add it to master if you think it is relevant. > - I think the build instructions need to be more generic (particularly on > macOS). For example, I do not use HomeBrew (largely due to some nasty > security issues they had in the past). I was able to mostly port the > instructions and build script over to work using MacPorts (without PyEnv) > which actually turned out to be somewhat more simple than what's there no= w. > Since we don't use MacPorts, we cannot provide installation instructions. > - I'm not sure what this is intended to do: "git checkout electron". > Clearly that isn't correct. > That was the name of our development branch. It can be removed. > > - All new builds should be using Python 3.6. We need to deprecate 2.7 as > there are some Unicode related issues that cannot be fixed in it. > For Windows, we are using 2.7 because of external library compilation issues. Let us know if you are able to get around this or how to make this work. > - I would like to see the new build code adapted to follow the existing > conventions as much as reasonable, to avoid having to change build system= s > or other processes/procedures that folks use. For example, build scripts > should be under pkg/, completed packages left in dist/, build staging don= e > in xxx-build directories rather than elsewhere. > That sounds reasonable. > - It may be a result of my use of MacPorts, but I'm getting the following > failure building: > > yarn run v1.3.2 > $ electron-forge make --platfrom=3Ddarwin --arch=3Dx64 --targets=3Ddmg > =E2=9C=94 Checking your system > =E2=9C=94 Resolving Forge Config > We need to package your application before we can make it > =E2=9C=94 Preparing to Package Application for arch: x64 > =E2=A0=BC Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/venv/lib/python= 3.6/site-packages/setuptools/command/launcher > manifest.xml > Compiling > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/venv/lib/python= 3.6/site-packages/setuptools/command/launcher > manifest.xml resulted in a MIME type of application/xml, which we don't > know how to handle > =E2=A0=8B Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/server_groups/servers/templates/servers/supported_servers.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/server_groups/servers/templates/servers/supported_servers.js: > Unexpected token (6:7) > =E2=A0=A6 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/endpoints.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/endpoints.js: > Unexpected token (5:6) > Failed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/messages.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/messages.js: > Unexpected token (37:1) > Failed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/utils.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/bro= wser/templates/browser/js/utils.js: > Unexpected token (28:23) > =E2=A0=8B Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/mis= c/file_manager/templates/file_manager/js/languages/en.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/mis= c/file_manager/templates/file_manager/js/languages/en.js: > Unexpected token, expected ; (2:29) > =E2=A0=8B Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/sta= tic/scss/_alert.scss > Error: Undefined variable: "$color-green-3". > on line 29 of /stdin > >> background: $color-green-3; > > --------------^ > > =E2=A0=99 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/sta= tic/scss/_alertify.overrides.scss > Error: ".ajs-message.ajs-error.ajs-visible" failed to @extend ".bg-red-1"= . > The selector ".bg-red-1" was not found. > Use "@extend .bg-red-1 !optional" if the extend should be able to > fail. > on line 164 of /stdin > >> @extend .bg-red-1; > > ----------^ > > =E2=A0=B4 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/sta= tic/scss/sqleditor/_history.scss > Error: Undefined variable: "$color-gray-3". > on line 4 of /stdin > >> border-bottom: 1px solid $color-gray-3; > > -----------------------------^ > We were also seeing these errors but they don't have any impact on the compilation and should be addressed in the future (not in this patch) > > =E2=A0=87 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/tem= plates/base.html > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/tem= plates/base.html:inline_1.js: > Unexpected token (2:13) > =E2=A0=B4 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/too= ls/templates/js/translations.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/too= ls/templates/js/translations.js: > Unexpected token (2:10) > =E2=A0=A6 Compiling ApplicationFailed to compile file: > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/too= ls/user_management/templates/user_management/js/current_user.js > /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin= -x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/too= ls/user_management/templates/user_management/js/current_user.js: > Unexpected token (3:15) > =E2=9C=94 Compiling Application > =E2=9C=94 Preparing native dependencies > =E2=9C=94 Packaging Application > Making for the following targets: > =E2=A0=8B Making for target: dmg - On platform: darwin - For arch: x64 > An unhandled exception has occurred inside Forge: > Cannot find module 'macos-alias' > Error: Cannot find module 'macos-alias' > This may be related to using MacPorts or the way you installed the dependencies. There was a bug with Electron and Node 10 so we had to use to Node 8 with Yarn. Thanks, Victoria & Joao --000000000000ed5a0d056e22818a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue= , Jun 5, 2018 at 12:28 PM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Mon, Jun 4, 2018 at 10:27 PM, Joao De Almeida Perei= ra <jdealmeidapereira@pivotal.io> wrote:

Hi Hackers,=

Attached you can find the patch that intr= oduces electron to our code base.

Cool. FY= I, I'd like to get this into rough shape and then push it to a dev bran= ch for fine-tuning. I think it'll be easier to work that way.
Sure, you can create a dev branch and push = this patch to it.

Great. So here's my initial feedback:

- The Mac build you provided doesn't work for me. It hangs on the= loading screen.
Could we get some= more information about the machine?=C2=A0 Using the python from the venv d= irectory, are you able to run the app directly?=C2=A0
cd /Applications/pgAdmin.app/Contents/Resources/app/=20
venv/bin/python web/pgAdmin4.py
=E2=80= =8B
Do you get and error?
We are setti= ng PGADMIN_PORT, PGADMIN_KEY and SERVER_MODE environment variables prior to= starting it.
=C2=A0
=C2=A0
<= div class=3D"gmail_quote">
- A number of the changes are rel= ated to the naming of requirejs. I'd be inclined to pull that out into = a separate patch and get it committed to master ASAP.
This change only makes sense in the Electron context. N= everthless fell free to add it to master if you think it is relevant.
=


- I think the build instructions need to be more generic (particula= rly on macOS). For example, I do not use HomeBrew (largely due to some nast= y security issues they had in the past). I was able to mostly port the inst= ructions and build script over to work using MacPorts (without PyEnv) which= actually turned out to be somewhat more simple than what's there now.<= br>
Since we don't use MacPort= s, we cannot provide installation instructions.


- I&#= 39;m not sure what this is intended to do: "git checkout electron"= ;. Clearly that isn't correct.
That was the name of our development branch.=C2=A0 It can be removed.
=C2=A0

- All new builds should be using Python 3.6. We need to deprecate = 2.7 as there are some Unicode related issues that cannot be fixed in it.
For Windows, we are using 2.7 becaus= e of external library compilation issues.=C2=A0 =C2=A0Let us know if you ar= e able to get around this or how to make this work.
=C2=A0
- I would like to see= the new build code adapted to follow the existing conventions as much as r= easonable, to avoid having to change build systems or other processes/proce= dures that folks use. For example, build scripts should be under pkg/, comp= leted packages left in dist/, build staging done in xxx-build directories r= ather than elsewhere.
That sounds = reasonable.
=C2=A0
- It may be a r= esult of my use of MacPorts, but I'm getting the following failure buil= ding:=C2=A0

yarn run v1.3.2
$ electron-forge make --platfrom=3Ddar= win --arch=3Dx64 --targets=3Ddmg
=E2=9C=94 Checking your system
=E2=9C=94 Resolving Forge Config
We need to package your= application before we can make it
=E2=9C=94 Preparing to Package= Application for arch: x64
=E2=A0=BC Compiling ApplicationFailed = to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-= packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/= venv/lib/python3.6/site-packages/setuptools/command/launcher manifest.xml
Compiling /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electro= n-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/ap= p/venv/lib/python3.6/site-packages/setuptools/command/launcher manifest.xml= resulted in a MIME type of application/xml, which we don't know how to= handle
=E2=A0=8B Compiling ApplicationFailed to compile file: /v= ar/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64= /pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/browser= /server_groups/servers/templates/servers/supported_servers.js
/va= r/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/= pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/= server_groups/servers/templates/servers/supported_servers.js: Unexpected to= ken (6:7)
=E2=A0=A6 Compiling ApplicationFailed to compile file: = /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x= 64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/brows= er/templates/browser/js/endpoints.js
/var/folders/c6/pwf0k2d509s2= xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electr= on.app/Contents/Resources/app/web/pgadmin/browser/templates/browser/js/endp= oints.js: Unexpected token (5:6)
Failed to compile file: /var/fol= ders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdm= in-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/templ= ates/browser/js/messages.js
/var/folders/c6/pwf0k2d509s2xx6vh0h63= 3vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Co= ntents/Resources/app/web/pgadmin/browser/templates/browser/js/messages.js: = Unexpected token (37:1)
Failed to compile file: /var/folders/c6/p= wf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin= -x64/Electron.app/Contents/Resources/app/web/pgadmin/browser/templates/brow= ser/js/utils.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/= electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resou= rces/app/web/pgadmin/browser/templates/browser/js/utils.js: Unexpected toke= n (28:23)
=E2=A0=8B Compiling ApplicationFailed to compile file: = /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x= 64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/misc/= file_manager/templates/file_manager/js/languages/en.js
/var/folde= rs/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin= -darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/misc/file_manag= er/templates/file_manager/js/languages/en.js: Unexpected token, expected ; = (2:29)
=E2=A0=8B Compiling ApplicationFailed to compile file: /va= r/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/= pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/web/pgadmin/static/s= css/_alert.scss
Error: Undefined variable: "$color-green-3&q= uot;.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 on line 29 of /stdin
= >>=C2=A0 =C2=A0background: $color-green-3;

= =C2=A0 =C2=A0--------------^

=E2=A0=99 Compiling A= pplicationFailed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0= 000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Conten= ts/Resources/app/web/pgadmin/static/scss/_alertify.overrides.scss
Error: ".ajs-message.ajs-error.ajs-visible" failed to @extend &q= uot;.bg-red-1".
=C2=A0 =C2=A0 =C2=A0 =C2=A0The selector &quo= t;.bg-red-1" was not found.
=C2=A0 =C2=A0 =C2=A0 =C2=A0Use &= quot;@extend .bg-red-1 !optional" if the extend should be able to fail= .
=C2=A0 =C2=A0 =C2=A0 =C2=A0 on line 164 of /stdin
>= ;>=C2=A0 =C2=A0@extend .bg-red-1;

=C2=A0 =C2=A0= ----------^

=E2=A0=B4 Compiling ApplicationFailed = to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-= packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/= web/pgadmin/static/scss/sqleditor/_history.scss
Error: Undefined = variable: "$color-gray-3".
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = on line 4 of /stdin
>>=C2=A0 =C2=A0 =C2=A0border-bottom: 1p= x solid $color-gray-3;

=C2=A0 =C2=A0--------------= ---------------^
We were also seei= ng these errors but they don't have any impact on the compilation and s= hould be addressed in the future (not in this patch)
=C2=A0
=

=E2=A0=87 Compiling Application= Failed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/el= ectron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resourc= es/app/web/pgadmin/templates/base.html
/var/folders/c6/pwf0k2d509= s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x64/Elec= tron.app/Contents/Resources/app/web/pgadmin/templates/base.html:inline_1.js= : Unexpected token (2:13)
=E2=A0=B4 Compiling ApplicationFailed t= o compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/electron-p= ackager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resources/app/w= eb/pgadmin/tools/templates/js/translations.js
/var/folders/c6/pwf= 0k2d509s2xx6vh0h633vm0000gn/T/electron-packager/darwin-x64/pgAdmin-darwin-x= 64/Electron.app/Contents/Resources/app/web/pgadmin/tools/templates/js/trans= lations.js: Unexpected token (2:10)
=E2=A0=A6 Compiling Applicati= onFailed to compile file: /var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/= electron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resou= rces/app/web/pgadmin/tools/user_management/templates/user_management/js/cur= rent_user.js
/var/folders/c6/pwf0k2d509s2xx6vh0h633vm0000gn/T/ele= ctron-packager/darwin-x64/pgAdmin-darwin-x64/Electron.app/Contents/Resource= s/app/web/pgadmin/tools/user_management/templates/user_management/js/curren= t_user.js: Unexpected token (3:15)
=E2=9C=94 Compiling Applicatio= n
=E2=9C=94 Preparing native dependencies
=E2=9C=94 Pac= kaging Application
Making for the following targets:
= =E2=A0=8B Making for target: dmg - On platform: darwin - For arch: x64
An unhandled exception has occurred inside Forge:
Cannot fi= nd module 'macos-alias'
Error: Cannot find module 'ma= cos-alias'
This may be related= to using MacPorts or the way you installed the dependencies.=C2=A0 There w= as a bug with Electron and Node 10 so we had to use to Node 8 with Yarn.
=C2=A0
Thanks,

Victoria & Jo= ao
--000000000000ed5a0d056e22818a--