Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmukm-000395-V8 for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Dec 2020 08:23:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kmukl-0002Tn-Td for pgadmin-hackers@arkaria.postgresql.org; Wed, 09 Dec 2020 08:23:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kmukl-0002Tg-KH for pgadmin-hackers@lists.postgresql.org; Wed, 09 Dec 2020 08:23:15 +0000 Received: from mail-io1-xd2d.google.com ([2607:f8b0:4864:20::d2d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kmuki-00081x-Fw for pgadmin-hackers@postgresql.org; Wed, 09 Dec 2020 08:23:14 +0000 Received: by mail-io1-xd2d.google.com with SMTP id z5so758566iob.11 for ; Wed, 09 Dec 2020 00:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PWtjNfv+vJnLVri8A+lmuh4quirtgusmywg9kBXoT6U=; b=qH+28JO1WdhOA91ZqY+X+LRHLRSOvbzcSIhQYZ0kMcyAQNIY0fOEuzrUsJ8OGc/w02 tEs2hSlDlBUosu4e71TzZ5dGH5Wj5mrCKa8e7SAa5oPf7ggo3+X2I+9j2/XDff4wV3E2 gSFezqSgPyKUymtAdxBtciGDh0Pfzq1vKVXXhe1fWbseX0fIiCNRLypwLyEymWggehj+ zq4Q4/1Ia8oDsrYw10gRVEH7ijS9STwWdlQccqUOSNFmTuff65pudLXMnPjTWYp18mrY fkZkm+bMXDnOoSjzJskgn7giMML/j3dOPH0icv2mW/g1bhyq6td9Mx2erYX3OGUfN0CM AQUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PWtjNfv+vJnLVri8A+lmuh4quirtgusmywg9kBXoT6U=; b=hWlmxnTt06454OXQz/vwwWNH6SNxX8eyymiPiVubojw+QWo1Vrg7DkiVXXDMl2hrKA 7pc3nSOO1fcAdI4FBhUarnQVJ1XPQUq575gQQpnNZqbQ9F2N+xG86jqL9TXrcfJ1UJ/i YZtVSzONpxi66RahX7M+JO0QI1WTJr+myEPVcYj2Xzb8kCKwvip7tdDDSADoJaL8nnJ8 CFzzu43nIFGoxYg8/eAma7EOvHBT5/0PAhlJBiHg2srHTxc9Om6LpI7Oy30PV8LqHkMR r9T+ySE7QDUb5wbH7iHS3SUayF8PotEjIrr95dJsnXKwaEw8zEFAxSZpcx5qRRKDddrO UmFg== X-Gm-Message-State: AOAM530aTy9/yehOl6sOh+LKArk+t+cNhbDycSeTut0L0EX6WMETmreU ZYJVz8aOdkEp103g3Nthv618yt6pUBASqrrEK0hXq8mr19mT3Isf1gNEKhrbKUcjcdvkTzrnJ7Y AkISlxxB5G50jTeCQHOOBAMcUfh6eSMg9437KmrTrZa9FTKdZpPqwG6At6ygN1jnYusUKN2GqtN CwGtMIRkq3dV08xa3D1HvFqd3IW1daIupMzehCZFNnXUxMGJu9SPWf1wxT88GgTTo= X-Google-Smtp-Source: ABdhPJwDwM5q+wN7AtcmvhyGTnGwYTi+BEuQXOF41wY7NS9xYWztXYgIQnDcx4nYaQV0NpI6fk+7E+4RyZJD2HEOGrQ= X-Received: by 2002:a05:6602:2d89:: with SMTP id k9mr1410802iow.52.1607502191380; Wed, 09 Dec 2020 00:23:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 9 Dec 2020 13:53:00 +0530 Message-ID: Subject: Re: [pgAdmin4] RM5965 Couldn't download file of Marcos query results To: Aditya Toshniwal Cc: pgadmin-hackers , Rahul Shirsat Content-Type: multipart/alternative; boundary="00000000000017e6b405b603c55b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000017e6b405b603c55b Content-Type: text/plain; charset="UTF-8" Hi Aditya Can you please review this patch? On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the updated patch below. > > On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat < > rahul.shirsat@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch which resolves the issue of macros query >> results download, have used async cursor to achieve this functionality, >> where for downloading the results, cursor is scrolled back to 0 and end of >> the records, and reset again while user scrolling on Data Output table. >> >> QA/Reviewer needs to observe below issues if it occurs: >> >> 1. If records are more like 5000 or 10000, try to fetch records by >> scrolling at least (2000), now save the results by clicking the download >> button, it should save the file, and now try scrolling again, the data >> should be shown continuously and not any abrupt end or unexpected records >> order. >> 2. Also, the download button is now "Save results to CSV/TXT" where >> it will only get enabled when there are valid records in the Data Output. >> >> >> Also a minor fix of the add folder icon issue is also added into this >> patch. >> >> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Rahul Shirsat* > Software Engineer | EnterpriseDB Corporation. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --00000000000017e6b405b603c55b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Aditya

Can you please review this pa= tch?

On Mon, Dec 7, 2020 at 3:10 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wr= ote:
Hi Hackers,

Please find the updated patch belo= w.

On Mon, Dec 7, 2020 at 2:55 PM Rahul Shirsat <rahul.shirsat@enterprised= b.com> wrote:
Hi Hackers,

Please find the attach= ed patch which resolves the issue of macros query results download, have us= ed async cursor to achieve this functionality, where for downloading the re= sults, cursor is scrolled back to 0 and end of the records, and reset again= while user scrolling on Data Output table.

QA/Rev= iewer needs to observe below issues if it occurs:
  1. If reco= rds are more like 5000 or 10000, try to fetch records by scrolling at least= =C2=A0(2000), now save the results by clicking the download button, it shou= ld save the file, and now try scrolling again, the data should be shown con= tinuously and not any abrupt end or unexpected records order.
  2. Also,= the download button is now "Save results to CSV/TXT" where it wi= ll only get enabled when there are valid records in the Data Output.

Also a minor fix of the add folder icon issue = is also added into this patch.

--
Rahul Shirsat
Senior Software E= ngineer=C2=A0|=C2=A0EnterpriseDB=C2=A0Corporation.
=


--
Rahul Shirsat
Software Engineer=C2= =A0|=C2=A0EnterpriseDB=C2=A0Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--00000000000017e6b405b603c55b--