Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9oLu-0006m1-PU for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 12:12:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l9oLt-00048M-Nz for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 Feb 2021 12:12:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9oLt-00048F-BZ for pgadmin-hackers@lists.postgresql.org; Wed, 10 Feb 2021 12:12:13 +0000 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9oLq-0002Kv-Mn for pgadmin-hackers@postgresql.org; Wed, 10 Feb 2021 12:12:12 +0000 Received: by mail-il1-x12f.google.com with SMTP id w1so416466ilm.12 for ; Wed, 10 Feb 2021 04:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HigBmlBV3RZRiOszVWuSnT6Fd4+hrnX6h7/9SUMNfCI=; b=vjrrcAn/gLW6Uf+y5O4MOI7IeSvHUGWnNi5/xY3Kxy3AjkPO+LZUSYg1pAvRR0b0u9 dJH4gCQsnJ0/ND8XTnYMu/i8QldSajKl+k2sFtAnsUR1QZZdL29CF0+c8JPUD5T8h0ou P8M/8//OcNuDeU+vo23I1oF7t4I8cRHH1jpKj/Kqc0SGMQObmYu01T59bwIjVw/vqD2O MBMHcnaYb8rHDJ8t6a6PBSBUUHkc18gYQE4UNZy0dxOFY0OPjlPrQpR+dualhzku/GQX QTad8kRRv9L2Hk96lT9R5D7CxBpGHK7SKnWLcWWIAUXfpPkll+/IKIo8B4TXb0hXwUWW vz2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HigBmlBV3RZRiOszVWuSnT6Fd4+hrnX6h7/9SUMNfCI=; b=lpit9JBX1qHbRnmHGPMGdXmvVazHvrMwK/h76woW4BJWmJ2hVifXCeEDTeK1qS7RsH ChQK0fUXiyDp3mHrAsUjPstyOl96ujbF3nkHtWKEILR0mng9I67Yevrwx3jHS02ULQRR Wssut0xyO7M+uKOMmVJz2pMzIggKqYUehghiRms8bS3mn5xcpGy7BW3N0M2syFsAfQ2X nwBJN3pQ2ciHbG/BJ0ht8WbQGhvmGYqkOf2Br1/sZqQlQSFPoVR2zqmOZ4A2SrSBodSl i1VRr8IaG9EQAwK84n11Cx46BYCN2ePfhXDJWqT23u7UrSwbF496c2Mmu7PAWXoOGCpM e+/A== X-Gm-Message-State: AOAM530BQ82YlrPIY36asaQJK9YOz4ZKJ34xkFuNjpaePTDny4miqyvE 29XVvmbPUYNxcPETUWRRJEgULzGNxWKSSFwNMd3t/230TynsRVjN/wfvdhC+TLqnX6Ca4Covarv W5QyNtwEfeSN1+CUPq95+JHIFyZPfm8pwhD9OmcNB05S+jtdRX28UWwnz/NL7uJTPxeOu0Z26n5 3NZ5VO1SAmY2z3gIQxNkVN1MRmm1V8lI0RTRtG63Qrtgz4dq8ryxa00V++kQ== X-Google-Smtp-Source: ABdhPJyN/45bQJGJapJ34fiolHJGo0bbBje/fPy8CD8NxFE4NXFhx0hW6c7ETFKzq84A4Bl1YOiX+Vn2IFYWWBz/pvs= X-Received: by 2002:a05:6e02:1985:: with SMTP id g5mr713798ilf.257.1612959129022; Wed, 10 Feb 2021 04:12:09 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 10 Feb 2021 17:41:58 +0530 Message-ID: Subject: Re: [pgAdmin][RM6207] Update JS dependencies To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000ec51b205bafa4f78" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000ec51b205bafa4f78 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Feb 10, 2021 at 4:37 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > The preview images for the themes are not visible after this. Please find > the attached patch to fix. > > On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Feb 10, 2021 at 1:37 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> The imagemin-gifsicle package is used to compress gif images. The latest >>> version of imagemin-gifsicle requires the binaries to be built from source, >>> which has a big dependency of dh-autoreconf. >>> pgAdmin has very few gifs. Instead of installing dh-autoreconf, I've >>> removed imagemin-gifsicle from package.json since the cost of installing >>> dh-autoreconf is more than the output of compressing gif. >>> Attached is the patch. >>> >>> >>> On Wed, Feb 10, 2021 at 12:51 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Wed, Feb 10, 2021 at 12:08 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> On Tue, Feb 9, 2021 at 4:35 PM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Hi Aditya >>>>>> >>>>>> One jasmine test is failing, please fix that and resend the patch. >>>>>> >>>>> It was failing because of a side effect of some other test case. Fixed. >>>>> >>>>> Please review. >>>>> >>>>>> >>>>>> On Mon, Feb 8, 2021 at 5:07 PM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to update the JS dependencies to latest. >>>>>>> Changes include: >>>>>>> 1) Migrate from webpack 4 to webpack 5. This had a lot of breaking >>>>>>> changes, so updated multiple webpack plugins and changed the config >>>>>>> accordingly. >>>>>>> 2) Replaced iconfont-webpack-plugin with a more maintained >>>>>>> webfonts-loader. >>>>>>> 3) Replaced deprecated babel-eslint with @babel/eslint-parser >>>>>>> 4) Replaced optimize-css-assets-webpack-plugin with a more >>>>>>> maintained css-minimizer-webpack-plugin >>>>>>> 5) Updated all other JS packages and made the required code changes. >>>>>>> >>>>>>> Note, there is an update available for slickgrid and I tried to >>>>>>> update it. But it was not working as expected. So without wasting time, >>>>>>> I've not updated slickgrid, and can be updated as a separate task. >>>>>>> >>>>>>> Please review. >>>>>>> >>>>>>> -- >>>>>>> Thanks, >>>>>>> Aditya Toshniwal >>>>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>>>> >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks, >>>>> Aditya Toshniwal >>>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>>>> >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000ec51b205bafa4f78 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Feb 10, 2021 at 4:37 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi,

The preview images for the= themes are not visible after this. Please find the attached patch to fix.<= /div>

On Wed, Feb 10, 2021 at 1:47 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
=
Thanks, patch applied.

On Wed, Feb 10, 2021 at 1:37 PM Adit= ya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

The imagemin-gifsicle package is used t= o compress gif images. The latest version of imagemin-gifsicle requires the= binaries to be built from source, which has a big dependency of dh-autorec= onf.
pgAdmin has very few gifs. Instead of installing dh-autoreconf, I&#= 39;ve removed imagemin-gifsicle from package.json since the cost of install= ing dh-autoreconf is more than the output of compressing gif.
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Attach= ed is the patch.


On Wed, Feb 10, 2021 at 12:51 PM Akshay Jos= hi <a= kshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.
On Wed, = Feb 10, 2021 at 12:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com= > wrote:
=
Hi,

On Tue, Feb 9, 2021 at 4:35 PM Ak= shay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Aditya
One jasmine test is failing, please fix that and resend the pat= ch.
It was failing because of a side effect of som= e other test case. Fixed.

Please review.=C2=A0

On Mon, Feb 8, 2= 021 at 5:07 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> w= rote:
Hi Hackers,

Attached is the patch to update the JS dependencies to latest.= Changes include:
1) Migrate from webpack 4 to webpack 5. This had a lot= of breaking changes, so updated multiple webpack plugins and changed the c= onfig accordingly.
2) Replaced iconfont-webpack-plugin with a more maint= ained =C2=A0webfonts-loader.
3) =C2=A0Replaced deprecated babel-eslin= t with @babel/eslint-parser
4) =C2=A0Replaced optimize-css-assets-webpac= k-plugin with a more maintained css-minimizer-webpack-plugin
5) Updated = all other JS packages and made the required code changes.

Note, there is an update available for slickgrid and I tried to upda= te it. But it was not working as expected. So without wasting time, I'v= e not updated slickgrid, and can be updated as a separate task.
<= /font>

Please review.

--
<= div dir=3D"ltr">
Thanks,
A= ditya Toshniwal
pgAdmin hacker=C2=A0| <= font size=3D"2" color=3D"#000000" face=3D"arial, sans-serif">Sr. Software E= ngineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin hacker=C2=A0| Sr. Software Engineer | edbpostgres.com
&quo= t;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000ec51b205bafa4f78--