Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQWmY-0006Cy-6g for pgadmin-hackers@arkaria.postgresql.org; Mon, 20 Apr 2020 13:48:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jQWmU-0006m3-Ag for pgadmin-hackers@arkaria.postgresql.org; Mon, 20 Apr 2020 13:48:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jQWmT-0006lL-Rm for pgadmin-hackers@lists.postgresql.org; Mon, 20 Apr 2020 13:48:14 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jQWmQ-0000va-WA for pgadmin-hackers@postgresql.org; Mon, 20 Apr 2020 13:48:12 +0000 Received: by mail-io1-xd43.google.com with SMTP id 19so10939245ioz.10 for ; Mon, 20 Apr 2020 06:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8KWOVSO+aip2ACWYOu8wpE+ezgMaWJcg4g0YXgk9/HQ=; b=hgQsfl4VPDwPdfYJBHFDRbFMlYeTrPMUdMq+SU6UBfvJO/VWxoA2NgytW1ufJUp7iz u/yRzpxQr3pYlQ2fmDwBGF7xdStg/vuIkBl39GY1uTpb2HiMMuCi3gLNClfBi0HsLLRD yheKHiLrZJYPojlSgVS2slE4RgjZrjvbxWbMqRxfUv72VXr2Cr7sdCWH9NF+sT1hvnr9 JGCW1lWQxGf6ej8uUW8ezYAENZyOSmHJdUR75YpNyWjFj/gbUjP/pbpscu5Bg36dRcMh nOBhAHzWRkM4Gb9/gZvhOM+WiVpCvtmaRc8VOz82q/MgJithMlD6xqW0uTHKtFY6AwSt JvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8KWOVSO+aip2ACWYOu8wpE+ezgMaWJcg4g0YXgk9/HQ=; b=DZJQ1AK+4vxYpHqvGtVzbxn5FlQYpeJNmxeO9YSZDxSqWVNrT0A4xzLPgpvJ+GhjCs 8AGV0g72fLSA65fRPUdyVKTHQ7dO8iqFzk6I6AetWN42Jd8qdYIIr1RkVfZyIaK/ooWk eVwrgfVBWXZxidnmZKKUlOQrMaJVjSnMRy8oLyZmnFg7682r472poL02LDZJDgKH9stx 3cr2J+ZTxZygakbsqXV1ZaqUj94qzyQu3yHwjoU3wo9i9LQD4EWSiY+dN07XElgEaHbe xolYTkJE5swtm8U4igtxgAXFf8xmIgR9u0Y+LFGGbDwv7VyL4RKDJftzXbNs3G5MGqck tdxw== X-Gm-Message-State: AGi0PuYxuHqh8+1eGtnnD5umuXLfrVAaek1/7AYm0//vroLvj3EMr62h vtX/bsvV6htcVCmNbiJkf+TdJp/heRY2X/h8Zr31sNLBAB8wbua8pR8yXoDDld12ELARBdj6syZ p2ABFaU4rz/x4Nyns/pcoy5dLW3SysROtpxve42vl6WiSAiZoXz5qSYlOaq9aiIeRTmTeIo9lMr hND07maCEjpyUJVKgO/wBYGlZD9V6TPKVS/LDB+YYHOTySXm+SBDRyPjUuEg== X-Google-Smtp-Source: APiQypIP39ThRb2eJpWs79A240zPFroPfMtdWL/HY8I/6/X1i++2sSufRPGAf3GzdJT2J1XwjUhg3bP2BvHrKnw4MGk= X-Received: by 2002:a02:650f:: with SMTP id u15mr15944820jab.53.1587390490028; Mon, 20 Apr 2020 06:48:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 20 Apr 2020 19:17:59 +0530 Message-ID: Subject: Re: pgAdmin 4 - next gettext usage fixes To: "Libor M." Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000474ae705a3b9261b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000474ae705a3b9261b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, patch applied. On Sun, Apr 19, 2020 at 5:50 PM Libor M. wrote: > Hi, > I sending patch for slightly modified the use of gettext: > - fixed `%` vs. `.format()` > - unified texts and usage `%s` vs. `{}`/`{0}` > - improved text sentences for translate > - added gettext for next texts > > Best regards, > > Libor M. > > E-mail: liborm85@gmail.com > GitHub: https://github.com/liborm85 > > =C4=8Dt 16. 4. 2020 v 9:51 odes=C3=ADlatel Akshay Joshi > napsal: > > > > Thanks, patch applied. > > > > On Wed, Apr 15, 2020 at 5:17 PM Libor M. wrote: > >> > >> Hi, > >> next minor gettext and format fixes in patch. > >> > >> Best regards, > >> > >> Libor M. > >> > >> E-mail: liborm85@gmail.com > >> GitHub: https://github.com/liborm85 > >> > >> st 15. 4. 2020 v 13:17 odes=C3=ADlatel Akshay Joshi > >> napsal: > >> > > >> > Thanks, patch applied. > >> > > >> > On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> >> > >> >> Hi, > >> >> > >> >> Please find the updated patch. > >> >> > >> >> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >>> > >> >>> Hi Aditya > >> >>> > >> >>> I think the fix is incorrect. .format method should be applied > after gettext() like gettext().format(). Please check for other places to= o > and send the updated patch. > >> >>> > >> >>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> >>>> > >> >>>> Hi Hackers/Libor, > >> >>>> > >> >>>> The changes like below are incorrect. Try "Count rows" from a > table's context menu. > >> >>>> > >> >>>> - info=3Dgettext("Table rows counted: %s" % count), > >> >>>> > >> >>>> + info=3Dgettext("Table rows counted: %s") % count, > >> >>>> > >> >>>> > >> >>>> Attached is the patch to fix all such changes in pgAdmin, to use > format() instead. > >> >>>> Please review. > >> >>>> > >> >>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> >>>>> > >> >>>>> Hi Libor > >> >>>>> > >> >>>>> Thanks, patch applied. Please make sure to run the PEP8 checks > before sending the patch. > >> >>>>> I have fixed and committed the code. > >> >>>>> > >> >>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. > wrote: > >> >>>>>> > >> >>>>>> Hello, > >> >>>>>> I fixed next gettext usage: > >> >>>>>> > >> >>>>>> - fixed gettext usage with .format() only for original text wit= h > %s > >> >>>>>> - fixed typos > >> >>>>>> - fixed translation yes/no buttons in dialog > >> >>>>>> - improved translating sentences without "connecting" words (eg= . > see > >> >>>>>> web/pgadmin/dashboard/static/js/dashboard.js, word 'cancel' > needs to > >> >>>>>> be translated in Czech language as 'zru=C5=A1it' but in another > sentence as > >> >>>>>> 'zru=C5=A1en=C3=AD') > >> >>>>>> - added gettext for text translations > >> >>>>>> > >> >>>>>> Diff file is attached. > >> >>>>>> > >> >>>>>> Best regards, > >> >>>>>> > >> >>>>>> Libor M. > >> >>>>>> > >> >>>>>> E-mail: liborm85@gmail.com > >> >>>>>> GitHub: https://github.com/liborm85 > >> >>>>> > >> >>>>> > >> >>>>> > >> >>>>> -- > >> >>>>> Thanks & Regards > >> >>>>> Akshay Joshi > >> >>>>> Sr. Software Architect > >> >>>>> EnterpriseDB Software India Private Limited > >> >>>>> Mobile: +91 976-788-8246 > >> >>>> > >> >>>> > >> >>>> > >> >>>> -- > >> >>>> Thanks and Regards, > >> >>>> Aditya Toshniwal > >> >>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pun= e > >> >>>> "Don't Complain about Heat, Plant a TREE" > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> Thanks & Regards > >> >>> Akshay Joshi > >> >>> Sr. Software Architect > >> >>> EnterpriseDB Software India Private Limited > >> >>> Mobile: +91 976-788-8246 > >> >> > >> >> > >> >> > >> >> -- > >> >> Thanks and Regards, > >> >> Aditya Toshniwal > >> >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > >> >> "Don't Complain about Heat, Plant a TREE" > >> > > >> > > >> > > >> > -- > >> > Thanks & Regards > >> > Akshay Joshi > >> > Sr. Software Architect > >> > EnterpriseDB Software India Private Limited > >> > Mobile: +91 976-788-8246 > > > > > > > > -- > > Thanks & Regards > > Akshay Joshi > > Sr. Software Architect > > EnterpriseDB Software India Private Limited > > Mobile: +91 976-788-8246 > --=20 *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000474ae705a3b9261b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Sun, Apr 19, 2020 at 5:50 PM = Libor M. <liborm85@gmail.com&g= t; wrote:
Hi, I sending patch for slightly modified the use of gettext:
- fixed `%` vs. `.format()`
- unified texts and usage `%s` vs. `{}`/`{0}`
- improved text sentences for translate
- added gettext for next texts

Best regards,

Libor M.

E-mail: liborm85@gm= ail.com
GitHub: https://github.com/liborm85

=C4=8Dt 16. 4. 2020 v 9:51 odes=C3=ADlatel Akshay Joshi
<aksh= ay.joshi@enterprisedb.com> napsal:
>
> Thanks, patch applied.
>
> On Wed, Apr 15, 2020 at 5:17 PM Libor M. <liborm85@gmail.com> wrote:
>>
>> Hi,
>> next minor gettext and format fixes in patch.
>>
>> Best regards,
>>
>> Libor M.
>>
>> E-mail: li= borm85@gmail.com
>> GitHub: https://github.com/liborm85
>>
>> st 15. 4. 2020 v 13:17 odes=C3=ADlatel Akshay Joshi
>> <akshay.joshi@enterprisedb.com> napsal:
>> >
>> > Thanks, patch applied.
>> >
>> > On Wed, Apr 15, 2020 at 2:55 PM Aditya Toshniwal <aditya.tosh= niwal@enterprisedb.com> wrote:
>> >>
>> >> Hi,
>> >>
>> >> Please find the updated patch.
>> >>
>> >> On Wed, Apr 15, 2020 at 1:33 PM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
>> >>>
>> >>> Hi Aditya
>> >>>
>> >>> I think the fix is incorrect. .format method should b= e applied after gettext() like gettext().format(). Please check for other p= laces too and send the updated patch.
>> >>>
>> >>> On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
>> >>>>
>> >>>> Hi Hackers/Libor,
>> >>>>
>> >>>> The changes like below are incorrect. Try "C= ount rows" from a table's context menu.
>> >>>>
>> >>>> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 info= =3Dgettext("Table rows counted: %s" % count),
>> >>>>
>> >>>> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 info= =3Dgettext("Table rows counted: %s") % count,
>> >>>>
>> >>>>
>> >>>> Attached is the patch to fix all such changes in = pgAdmin, to use format() instead.
>> >>>> Please review.
>> >>>>
>> >>>> On Fri, Apr 10, 2020 at 2:57 PM Akshay Joshi <= akshay.j= oshi@enterprisedb.com> wrote:
>> >>>>>
>> >>>>> Hi Libor
>> >>>>>
>> >>>>> Thanks, patch applied. Please make sure to ru= n the PEP8 checks before sending the patch.
>> >>>>> I have fixed and committed the code.
>> >>>>>
>> >>>>> On Wed, Apr 8, 2020 at 9:30 PM Libor M. <<= a href=3D"mailto:liborm85@gmail.com" target=3D"_blank">liborm85@gmail.com> wrote:
>> >>>>>>
>> >>>>>> Hello,
>> >>>>>> I fixed next gettext usage:
>> >>>>>>
>> >>>>>> - fixed gettext usage with .format() only= for original text with %s
>> >>>>>> - fixed typos
>> >>>>>> - fixed translation yes/no buttons in dia= log
>> >>>>>> - improved translating sentences without = "connecting" words (eg. see
>> >>>>>> web/pgadmin/dashboard/static/js/dashboard= .js, word 'cancel' needs to
>> >>>>>> be translated in Czech language as 'z= ru=C5=A1it' but in another sentence as
>> >>>>>> 'zru=C5=A1en=C3=AD')
>> >>>>>> - added gettext for text translations
>> >>>>>>
>> >>>>>> Diff file is attached.
>> >>>>>>
>> >>>>>> Best regards,
>> >>>>>>
>> >>>>>> Libor M.
>> >>>>>>
>> >>>>>> E-mail: liborm85@gmail.com
>> >>>>>> GitHub: https://github.com/liborm85=
>> >>>>>
>> >>>>>
>> >>>>>
>> >>>>> --
>> >>>>> Thanks & Regards
>> >>>>> Akshay Joshi
>> >>>>> Sr. Software Architect
>> >>>>> EnterpriseDB Software India Private Limited >> >>>>> Mobile: +91 976-788-8246
>> >>>>
>> >>>>
>> >>>>
>> >>>> --
>> >>>> Thanks and Regards,
>> >>>> Aditya Toshniwal
>> >>>> pgAdmin Hacker | Sr. Software Engineer | Enterpri= seDB India | Pune
>> >>>> "Don't Complain about Heat, Plant a TREE= "
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Thanks & Regards
>> >>> Akshay Joshi
>> >>> Sr. Software Architect
>> >>> EnterpriseDB Software India Private Limited
>> >>> Mobile: +91 976-788-8246
>> >>
>> >>
>> >>
>> >> --
>> >> Thanks and Regards,
>> >> Aditya Toshniwal
>> >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB Ind= ia | Pune
>> >> "Don't Complain about Heat, Plant a TREE" >> >
>> >
>> >
>> > --
>> > Thanks & Regards
>> > Akshay Joshi
>> > Sr. Software Architect
>> > EnterpriseDB Software India Private Limited
>> > Mobile: +91 976-788-8246
>
>
>
> --
> Thanks & Regards
> Akshay Joshi
> Sr. Software Architect
> EnterpriseDB Software India Private Limited
> Mobile: +91 976-788-8246


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000474ae705a3b9261b--