Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltm4-0008Gu-MC for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 10:59:20 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gltm3-0007vK-Az for pgadmin-hackers@arkaria.postgresql.org; Tue, 22 Jan 2019 10:59:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltm3-0007v7-5S for pgadmin-hackers@lists.postgresql.org; Tue, 22 Jan 2019 10:59:19 +0000 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gltm0-0002eL-8J for pgadmin-hackers@postgresql.org; Tue, 22 Jan 2019 10:59:18 +0000 Received: by mail-qt1-x82a.google.com with SMTP id r14so27121793qtp.1 for ; Tue, 22 Jan 2019 02:59:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7jtvGs6NkqPI1nqQugTCwh1iK6ArAYFmEAH/KVjmW4Y=; b=SRHMhskyNlsTdmoa2k3OSRsR5cOPXe0gLvMuyKnRf8JD48j4Clg6YeehghiT1LUdbH P+4kj6cu0yPyOcpI5c10z/yYKS9yIGnu5+D8j7f5PxeJdu25Z8MGjmGZkzc/+SqOKEYr kdop/GOiDUm+zH+cjTQ3hqO69hLg/4GSjXPZebIDcw+GICXsWuwJr/WL58GYSopBMnxd MdR6T34A4P379sGFjFRTWyHTAMtF5fOlFaODPlX6Lfl65Ifgi4BJ6rpQg1aAQCFSgRHf gsaFNJ0kFxXnpv9M0NYCd84+jap21LMYtaS4NCrnrSsa27RyJHXXhdwZfPRzoVqdNpGJ VwjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7jtvGs6NkqPI1nqQugTCwh1iK6ArAYFmEAH/KVjmW4Y=; b=Pzy8yAOaXU5t69ENPB7JZ1GR+GqtOF+K8uT9jybQmOer4l5BELqYPFmonJP9s7Tt7i DXTz5sm+6zwzRac36rsd8PzsHzpFAYVBdxinfnvBPQVgqa7ROT6k6qQ5Rm4zg7EO9NFr NIYWk88rtuiNhDS49xVrcxWb9mWRdV3SDvmF0WXRi0faXVIAoa04au4lBK2TAFAi11C6 hvL+dOq2oeJUp76Dz0REG3Tw5g99uVcVaWpQDIxMH9Um76a7uchhKK2DIrG1f6DtsMe5 nUsD2Rfbo6X8IS2/s7ZL2MnowPqNfhVfhkJyWm8qLfyUhxXCTX4XRi7KrrW+UPGf0GOI 5k/Q== X-Gm-Message-State: AJcUukcSgFJZcbuwKv36zZOj7/CJk394ya9zboVE+epatEmlhcnvyq7e 90P0ZTWiISYvVDIbfkc4bbSXhklRyYUwCjISxwWJjA== X-Google-Smtp-Source: ALg8bN6lTxvqxdHvcNsdcP0tRqJ2cceibfxImYtw5gEYJV33s+5mzPgvkmvTBues6GEOZgyKTIJsrGy5ghIBjCZZRFU= X-Received: by 2002:a0c:981b:: with SMTP id c27mr29997893qvd.184.1548154754411; Tue, 22 Jan 2019 02:59:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 22 Jan 2019 16:29:03 +0530 Message-ID: Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation To: Harshal Dhumal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000031d072058009deaa" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000031d072058009deaa Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > The patch looks good to me. > > On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Can you please review it. >> >> On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find attached updated patch. >>> In this patch I have fixed two issues: >>> i. Dialog tab navigation should work even if focus is on footer buttons >>> (Save, Cancel, etc..) >>> ii. Focus should be set to first editable element of dialog when tab >>> cycle goes through all editable footer buttons. >>> >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> This patch fixes Dialog tabset keyboard navigation. >>>> This regression was caused due to bootstrap 4 changes. >>>> Also I have added jasmine test cases for the same >>>> >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Sr. Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000031d072058009deaa Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Tue, Jan 22, 2019 at 2:51 PM Khush= boo Vashi <khushboo.v= ashi@enterprisedb.com> wrote:
The patch looks good to me.
On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.josh= i@enterprisedb.com> wrote:
Hi Khushboo=C2=A0

Can= you please review it.

On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal <harshal.dhumal@ente= rprisedb.com> wrote:
Hi,

Please find attached up= dated patch.
In this patch I have fixed two issues:
i. = Dialog tab navigation should work even if focus is on footer buttons (Save,= Cancel, etc..)
ii. Focus should be set to first editable element= of dialog when tab cycle goes through all editable footer buttons.


=
--=C2=A0
Harshal Dhumal
Sr.= Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=


On Th= u, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterprisedb.com= > wrote:
Hi,
This patch fixes=C2=A0Dial= og tabset keyboard navigation.
This regression was caused due to = bootstrap 4 changes.
Also I have added jasmine test cases for the= same


<= div dir=3D"ltr">
--=C2=A0
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India:=C2=A0http://www= .enterprisedb.com
= The Enterprise Post= greSQL Company


--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--00000000000031d072058009deaa--