Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jItKQ-000557-Ug for pgadmin-hackers@arkaria.postgresql.org; Mon, 30 Mar 2020 12:15:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jItKP-00046y-E5 for pgadmin-hackers@arkaria.postgresql.org; Mon, 30 Mar 2020 12:15:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jItKP-00046q-7U for pgadmin-hackers@lists.postgresql.org; Mon, 30 Mar 2020 12:15:41 +0000 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jItKM-0005eK-E4 for pgadmin-hackers@postgresql.org; Mon, 30 Mar 2020 12:15:40 +0000 Received: by mail-il1-x12c.google.com with SMTP id x16so15496014ilp.12 for ; Mon, 30 Mar 2020 05:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fbcisW58EqtxcGM5NezKbE5KLKgbfz5Ssc+fLLT+zHc=; b=Q/Mc79+zlYBpX/vMvOpzKcPJSqRgomDN+EIedBf1Q+Ot3qBVcL5l8aR/ueSV4qJuC+ PpQGmKAt0LWJMw0bBIx1Je6Tg5SjFnBeNNelskImXBm1RXi+vOjLwkLsvYA08fj5m3b2 6iGZ3zDhViiKup5vaGqv7LySYh8IvlJBZKZxHJsVkR6oQJIDSYv0eU7rCuOE0hDbkPb6 jvz6Uk+teVy1Kxe1fIxTqdoD+qIKfTt5B8QO6wAcIRnl9GYngx+yUEwcwgfjJBfPdwVk m+u/m/+gZ7lT9gf3mDCw71s4rJPJcvgrWHndau7Nre+AVO4TK9R/idhwYLzw6DLXikY2 8vew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fbcisW58EqtxcGM5NezKbE5KLKgbfz5Ssc+fLLT+zHc=; b=RLv7xiwVPtBi87x21bSHGHbdDHpz9ttPq75JHk+qP1hXZu497UPZpFEBhKHdNs2T81 ue6zsTjUTbaTXiJQPwfxPuJL+JFMzgU9C2aSPYxzJppI1MDkzTN5J0JupqLIo4yx9Har LZFT4f1G66Nb1dJpmI3AO0ojfFBtSx5zwnPEqKtM06EhQ2o+xKKOB0qsK6zTPnzqU9yT JlbsgqJYh0KPHoMmoIlo1V8tVnbt1YODUH85PJ9uW2idC3v/n9ikypa7XjyEXidb75jV LrFG3W71BPFLuSzj8v/jawFlkkDjkTkOzb52RMaoKVyN1KK1gxsmigr097SSKU1+GEBP uLSA== X-Gm-Message-State: ANhLgQ2k2J9IukzJ5+YyXSGfCNHUaE0a+9+4zjJ5WKQCt6usV3ZqdKXN D/NlBs21R3Ng4iZ3rfHDxg9q9P1mu/hzd3CaC6lJI+yz4CpkUMHhPoYx2cY6RV0KpiYenGQ5tlc 5W2d8oCkwhYOuxdG3x1E7z/jOS0veCVv++jfDfGba3hWgjTUDnZ+GpWmAUaYAqud4b8hKo/JPhQ J8RRTy5JUHuB8myEFgURYIuR+yQTJZUv24UBkfNudZI9jKibog5rk= X-Google-Smtp-Source: ADFU+vtTp8ORp3+ekLvZpYmYQ1EWQ3G35/PgBA6yo5rmz8eQJ2KJzL52wFNjswu/SpRNxbXUMZIOx+omDoBCaJsrrsw= X-Received: by 2002:a92:4986:: with SMTP id k6mr10357323ilg.252.1585570535712; Mon, 30 Mar 2020 05:15:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 30 Mar 2020 17:45:23 +0530 Message-ID: Subject: Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000008c46c305a211681d" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008c46c305a211681d Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Mar 30, 2020 at 5:25 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch. > > On Fri, Mar 27, 2020 at 1:17 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Pradip >> >> Following things are not working, please fix and resend the patch: >> >> Object selection (First) Page: >> >> - If there is no object in the backgrid to select then tab navigation >> not proceed after the headers. >> >> Fixed. > >> >> - Tab navigation not working for 'Select All' checkbox in the >> backgrid cell. >> >> Fixed. > >> Privileges selection (Second) Page: >> >> - Tab navigation not working for the 'Delete' button in the >> backgrid cell. >> >> This logic was added even before my patch(1st Patch). User needs to press > the 'space' key to delete the privilege added. > >> >> On Fri, Mar 27, 2020 at 9:47 AM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch for tab key navigation on grant_wizard. >>> >>> This patch includes: >>> >>> 1. Added code to make tab navigation working in grant_wizard. >>> 2. Added entry for .scss to change the shadow of 'ajs-close' button. >>> >>> This patch also includes the code to allow the user to use the keyboard >>> to update the Backgrid cell DateTime picker control. >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000008c46c305a211681d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Mar 30, 2020 at 5:25 PM Prad= ip Parkale <pradip.pa= rkale@enterprisedb.com> wrote:
Hi Akshay,

=
Please find the attached patch.

On Fri, Mar 27, 2020 at 1:1= 7 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Pradip<= div>
Following things are not working, please fix and resend = the patch:=C2=A0

Object selection (First) Page:
=
  • If there is no object in the backgrid to select then tab navigation= not proceed after the headers.
Fixed.=C2=A0
  • Tab navigation not working for = 9;Select All' checkbox in the backgrid cell.
Fixed.=C2=A0
Privileges selection (Sec= ond) Page:
  • Tab navigation not working for the 'Delete= ' button in the backgrid=C2=A0cell.
This logic was added even before my patch(1st Patch). User = needs to press the 'space' key to delete the privilege added.=C2=A0=

On Fri, Mar 27, 2020 at 9= :47 AM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Attach= ed is a patch for tab key navigation on grant_wizard.=C2=A0

<= /div>
This patch includes:
  1. Added code to make tab nav= igation working in grant_wizard.
  2. Added entry for .scss to chang= e the shadow of =C2=A0'ajs-close' button.
T= his patch also includes the code to allow the user to use the keyboard to u= pdate the Backgrid cell DateTime picker control.


--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corporation
<= /div>


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000008c46c305a211681d--