Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEqZ2-0002Mi-TP for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 08:30:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEqZ1-0006Ye-Om for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 08:30:03 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEqZ1-0006YX-G8 for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 08:30:03 +0000 Received: from mail-il1-x136.google.com ([2607:f8b0:4864:20::136]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEqYy-00057l-Ik for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 08:30:03 +0000 Received: by mail-il1-x136.google.com with SMTP id m9so1394157ilq.12 for ; Thu, 19 Mar 2020 01:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xRyT0ioHBNN/wfNylVZrSZn9woi+nveiGsO10j9Gz0U=; b=NQH2dZ11cgo4wvmKTfr7ABky8SYQXTL++LhWQWNNjMMcRvQ+BbXeYN5rHhAoXeC6u3 2tDyyNy72MyMFwQW8s5qQBDkM97SWf2Cvvfs+mCMfpgr8Kgw2XxBOvIO4wOYfwvelLqL gjrcX0TTZGpt+6xd1Iq8F068Va5Ye0V239rl9ONpJEVayDWYiyHHrAo0NBeXdE+KOK93 8WkeGJEQpCqb42l+9j3DalKwWSLnT7c4aVbteBtqxV5xmlof1s6thoaGC8ECpyNRzfTK P84GT+bAsoG7EtxeXJUnrdWDT7FOjD1LKzMyVSFEh5hbY05R2CHaJLIb2l2aQJKep3I2 gmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xRyT0ioHBNN/wfNylVZrSZn9woi+nveiGsO10j9Gz0U=; b=JBeRH1FmmayEFJX3k2ymsYlVYZcZaT59outMotPZoiDNjAp/ZQeBD6sHFusNyOW65p z2Bq2/fDmXr7jrA7GtH0IWsEBbiWNfMObk2JQttbSksB2fRn/7i6ECIE1LsiPn/PXy2M 0ifcSs74v/IAi90oIwkJ2sVz5UGPF64Aulr62Piu5W/7ti36ZLo/d4VM5/80xggt33dW XV886huHJam3WuVb0dOqdsKKumVQB7IYXi8v+lwhKDIaukkDrZSoajOIb8zskpMSLsOb PuuHXIso3ATI5m+B/nbpqLFNAgZdndfGUEAVuisPmBhpFO+dq/AHHXZ3lBn4xbj5TXEB 5Q8g== X-Gm-Message-State: ANhLgQ3JItwGepx3g4H3F5s1BxGeOg39lKrgJUI3L1Sf8JlsZC+R44EB 5vtHAyEq6EZTyLbtpXEu/vCXDV2UNsbMoHJVcRIE9FMnhidgdnwb5t+1x1nnk4gPyryxqLQekk8 E0d1ikuBhL1KQieG/DNyKZXfiBtyS47xK3YZGVflZ1maoxN5CFxee0RRKjxlpT6rhReOCi/O0pS nXcysNqLSB8IdOsmB3q9m6VWOrBVUF0LlLsgNjbK7hVAgu2HxZTbI= X-Google-Smtp-Source: ADFU+vsIsyqN8K1vaacOnu33owufmR84eWELWxdyWSOo2Qd2EX7va6tPjDBZ0pGAfo+4DzKEmpnMCjRN/UJkptFeIeo= X-Received: by 2002:a92:4986:: with SMTP id k6mr661284ilg.252.1584606598899; Thu, 19 Mar 2020 01:29:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 19 Mar 2020 13:59:47 +0530 Message-ID: Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors To: Murtuza Zabuawala Cc: Aditya Toshniwal , Chethana Kumar , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006fc13005a130f958" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006fc13005a130f958 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hello, > > PFA updated patch with new colors provided by Chethana, As discussed we > will be using the same primary success color in both theme so we don't have > add new variable. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Murtuza/Chethana, >> >> Irrespective of what color you suggest, there is no need to add new >> variables for switch buttons. It should use success for on and ternary for >> off. >> Having a separate green color for each and every control is absurd. If >> the green changes, it should change for all. >> >> On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < >> chethana.kumar@enterprisedb.com> wrote: >> >>> Let us discuss on a call for better clarity and the conclusion part we >>> can put it on mail. >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >>> murtuza.zabuawala@enterprisedb.com> wrote: >>> >>>> Hi Chethana, >>>> >>>> No it is not, As per current dark theme implementation we have used >>>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>>> for both theme. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>>> chethana.kumar@enterprisedb.com> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> The changes are already incorporated so no worries :) >>>>> >>>>> Thanks, >>>>> >>>>> --- >>>>> Chethana kumar >>>>> >>>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> As per discussion with Chethana, We need to make switch box color >>>>>> change for light and dark theme, Color details provided by Chethana is >>>>>> updated on ticket. >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Chethana Kumar >>>>> Principal UI/UX Designer >>>>> EnterpriseDB Corporation >>>>> >>>>> The Postgres Database Company >>>>> >>>>> P: +91 86981 57146 >>>>> www.enterprisedb.com >>>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000006fc13005a130f958 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Mar 19, 2020 at 12:10 PM Mur= tuza Zabuawala <mu= rtuza.zabuawala@enterprisedb.com> wrote:
Hello,

PFA updated patch with new colors= provided by Chethana, As discussed we will be using the same primary succe= ss=C2=A0color in both theme so we don't have add new variable.


--
Regards,=
= Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com<= br>The Enterprise PostgreSQL Company



On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshni= wal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Murtuza/Chethana,
=

<= /div>
= Irrespective of what color you suggest, there is no need to add new variabl= es for switch buttons. It should use success for on and ternary for off.
Ha= ving a separate green color for each and every control is absurd. If the gr= een changes, it should change for all.

On Wed, Mar 18, 2020 at 2:24 PM= Chethana Kumar <chethana.kumar@enterprisedb.com> wrote:
Let us discus= s on a call for better clarity and the conclusion part we can put it on mai= l.

---
Chethana kumar

On Wed, Mar 18, 202= 0 at 2:12 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> = wrote:
Hi Cheth= ana,

No it is not, As per curren= t dark theme implementation=C2=A0we have used primary color '#1a522b= 9; for switch but the color you suggested is '#43A047' for both theme.


=
<= div dir=3D"ltr">--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://ww= w.enterprisedb.com
The Enterprise PostgreSQL Company



=
On Wed, Ma= r 18, 2020 at 2:06 PM Chethana Kumar <chethana.kumar@enterprisedb.com> = wrote:
Hi Murtuza,

The changes are already incorporate= d so no worries :)

Thanks,

---
Chethana kumar

On Wed, Mar 18, 2020 at 12:43 PM Murtuz= a Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,

As per discussion with Chethana, We need to make switch box color change= for light and dark theme, Color details provided by Chethana is updated on= ticket.
=C2=A0

=
--
Regards,
Murtuza Zabuawala
Enterpri= seDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL = Company

=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000006fc13005a130f958--