Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRrRH-0005Lh-BW for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 05:31:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iRrRG-0005Xr-2s for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Nov 2019 05:31:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRrRF-0005Xk-NN for pgadmin-hackers@lists.postgresql.org; Tue, 05 Nov 2019 05:31:33 +0000 Received: from mail-il1-x143.google.com ([2607:f8b0:4864:20::143]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iRrRB-0004Hc-SG for pgadmin-hackers@postgresql.org; Tue, 05 Nov 2019 05:31:33 +0000 Received: by mail-il1-x143.google.com with SMTP id o18so4892834ils.12 for ; Mon, 04 Nov 2019 21:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=imhKCjST9B/RSjSSdUx/UypzwLY8Q6GGBWWpqFtNZus=; b=kdjjJyqCKN1RbHyQVugZuZ9hBGDEPd3yX+CfoH0Km4i2zItetZccYHY3Z99/9ec0Oq ZhFBwKv1IuHP3isoYzeycFowfryxtDCBfKi3xomv3rCprWASfYMKdyq9D+QwglYH38Cw IBGwXh2X7u8pS6VsmgOC6KhDrP3eJR6lWay7W4HKkLRBtEL01jGDjxxZyo4q1g+eWnm1 BykCGx+OT2wUVM9kClmLqUDLph8FqVuVSk8RRdcqXATvSySKqfIUFOUVi9AzilM3GHgt ljUFPVH4zi2fWLmzmMzgnLrXzATBwoMUOTi0zQalQkCNJqR1e5RwWUsvSgvbJ5shXt5j M6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=imhKCjST9B/RSjSSdUx/UypzwLY8Q6GGBWWpqFtNZus=; b=PPnUHk6lV3YvIPOfuNfYZTnt024nUtipbVdwo6VmXj8ZmXDDOSewQtp8uIeiV/nw75 uwsIbCu2Yx4o1K4D/qjzbr6MZFXU5rcbKcPhRpPiALP2vEDAIdTrnSNoTX1PW6RGkTxv cz8oiZKnAuKBSWV6uC0Ohs4kfZUzzA9fcak4D3jexui1EvbbwCJNtMyia/Fy4ORbXe5t xnREncyNpYc8msHrEpFd4uF1UetLTPIZqk8y4mf4pqjS285ub89QIweMaSy/h6afQXOC OWfcUoUecwmoAsW6/9xzAwRvBpShd6cOk+eFO6ezUMT5M26KHgS19FND2tbT4qVuhnJs RdsA== X-Gm-Message-State: APjAAAVuE7BO6DFdo73EA7/6mpa+nyG1dmqbP8N/mN4tCVNxwrHmpy6c Cqmoa9rOXPCWWZpV9QgyDGIjaR++KkgwcA5D2NinFyUbZLefcVTg7K6Zv9eajpnrVaIVr6pyw5Y 36RQMbSgVD2a8ZDH5ux6VDj3fGB6XhgNqXOeSXSFcBJFI9hk1bPqHTiQygCwUwTLqOm4aTohJBV 9KnvsdBM89vNWYmeI+FaTB2Px+YANFyW8QZIx2nXs1lQqJW+Xy7Ys= X-Google-Smtp-Source: APXvYqw6kL1P9LHfxnEfxqeOlmAL4zfmzmlEk3VU1Wbpy7ckwQ0GNA/CCVAXNyNzPH7S9wSibg0+p3FyxGNzfKb4BGo= X-Received: by 2002:a92:8459:: with SMTP id l86mr32988478ild.236.1572931887396; Mon, 04 Nov 2019 21:31:27 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 5 Nov 2019 11:01:16 +0530 Message-ID: Subject: Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000678ffb059692be36" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000678ffb059692be36 Content-Type: text/plain; charset="UTF-8" Hi Aditya I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch. On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > As discussed, extending the changes to Reset button also. Warning will > appear for Reset button now if opted in preferences and changes are not > saved. > Note that, the preference option is same for Close and Reset button. > > Kindly review. > > On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> >> >> On Wed, Oct 30, 2019 at 3:44 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: >>>> >>>>> Hi >>>>> >>>>> I just found an, umm, embarrassing issue with this. It asks for the >>>>> cancel confirmation even when pressing the OK button :-o >>>>> >>>> Tested all but missed the obvious. Bad miss :/ >>>> Attached is the patch to fix the issue. >>>> >>> >>> Thanks - applied. Should we also warn on Reset? That seems logical to me. >>> >> Can be added. Preference option should be common for both Cancel and >> Reset. Will send an add-on patch for this. >> >>> >>> >>>> >>>>> Can you fix that ASAP please? >>>>> >>>>> On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: >>>>> >>>>>> Thanks, applied. >>>>>> >>>>>> On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < >>>>>> aditya.toshniwal@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Attached is the patch to warn the user before closing an unsaved >>>>>>> properties dialog. >>>>>>> Additionally, I have added a preference option in Browser->Display >>>>>>> where the user can disable this. Default is enabled. >>>>>>> Docs updated. >>>>>>> >>>>>>> Kindly review. >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Sr. Software Engineer | EnterpriseDB India | Pune >>>> "Don't Complain about Heat, Plant a TREE" >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --000000000000678ffb059692be36 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Aditya

I have tested it. Reset = functionality not working when preference setting is set to False. Please f= ix and resend the patch.

On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniw= al <aditya.toshniwa= l@enterprisedb.com> wrote:
Hi Hackers,

As discussed, extending the = changes to Reset button also. Warning will appear for Reset button now if o= pted in preferences and changes are not saved.
Note that, the preference op= tion is same for Close and Reset button.

Kindly review.
On Wed, O= ct 30, 2019 at 6:24 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:


<= div dir=3D"ltr" class=3D"gmail_attr">On Wed, Oct 30, 2019 at 3:44 PM Dave P= age <dpage@pgadmi= n.org> wrote:


Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Pag= e <dpage@pgadmin.= org> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya = Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properti= es dialog.
Additionally,= I have added a preference option in Browser->Display where the=C2=A0use= r can disable this. Default is enabled.
Docs updated.

Kindly review= .

--
Thanks and Regards,
<= span style=3D"background-color:rgb(255,255,255)">Aditya Toshniwal
<= div>Sr. Software Engineer |=C2= =A0EnterpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /font>


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--000000000000678ffb059692be36--