Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1UrM-0004Nd-8T for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 10:32:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f1UrJ-0005u4-WF for pgadmin-hackers@arkaria.postgresql.org; Thu, 29 Mar 2018 10:32:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f1UrJ-0005tt-AN for pgadmin-hackers@lists.postgresql.org; Thu, 29 Mar 2018 10:32:41 +0000 Received: from mail-qt0-x22a.google.com ([2607:f8b0:400d:c0d::22a]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f1UrF-0001Sr-VO for pgadmin-hackers@postgresql.org; Thu, 29 Mar 2018 10:32:39 +0000 Received: by mail-qt0-x22a.google.com with SMTP id f8so5675276qtg.12 for ; Thu, 29 Mar 2018 03:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BQaYr07IPyUDG0TsEkDrFyAsYJMoNOyEy9X2oL5X9G4=; b=sAApf1RMbwz5IySZ8wnTiASaBcj71J/zmx+kbrwUAiGnfdzRmEVBYvv8/5dNGDAi4E qEqG0TpWyxndohUe6O2RagQ4Ez2DCy987qelFTzzztpS8NGajPZtrUkrhxdpotUGqMYj uetBKIj0l3mKeO6X9XkfmN4tnD3DIz6aP3vWH3AleWXzSWfwi/iIIzCfWbAYBIJN7w2W gxK1C3YZzRSGr10ODa7UaeXy7cMoTDPridy5NyFVks8FVe+L358P5mEXjkPZyE+3raXm li99HjFZEhIxi7Dy+GcVOSXfbf6nbS2kq4P4c5PW4skBPLBzdl6AAgtGFIYIMwRcQhDu NzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BQaYr07IPyUDG0TsEkDrFyAsYJMoNOyEy9X2oL5X9G4=; b=aEy62548G2RNjOPxaG+1usynf71cAwjpKZGzuMe7g/cQbW5yC29eyAiNGJ3tOchdDo NQbLef0KxNf9twAwCXreqUkIXBHS42UsxRbMiXanMUnEE9xYAapGeqXMq63Swy60VqgO uxMhPFXGAlaRnXJaRMLGaZ31UxImeZOf2gSy5pM45wU3medoVL65krR9ys/Rv5qp+wa6 c74oxTWPDZWoOA8B/dgCPi/ZzwFIGZXrSIUA69eg4JdEFwBXvimky2CL23AONFcklOps Fkpl+gCQ3aXjMHhbh2rINLSRV3ANjfwwkeklPgkjDhHxjBr/DDf4wM/UXjzYGU2gC/rl PDsg== X-Gm-Message-State: AElRT7GD+6N6Ry4VSc21pIBrUguIHl+vt1Lig7dJzumbosasXYU6MfAd m9tKt1io/J1aK9Y+5Hezztozy+qjfL3EeeXbHPw2mQ== X-Google-Smtp-Source: AIpwx4+UUgBLdYSPZ5G3GL2M+vQApx6XmKyGmfa+au6GsR4BwpOdrIERe0P3mN3sS8bKepoJqQRnSZA7AWAbZUkRP/Q= X-Received: by 10.237.47.165 with SMTP id m34mr10850980qtd.178.1522319556368; Thu, 29 Mar 2018 03:32:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.182.1 with HTTP; Thu, 29 Mar 2018 03:32:35 -0700 (PDT) In-Reply-To: References: From: Akshay Joshi Date: Thu, 29 Mar 2018 16:02:35 +0530 Message-ID: Subject: Re: Bug #3083 fix To: Joao De Almeida Pereira Cc: Neethu Mariya Joy , pgadmin-hackers Content-Type: multipart/alternative; boundary="94eb2c12522464757d05688aa46f" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c12522464757d05688aa46f Content-Type: text/plain; charset="UTF-8" Thanks Joao. On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Hey Akshay and Neethu > > We refactored the patch to add tests for the resize feature. We were able > to write test cases for the drag event by using spies and setting the rect > dimensions. In cases like this, we can just test some components in order > to have enough confidence in the code. So we isolated the function that > implements the behavior of this feature and tested that it was performing > as expected. > > We ran the patch through the pipelines and all of the tests passed. > > Sincerely, > > Joao and Victoria > > On Wed, Mar 28, 2018 at 8:03 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi >> >> On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira < >> jdealmeidapereira@pivotal.io> wrote: >> >>> Hello Neethu, >>> We passed the patch through our CI pipeline and all tests pass. >>> The code looks good, but we are trying to decouple files as much as we >>> can so that we do not end up with files with over 1000 lines, that are hard >>> to read and to maintain. Also we are trying to create Unit Tests to have >>> more coverage in our Javascript code. >>> >>> Can you split the new implementation code into it's own file and create >>> some tests to ensure the behavior will not be broken in the future?iYou >>> have some examples on: pgadmin/browser/server_groups/servers/databases/ >>> external_tables/* >>> >> >> I have spilt the new implementation into different file. Its' been >> hard to write jasmine/feature test case as it requires drag event and exact >> co-ordinate to resize the slickgrid cell. >> Attached is the modified patch. >> >> >>> >>> Thanks >>> Joao >>> >>> On Thu, Mar 1, 2018 at 10:37 AM Neethu Mariya Joy < >>> neethumariyajoy@gmail.com> wrote: >>> >>>> Hi, >>>> I am Neethu Mariya Joy, an undergraduate pursuing BE in Computer >>>> Science at BITS Pilani. >>>> >>>> I've attempted to fix https://redmine.postgresql.org/issues/3083. >>>> Since the textarea resize feature is the default HTML feature, I have not >>>> changed it. Instead, I've added draggable borders to the wrapper which >>>> expands the textarea inside it. >>>> >>>> I'm attaching my patch as bug3083.diff below as per the contribution >>>> guidelines. >>>> >>>> Hope this helps. Thank you for your consideration! >>>> >>>> Sincerely, >>>> Neethu Mariya Joy >>>> GitHub | Linkedin >>>> >>>> >>>> >>>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 >> <+91%2097678%2088246>* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --94eb2c12522464757d05688aa46f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks Joao.

On Wed, Mar 28, 2018 at 11:36 PM, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hey Akshay and Neethu

We refactored the patch to add tests for the resize feature.=C2=A0 We were= able to write test cases for the drag event by using spies and setting the= rect dimensions.=C2=A0 In cases like this, we can just test some component= s in order to have enough confidence in the code.=C2=A0 So we isolated the = function that implements the behavior of this feature and tested that it wa= s performing as expected.

We ran the patch through= the pipelines and all of the tests passed.

Sincer= ely,

Joao and Victoria

On Wed, Mar 28, 2018 at 8:= 03 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex">
Hi

On Fri, Mar 2, 2018 at 3:40 A= M, Joao De Almeida Pereira <jdealmeidapereira@pivotal.io>= ; wrote:
Hello Ne= ethu,
We passed the patch through our CI pipeline and all tests pass.
The code looks good, but we are trying to decouple files as much= =C2=A0 as we can so that we do not end up with files with over 1000 lines, = that are hard to read and to maintain. Also we are trying to create Unit Te= sts to have more coverage in our Javascript code.

= Can you split the new implementation code into it's own file and create= some tests to ensure the behavior will not be broken in the future?iYou ha= ve some examples on:=C2=A0pgadmin/browser/server_groups/servers/databa= ses/external_tables/*

=C2=A0 =C2=A0 I have spilt the new implementation into different = file. Its' been hard to write jasmine/feature test case as it requires = drag event and exact co-ordinate to resize the slickgrid cell.
= =C2=A0 =C2=A0 Attached is the modified patch.=C2=A0=C2=A0
=



--
Akshay Joshi
<= div>Sr. Software Arch= itect

=




--
Akshay Joshi
Sr. Software Architect
=

<= /font>

Phone: +91 20-3058-9517
Mob= ile: +91 976-788-8246
--94eb2c12522464757d05688aa46f--