public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5038] Select2 enhancement - Load items on demand (scroll)
Date: Mon, 6 Jan 2020 11:40:16 +0530
Message-ID: <CANxoLDc=E7J36XsNh3dzuU3ct_5YWsw595DakXrv37+Sxo6DZw@mail.gmail.com> (raw)
In-Reply-To: <CAM9w-_nU8m_LbFaCvLzYnrepM+Y1RGbAT8xQaMucWxm=3cuaNg@mail.gmail.com>
References: <CAM9w-_nEN_PK4Mn+9hyLz-ZC2MGp1XGDjx-1L0J=TCQOOUfxBQ@mail.gmail.com>
<CANxoLDcumo3DLJbVuz_dFXFdStS+AtPqUdCZA_kJ9=6K8qBZfg@mail.gmail.com>
<CAM9w-_nU8m_LbFaCvLzYnrepM+Y1RGbAT8xQaMucWxm=3cuaNg@mail.gmail.com>
Hi Aditya
Got below error in while opening Language dialog. Please fix it.
[image: Screenshot 2020-01-06 at 11.37.49 AM.png]
On Fri, Jan 3, 2020 at 3:13 PM Aditya Toshniwal <
[email protected]> wrote:
> Hi Hackers,
>
> The previous patch broke the tags and tokenizer options of select2. Turned
> out, with the change of data adapter we also need to configure adapters for
> tags, tokenizer and others.
> Attached is the patch to set those to the default available in select2.
> I've also renamed onDemandLoad to showOnScroll to avoid confusion as we
> are showing the already present data on scroll and not loading the data on
> demand from ajax.
>
> Kindly review.
>
> On Wed, Jan 1, 2020 at 11:25 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Dec 24, 2019 at 1:01 PM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the patch to enhance select2 used in pgAdmin. The select2
>>> dropdown will show only a few items when opened initially. On scrolling it
>>> will show others. Searching will work as before. This will reduce the
>>> number of DOM nodes on page.
>>> Note that, individual controls can disable the behaviour if desired by
>>> passing onDemandLoad:false for select2 options. It is enabled by default.
>>>
>>> Kindly review.
>>>
>>> --
>>> Thanks and Regards,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
--
*Thanks & Regards*
*Akshay Joshi*
*Sr. Software Architect*
*EnterpriseDB Software India Private Limited*
*Mobile: +91 976-788-8246*
Attachments:
[image/png] Screenshot 2020-01-06 at 11.37.49 AM.png (169.9K, 3-Screenshot%202020-01-06%20at%2011.37.49%20AM.png)
download | view image
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5038] Select2 enhancement - Load items on demand (scroll)
In-Reply-To: <CANxoLDc=E7J36XsNh3dzuU3ct_5YWsw595DakXrv37+Sxo6DZw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox