Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1CYZ-0000rT-5S for pgadmin-hackers@arkaria.postgresql.org; Fri, 13 May 2016 12:51:03 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b1CYX-000485-TI for pgadmin-hackers@arkaria.postgresql.org; Fri, 13 May 2016 12:51:01 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b1CYK-0003sm-Eh for pgadmin-hackers@postgresql.org; Fri, 13 May 2016 12:50:48 +0000 Received: from mail-oi0-x231.google.com ([2607:f8b0:4003:c06::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b1CYH-0002hO-7I for pgadmin-hackers@postgresql.org; Fri, 13 May 2016 12:50:47 +0000 Received: by mail-oi0-x231.google.com with SMTP id v145so168275926oie.0 for ; Fri, 13 May 2016 05:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=3vfwy7A8SsHjHFsOhQ7zT3Dy0iDdlIwhQg4i7K0J52s=; b=t42p7YJQ8ro+hNJBJ3f9jFwwX4Smj67Kxn6knbUXZOn4+hVDzUq+mUEgB81NT8bhMV EHpnzMdNIu3vjnjP17cnwuP1R1C3drRD1AYv6zxBMnwbjDU2LCV6gPc8xS+wbGoKuPod bACj3JSuvsZGAnlPrgBdrGhxlxxEgLe/YVUk2FhvgyWAr4nv8azk9rVJ8G6RUB1gNkAq +yQZ/t/DKNAzgv1IgC57O7BHX1gEINI6idNsXWWdJXSAtsgDFG4mGu6tPuEhXcDpkL2m ze8tk2gdNvUz4MxCrtpkQnajA1pgasJMA0C5acyralBssvaMcPfSN8FO6j3uu3tlxJ8W yQAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=3vfwy7A8SsHjHFsOhQ7zT3Dy0iDdlIwhQg4i7K0J52s=; b=SMezQWV7cjOvMjYvGdCgLgEfBKG9PcOT3Pfup2TYx+0C7nYdDS2Ge01Ccvpt9hpTOQ 6yljDTgOmKd/gtALQ0AIx/EscfCt2BxrBHqBMhNpsqAUPWhN+QxFpZpL6gxMPPUTC3P2 kd+GylYwdEXcN2nJlTfZF6KMvR80nlsJMFE61EWANp4ED/X+7F4U8jB7hGX/i4BmlJYI hj64CdVwMUMWiETwCZNb09huGGG2Y+eqkdkpK20yicG9b+sn/LnALO28FlwNfW0QJIR5 iBuXtAEB4BnaxeqezeyAlNUFTYVblsItsovbA+uU9Q/+UNx2gV6O7PSTsO99kzWHvKq8 +A3g== X-Gm-Message-State: AOPr4FU4TRj7Zw5a1WlmZ6vXoXt6yet1MwpC3z0yWWVYVbW/MDVSG2/I8znXgh4zPIVy5Qy4sudSzm8WBDJFh6kY MIME-Version: 1.0 X-Received: by 10.202.51.130 with SMTP id z124mr7918111oiz.27.1463143843668; Fri, 13 May 2016 05:50:43 -0700 (PDT) Received: by 10.202.175.148 with HTTP; Fri, 13 May 2016 05:50:43 -0700 (PDT) In-Reply-To: References: Date: Fri, 13 May 2016 18:20:43 +0530 Message-ID: Subject: Re: PATCH: FTS configuration node From: Akshay Joshi To: Sanket Mehta Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113cd14a0ee5fd0532b8b94d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113cd14a0ee5fd0532b8b94d Content-Type: text/plain; charset=UTF-8 Hi Sanket Below are my review comments: - Add button should be disabled in Tokens tab while creating. - Unable to click on down arrow for token select control. - Title should be change from "Create FTS-dictionaries" to "Create FTS -Configuration". - Tree node is not getting refreshed on name change. - Unable to rename FTS Configuration when name contains any capital letter. - If user tries to add already existing token then respective row in the backgrid should be highlighted. - "URL not found" when click on SQL help icon from the properties dialog. - SQL should not be generated when remove and add the same token again. Currently it is creating two sql's one for remove and another is for add. - *Fix for the above issue is*: - Add "keys: ['token']," to TokenModel in your js file. On Fri, May 13, 2016 at 2:58 PM, Sanket Mehta wrote: > Hi All, > > Last patch for FTS configuration does not contain node.ui.js file > Kindly ignore it. > > Here is the new revised patch attached with this mail. > Please do review it and let me know if any changes required > > Regards, > Sanket Mehta > Sr Software engineer > Enterprisedb > > On Thu, May 12, 2016 at 4:38 PM, Sanket Mehta < > sanket.mehta@enterprisedb.com> wrote: > >> Hi, >> >> PFA the revised patch. >> Please do review it and let me know if anything is not proper. >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Thu, May 5, 2016 at 8:19 PM, Harshal Dhumal < >> harshal.dhumal@enterprisedb.com> wrote: >> >>> + patch link >>> >>> >>> http://www.postgresql.org/message-id/CAFiP3vwkka+=1FOJ7kr2zbC4AzecoCa9eO9DZ34-Oyy_9gE92g@mail.gmail.com >>> >>> -- >>> *Harshal Dhumal* >>> *Software Engineer * >>> >>> >>> >>> EenterpriseDB >>> >>> On Thu, May 5, 2016 at 8:18 PM, Sanket Mehta < >>> sanket.mehta@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA first patch for FTS configuration node. >>>> >>>> It depends upon backgrid select2cell multi select control, for which >>>> Harshal has sent the patch recently. >>>> Please do apply his patch first and then apply this patch. >>>> >>>> Please do review it and let me know if any changes are required. >>>> >>>> >>>> Regards, >>>> Sanket Mehta >>>> Sr Software engineer >>>> Enterprisedb >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --001a113cd14a0ee5fd0532b8b94d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sanket<= /span>=C2=A0

Below are my review comments:
  • Add button should be disabled in Tokens tab while creat= ing.
  • Unable to click on down arrow for token select control.=C2= =A0
  • Title should be change from "Create FTS-dictionaries" to "Create= FTS-Configuration&q= uot;.
  • Tree node is not getting refreshed on name change.
  • Unable to rename FTS<= /span> Configuration when name contains any capital letter.
  • If = user tries to add already existing token then respective row in the backgrid should be highligh= ted.
  • "URL not found" when click on SQL help icon from the properties dialog.
  • SQL should not be genera= ted when remove and add the same token again. Currently it is creating two = sql's one for re= move and another is for add.
    • Fix for the above issue is:= - Add "keys: ['token']," to TokenModel in your js file.

On Fri, May 13, 2016 at 2:58 PM= , Sanket Mehta <sanket.mehta@enterprisedb.com> w= rote:
Hi All,

Last patch for FTS configuration does not contain node.ui.js file<= /div>
Kindly ignore it.

Here is the new revise= d patch attached with this mail.
Please do review it and let me k= now if any changes required

Regards,
Sanket Me= hta
Sr Software engineer
Enterprisedb
=

On Thu, May 12= , 2016 at 4:38 PM, Sanket Mehta <sanket.mehta@enterprisedb.com= > wrote:
H= i,

PFA the revised patch.
Please do review it = and let me know if anything is not proper.

Regards,
Sanke= t Mehta
Sr Software engineer
Enterprisedb

On Thu, May 5, 2016 at 8:19= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:

--=C2=A0
Harshal Dhumal
Software Engineer=C2=A0




On Thu, May 5, 2016 at 8:18 PM, Sa= nket Mehta <sanket.mehta@enterprisedb.com> wrote= :
= Hi,

PFA first patch for FTS configuration node.

It depends upon backgrid select2cell multi select control,= for which Harshal has sent the patch recently.
Please do apply h= is patch first and then apply this patch.

Please d= o review it and let me know if any changes are required.


Regards,
Sanket Meh= ta
Sr Software engineer
Enterprisedb
<= /div>


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=




--
Akshay Joshi
Principal Software Engineer=C2= =A0


=
Pho= ne: +91 20-3058-9517
Mobile: +91 976-788-8246
--001a113cd14a0ee5fd0532b8b94d--