Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iShnJ-0008T6-L6 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 13:25:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iShnI-000605-E2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Nov 2019 13:25:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iShnH-0005zy-VP for pgadmin-hackers@lists.postgresql.org; Thu, 07 Nov 2019 13:25:48 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1iShnF-0002c5-9w for pgadmin-hackers@postgresql.org; Thu, 07 Nov 2019 13:25:46 +0000 Received: by mail-io1-xd41.google.com with SMTP id j20so1980815ioo.11 for ; Thu, 07 Nov 2019 05:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pKKeLiyGgCdEJn3RkWPmvqnwQ4xyuqhfHy+bT0Q5aPw=; b=TJELEqn7XaX+7bGsvyp6fpfYHq2y80aRvjitzP8PY5s2X+r9FuYpV47mFDhECkLBMZ ARZGTtyG0WCnsx+9sPR6d+g8zGv81dofneD9UfAPBdm0DChC0gpSnOyKNGol9+a6X3Dv ySwxCcOZVv+EOknKl985mPdqY1O3GE1EFVWRYXAI1bVXIY2qzyPneZMYYw1EzizfOsMw lzUYpFSSvTsldyiqGLi7xbvQe5IHf26LwvEe9BrqtBMSbkpamn6u1kTuMN8fVOMMQtYa VoNQ78YhvYhkWb8rV7Fojk1fe+BAyP+i0x6NxCHJn6cx+KdxIykYJHTflnu9RT49y7O0 Pr7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pKKeLiyGgCdEJn3RkWPmvqnwQ4xyuqhfHy+bT0Q5aPw=; b=KgmHuTIb/oD6NvnoqfCIhtYeb8vQ6ZPgr/aHcoSZflHh0MYc59MBjulwjvABGf4oVV /hbvoxcef64306TuZoigDPmLCUm2nXRsK5/R4fEkYdD5T/IcjAwjwYQIM6bI8Du1X0y1 IBKsyUxYjUL0jkECD7pg3pdi5kxC7Z/i0Fw8dutL7dawYf5Mny4f7YbQHx0lityPBYOf HFoCJQc43GIgTtBDg5nEXGfZMnaBlrH2rxgKJwLoWVbT4Ecj1hoxtYDPDJAny1fV7r5J ShIdLupAbWBSBZW9HKdsoRGM/j7jQlrYXgANYrMOzJgPo9+CS+ghH9Cogc2f0mHxBNVj NG3w== X-Gm-Message-State: APjAAAUYN1I5UgJhPy80KqL+BuxrxAjUeD7HnByYxYlOjeTjl0BPCIhz yBc8DwMD1sQ57Bb8zJPo+hJx641akXcw0VnpwpSsWA6XvqNII0+b+ganSEO+Bk0dNc/EehH8+6l NvTHUho7MI9i/Lh5KDJHx5bJp5uotWPltmJhnO1wZjCsklBSWgug6aX4OaQUlWOld/egZle6ayr VTWnbU28DpdV38DSCFPZAqrzH2w/8zo1wB1d7Yg/kAqkj3b7uMMMY= X-Google-Smtp-Source: APXvYqwlMEun+UNWswGi3Q076kk4kbGeGHfICptET3S5nm9aRs7G4on1cKLVonUI1hC5cPftiLG0cbcJSCPay/Z3aEs= X-Received: by 2002:a5d:9a10:: with SMTP id s16mr3401447iol.121.1573133144531; Thu, 07 Nov 2019 05:25:44 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 7 Nov 2019 18:55:33 +0530 Message-ID: Subject: Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000043b9de0596c19ab8" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000043b9de0596c19ab8 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch with few more changes and corrections. > Kindly review. > > On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to introduce theme options in pgAdmin. >> Changes include: >> 1) New theme option in preferences - Miscellaneous -> Themes. You can >> select the theme from the dropdown. It also has a preview of the theme just >> below the dropdown. Note that, a page refresh is needed to apply changes. >> On saving, a dialog appears to ask for refresh. >> 2) You can create your own theme and submit to hackers. README is updated >> to help you create a theme. Theme will be available only after bundle. >> 3) Correction of SASS variables at few places and few other CSS >> corrections. >> 4) Added iconfont-webpack-plugin, which will convert all the svg >> files(monochrome) used as icons for buttons to font icons. This will allow >> us to change the color of icon by using CSS color property. >> 5) All the .css files will bundle into a separate file now- >> pgadmin.style.css. This will help reduce the size of theme css files as CSS >> in .css files will not change with the change of SASS variables. >> 6) "Dark Beta" theme added as a new theme option. >> >> How theme is built ? >> Webpack config is changed to achieve it. On running yarn run bundle, code >> will read all the directories in web/pgadmin/static/scss/resources which >> will be considered as theme dirs, build a separate css for every theme and >> then create a file named pgadmin.themes.json which will have all the >> information required. >> >> The patch also fixes RM4173, where there some issue with arrow icons in >> browser tree. >> >> Kindly review. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --00000000000043b9de0596c19ab8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Adity= a Toshniwal <aditya= .toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the upd= ated patch with few more changes and corrections.
Kindly review.

On We= d, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.c= om> wrote:
Hi Hackers,

Attached is the patch to introduce theme opt= ions in pgAdmin.
Changes include:
1) New theme option in preferences - Mi= scellaneous -> Themes. You can select the theme from the dropdown. It al= so has a preview of the theme just below the dropdown. Note that, a page re= fresh is needed to apply changes. On saving, a dialog=C2=A0appears to ask f= or refresh.
2) You can create your own theme and submit to hackers. README = is updated to help you create a theme. Theme will be available only after b= undle.
3) Correction of SASS variables at few places and few other CSS corr= ections.
4) Added iconfont-webpack-plugin, which will convert all the svg files(m= onochrome) used as icons for buttons to font icons. This will allow us to c= hange the color of icon by using CSS color property.
5) All the .css files= will bundle into a separate file now- pgadmin.style.css. This will help re= duce the size of theme css files as CSS in .css files will not change with = the change of SASS variables.
6) "Dark Beta" theme added as a ne= w theme option.

How theme is built = ?
Webpack config is changed to achieve it.=C2=A0On running yarn run bundle= , code will read all the directories in=C2=A0web/pgadmin/static/scss/resour= ces which will be considered as theme dirs, build a separate css for every = theme and then create a file named pgadmin.themes.json which will have all = the information required.

The patch also fixes RM4173, where there s= ome issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Ente= rpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Th= anks and Regards,
Aditya = Toshniwal
Sr. Software Engineer |=C2=A0EnterpriseDB India |=C2=A0Pune
"Don't Complain a= bout Heat, Plant a TREE"


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--00000000000043b9de0596c19ab8--