Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmC24-0000Fp-99 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 06:29:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmC22-0000OW-Bm for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Jan 2019 06:29:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmC21-0000OM-UM for pgadmin-hackers@lists.postgresql.org; Wed, 23 Jan 2019 06:29:02 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmC1y-0004Rc-Dq for pgadmin-hackers@postgresql.org; Wed, 23 Jan 2019 06:29:00 +0000 Received: by mail-qk1-x744.google.com with SMTP id q8so581553qke.1 for ; Tue, 22 Jan 2019 22:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VQvSbPV57ZNl3/GYwBwXLs1TZESN4TyWX8y+RNymwSg=; b=EkuSdC4ZY8HuiF2idBisLzxaCPhoHOtA61rXVWm4rmR+rl8qpEZO9xoSitcmrRWemB BHBdK7HqOohswwPg8Sgs9alGkQXi12uF4Y+2p6VCnzEvv4nJGB2k1/0Nujsd1seeoNHb gN8omd7vNfvJuEI9wKsO79YBPn1t0LVORGVIyKFmB2Ar5QXVve81NDxketlr+GB7Mx39 47SeJqi32hpRXCDgRGx3XGCQF2/ZoRt87bC031fWddCVHxF17LG6typ19koEOINjXOot eH40+aRE+Gi7YS/mm7x+N9FBCj6Rhr4n2Au/mhCtAWGkLic2dp2J5PM5Wpk0jb4EaKk0 uYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VQvSbPV57ZNl3/GYwBwXLs1TZESN4TyWX8y+RNymwSg=; b=ABwWLJckZwTICWRPvOHf3kTg8HJW1tjT97MlFybmhJ+lRS+wjr+1pQ5BWxRsJ3KnSp btp3kvmPhOiuqvLmOGMM4vVja5bX5YU7NNWFEz+wpo20MgXcbu9VzqjT0ua/aiHXS4it nRqCXHK2hS2srl/Qczrm3vFRLNdy9xCL3i2tDGaFpgLLCMDiy17hcERQQNaL5+ZI61gq VV8djIeoLaUphvQnJ/ToiXS4tnqUakH7fNwz/OjMVdsJQTX+MjnK1bjkD34Y/c0xRQ5B uVTkRWFvRb9qg6AmZS0+uNpGXKDvIAADpb/p0O75FUz1mex2eK9fxMEdDnmsAPfTiDCA ZYXQ== X-Gm-Message-State: AJcUukf7axPIexf9Qm/U0dvcq9xXB098yXVKapeuH1hhdZHF7FCTj5cN riENO+IATio+nXVU6gY18RGI9dv/0WXaYywk+x3DpA== X-Google-Smtp-Source: ALg8bN6MhsvC5siVD3+LqhnklA7FPetKdgedcEzd42egPQuxeq/6m9SGICSEwfyROmRiT9g0lH1em/2f2yQvwdOKSzc= X-Received: by 2002:a37:d91:: with SMTP id 139mr771376qkn.166.1548224937027; Tue, 22 Jan 2019 22:28:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 23 Jan 2019 11:58:45 +0530 Message-ID: Subject: Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working To: Aditya Toshniwal Cc: Dave Page , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000006778f605801a3567" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000006778f605801a3567 Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Wed, Jan 23, 2019 at 11:32 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > PFA revised patch as per review. > > On Wed, Jan 23, 2019 at 11:20 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Found one issue you have remove the function "*disable_tree_state_save*" from >> "*web/regression/python_test_utils/test_utils.py*" and move that code >> into "*set_preference*" function and it is called from " >> *web/regression/runtests.py*" which is conditional, so please correct >> that behaviour. >> >> On Tue, Jan 22, 2019 at 6:28 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the revised patch. The warning occurrence is configurable >>> from Preferences > Browser > Display. >>> >>> Kindly review. >>> >>> On Tue, Jan 22, 2019 at 5:38 PM Dave Page >>> wrote: >>> >>>> On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal >>>> wrote: >>>> > >>>> > >>>> > >>>> > On Tue, Jan 22, 2019 at 5:27 PM Dave Page >>>> wrote: >>>> >> >>>> >> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal >>>> >> wrote: >>>> >> > >>>> >> > Any suggestions on preferences name/desc ? >>>> >> >>>> >> Name: "Confirm on close" >>>> >> Desc: "Confirm closure of the browser or browser tab is intended >>>> >> before proceeding." >>>> > >>>> > It also warns on refresh. >>>> >>>> Name: "Confirm on close or refresh" >>>> Desc: "Confirm closure or refresh of the browser or browser tab is >>>> intended before proceeding." >>>> >>>> >> >>>> >> >>>> >> >>>> >> > On Tue, Jan 22, 2019 at 3:01 PM Dave Page < >>>> dave.page@enterprisedb.com> wrote: >>>> >> >> >>>> >> >> Hi >>>> >> >> >>>> >> >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi >>>> >> >> wrote: >>>> >> >> > >>>> >> >> > Hi Aditya >>>> >> >> > >>>> >> >> > Below are my review comments: >>>> >> >> > >>>> >> >> > You have added new config parameter >>>> "DISABLE_BEFOREUNLOAD_MESSAGE" to make this request configurable, should it >>>> be the part of preferences setting instead of configuration? @Dave can you >>>> please comment on this. >>>> >> >> >>>> >> >> That does seem like something that should be a per-user >>>> preference, >>>> >> >> not a global config option. >>>> >> >> >>>> >> >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not clear as users >>>> perspective, can you please change it to some meaningful name. >>>> >> >> > >>>> >> >> > Apart from that code looks good to me. >>>> >> >> > >>>> >> >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal < >>>> aditya.toshniwal@enterprisedb.com> wrote: >>>> >> >> >> >>>> >> >> >> Hi Hackers, >>>> >> >> >> >>>> >> >> >> Attached is the patch to throw alert warning when user reloads >>>> or closes the browser. >>>> >> >> >> >>>> >> >> >> Kindly review. >>>> >> >> >> >>>> >> >> >> -- >>>> >> >> >> Thanks and Regards, >>>> >> >> >> Aditya Toshniwal >>>> >> >> >> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> >> >> >> "Don't Complain about Heat, Plant a tree" >>>> >> >> > >>>> >> >> > >>>> >> >> > >>>> >> >> > -- >>>> >> >> > Akshay Joshi >>>> >> >> > Sr. Software Architect >>>> >> >> > >>>> >> >> > >>>> >> >> > Phone: +91 20-3058-9517 >>>> >> >> > Mobile: +91 976-788-8246 >>>> >> >> >>>> >> >> >>>> >> >> >>>> >> >> -- >>>> >> >> Dave Page >>>> >> >> VP, Chief Architect, Tools & Installers >>>> >> >> EnterpriseDB: http://www.enterprisedb.com >>>> >> >> The Enterprise PostgreSQL Company >>>> >> >> >>>> >> >> Blog: http://pgsnake.blogspot.com >>>> >> >> Twitter: @pgsnake >>>> >> > >>>> >> > >>>> >> > >>>> >> > -- >>>> >> > Thanks and Regards, >>>> >> > Aditya Toshniwal >>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>> >> > "Don't Complain about Heat, Plant a tree" >>>> >> >>>> >> >>>> >> >>>> >> -- >>>> >> Dave Page >>>> >> VP, Chief Architect, Tools & Installers >>>> >> EnterpriseDB: http://www.enterprisedb.com >>>> >> The Enterprise PostgreSQL Company >>>> >> >>>> >> Blog: http://pgsnake.blogspot.com >>>> >> Twitter: @pgsnake >>>> > >>>> > >>>> > >>>> > -- >>>> > Thanks and Regards, >>>> > Aditya Toshniwal >>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>> > "Don't Complain about Heat, Plant a tree" >>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> VP, Chief Architect, Tools & Installers >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>> >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Software Engineer | EnterpriseDB Software Solutions | Pune >>> "Don't Complain about Heat, Plant a tree" >>> >> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --0000000000006778f605801a3567 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Wed, Jan 23, 2019 at 11:32 AM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

PFA revised patch = as per review.

On Wed, Jan 23, 2019 at 11:2= 0 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Ad= itya=C2=A0

Found one issue you have remove the function = "disable_tree_state_save"=C2=A0from "web/regressio= n/python_test_utils/test_utils.py" and move that code into "<= b>set_preference" function and it is called from "web/regr= ession/runtests.py" which is conditional, so please correct that b= ehaviour.=C2=A0

On Tue, Jan 22, 2019 at = 6:28 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
=
Hi Ha= ckers,

Attached is the revised patch. The warning occurrence is config= urable from Preferences > Browser > Display.

Kindly review.

On Tue, Jan 22, 2019 at 5:38 PM Dave Page <dave.page@enterprisedb.= com> wrote:
On Tue, Jan 22, 2019 at 12:01 PM Aditya Toshniwal
<= aditya.toshniwal@enterprisedb.com> wrote:
>
>
>
> On Tue, Jan 22, 2019 at 5:27 PM Dave Page <dave.page@enterprisedb.com> = wrote:
>>
>> On Tue, Jan 22, 2019 at 11:54 AM Aditya Toshniwal
>> <aditya.toshniwal@enterprisedb.com> wrote:
>> >
>> > Any suggestions on preferences name/desc ?
>>
>> Name: "Confirm on close"
>> Desc: "Confirm closure of the browser or browser tab is inten= ded
>> before proceeding."
>
> It also warns on refresh.

Name: "Confirm on close or refresh"
Desc: "Confirm closure or refresh of the browser or browser tab is
intended before proceeding."

>>
>>
>>
>> > On Tue, Jan 22, 2019 at 3:01 PM Dave Page <dave.page@enterprisedb.com= > wrote:
>> >>
>> >> Hi
>> >>
>> >> On Tue, Jan 22, 2019 at 6:27 AM Akshay Joshi
>> >> <akshay.joshi@enterprisedb.com> wrote:
>> >> >
>> >> > Hi Aditya
>> >> >
>> >> > Below are my review comments:
>> >> >
>> >> > You have added new config parameter "DISABLE_BE= FOREUNLOAD_MESSAGE" to make this request configurable, should it be th= e part of preferences setting instead of configuration? @Dave can you pleas= e comment on this.
>> >>
>> >> That does seem like something that should be a per-user p= reference,
>> >> not a global config option.
>> >>
>> >> > Name "DISABLE_BEFOREUNLOAD_MESSAGE" is not= clear as users perspective, can you please change it to some meaningful na= me.
>> >> >
>> >> > Apart from that code looks good to me.
>> >> >
>> >> > On Mon, Jan 21, 2019 at 1:24 PM Aditya Toshniwal <= ;adi= tya.toshniwal@enterprisedb.com> wrote:
>> >> >>
>> >> >> Hi Hackers,
>> >> >>
>> >> >> Attached is the patch to throw alert warning whe= n user reloads or closes the browser.
>> >> >>
>> >> >> Kindly review.
>> >> >>
>> >> >> --
>> >> >> Thanks and Regards,
>> >> >> Aditya Toshniwal
>> >> >> Software Engineer | EnterpriseDB Software Soluti= ons | Pune
>> >> >> "Don't Complain about Heat, Plant a tre= e"
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> > Akshay Joshi
>> >> > Sr. Software Architect
>> >> >
>> >> >
>> >> > Phone: +91 20-3058-9517
>> >> > Mobile: +91 976-788-8246
>> >>
>> >>
>> >>
>> >> --
>> >> Dave Page
>> >> VP, Chief Architect, Tools & Installers
>> >> EnterpriseDB: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >
>> >
>> >
>> > --
>> > Thanks and Regards,
>> > Aditya Toshniwal
>> > Software Engineer | EnterpriseDB Software Solutions | Pune >> > "Don't Complain about Heat, Plant a tree"
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> Software Engineer | EnterpriseDB Software Solutions | Pune
> "Don't Complain about Heat, Plant a tree"



--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Solutions |=C2= =A0Pune
"Don't Complain about Heat, Plant a tree"


--
Akshay Joshi
= Sr. Software Architect
=


Phone: +91 20-3058-9517<= br>Mobile: +91 976-788-8246
=


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer |=C2=A0EnterpriseDB Software Sol= utions |=C2=A0Pune
"Don't Complain about Heat, Plant a tr= ee"


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--0000000000006778f605801a3567--