Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBbGi-0000NW-LE for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 10:38:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lBbGh-0002bX-Jz for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 10:38:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBbGh-0002bQ-6N for pgadmin-hackers@lists.postgresql.org; Mon, 15 Feb 2021 10:38:15 +0000 Received: from mail-io1-xd2a.google.com ([2607:f8b0:4864:20::d2a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lBbGd-0004YP-AU for pgadmin-hackers@postgresql.org; Mon, 15 Feb 2021 10:38:14 +0000 Received: by mail-io1-xd2a.google.com with SMTP id u8so6222472ior.13 for ; Mon, 15 Feb 2021 02:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1o0qlRzEOZ/jbVizeCYRbuu3lsACIxhI5uAjzPkKdTs=; b=Pcm0CEX9vwMIz1+OBfNli4EqBDeqphskli52nWexOY2UMoieGCamfCy8jWTbaT9kam DTiELjKMKiYqP3QgmNe4M1gYUGmhxHSnnZ6J5jYoShCddysDystmK0hW1vA7vsdshHOG yXa3QbJfAe76poB52iUw25ogovbk1L2GqWNI5ZrBg2o9M8D65mbyBGPL/BBSkdLRl5sF DaW9Wz40hk3jpzeljaLtQ4Q5LrcqCUx3vz7R6u6J2dnbNMJ8d368YRzpYgRQ1oCgXoSF d7oB6bJCxhl3Oghu+lixfAJ2R9BiBNcUQOKK9ukq9uTEi2mQHS2erZxJ3yZmNagSB1Ij kKnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1o0qlRzEOZ/jbVizeCYRbuu3lsACIxhI5uAjzPkKdTs=; b=I8BpHuohCVX6vUSV/xDAW3FVgBecSEv7RW6biRoHkCVO84oWso9Ike8E22W7OxzY/U uCLgCiYuhTPQjQKsBhAbUNoEPjGrSqzoNG3ElTvFXRyMcyq4V54b3nI8t/CDZOLC71km clUeNQRumdbG5u+i+CGiERn4I1J2gkhvwjcpFnkrxkyhimcGhrnp9DD403FeURKFyqD8 R3Z67v/4Wr2ibr0Q0vo0qbgmu2ZEu6dcv+/xga3atCvvjxMqV2XRVufmapmP+2+JeRpR /8nzNAXLWScK30idRDpldHXwGYkBcooSxuKVW5sdsqQQqsNL6qxV4st9TL34tB5q2irC i/pA== X-Gm-Message-State: AOAM5330p6mTcoMZscrQ07OKSMa9yulUfHe4Sq+Blgoio2327uQkuvgs T12YlbWQLMGI7axDxINN5nW2J2gF4FyzKvKy9/xNOFiiNqVqlemE7axYKY5qFS4UPshzitzb879 1XjABinCn1Lt0CpAwy0fYWnavVgdo4HtNX8/ASJ6b9mX/1bHBaTuktMYnSEVvTRapiUvPGuMKQ9 D2l/xmr2lMbwWqlvjJQaUekTxcSU8hb9MPPH6jikqoU7hMbcZmU23usfKNKw== X-Google-Smtp-Source: ABdhPJw9z7ikAmA0JEYWb9/qhN8v3SdfiP474ranQ5Y4qh66yJxGlJYnHSs7VNsZN9XzBGIChGdm0YBf5Holoq7S+l4= X-Received: by 2002:a5e:dd09:: with SMTP id t9mr6406768iop.57.1613385490057; Mon, 15 Feb 2021 02:38:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Mon, 15 Feb 2021 16:07:59 +0530 Message-ID: Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000000567eb05bb5d9534" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000000567eb05bb5d9534 Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Pradip >> >> I haven't started reviewing your patch but seems you haven't written test >> cases for schema diff. Please add and then submit the patch again. >> >> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for publication and subscription support >>> in Schema Diff. >>> >>> Also, added the dependencies for publication and subscription. >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000000567eb05bb5d9534 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Mon, Feb 8, 2021 at 3:01 PM Pradi= p Parkale <pradip.par= kale@enterprisedb.com> wrote:
Hi Akshay,

Please = find the updated patch.

On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi = <aksh= ay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Pradip

I haven't started reviewing your patch but seems you haven't writt= en test cases for schema diff. Please add and then submit the patch again.<= /div>

On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale <pradip.parkale@enterprised= b.com> wrote:
Hi Hackers,

Please find the attach= ed patch for publication and subscription support in Schema Diff.

Also, added the dependencies for publication and subscripti= on.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Co= rporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000000567eb05bb5d9534--