Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mCz-0005JL-HQ for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Jul 2021 14:37:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m0mCy-0004uY-EG for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Jul 2021 14:37:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mCy-0004uP-7W for pgadmin-hackers@lists.postgresql.org; Tue, 06 Jul 2021 14:37:56 +0000 Received: from mail-io1-xd34.google.com ([2607:f8b0:4864:20::d34]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m0mCv-0007VQ-PU for pgadmin-hackers@postgresql.org; Tue, 06 Jul 2021 14:37:55 +0000 Received: by mail-io1-xd34.google.com with SMTP id v3so25306959ioq.9 for ; Tue, 06 Jul 2021 07:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Lh0+wf81WZfHbICUbrgNAgn1/rUpZrYDyWKdoA0Irrc=; b=jmNPg6z74eUqmzGqamw3MVl/VowHJQqA4VtoOPBaP7ddyU1QQqw+E/A87C8GbhJWmS 7Q+7LSCKY8Av+9UIGLo88xgJXeEu0Yh/YZ1kwY/NuhV1WOKDUvHdMG2TAGVm5ovnbY6f KIPuKa/LgS8w9B9u3qM/lqy60C5OueyKQUC54VEMUhhLNJVN3zhqv0vmjy3pWU4L+Nkq POK7XLGTSJtuMgM97tbalsxY7N66LMiThzCmXzKAv7iQkXBzMWb+FxEi9+yLpOj2rGdF xQOXF6cMCxDspyZ3JU9/JmxTSQrb8iIX3hGiP9gQpyTWWP8JeuhJATvdCtpLO2NjC/56 VjJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lh0+wf81WZfHbICUbrgNAgn1/rUpZrYDyWKdoA0Irrc=; b=ebI9bIPpsXQUSGGBX3smS+4AGyWKywX0GNB3kooPLSpNbBS0o/lvxb19/ZPzbSUNqt BHGYAUZEXJL258iJe+9/QEHprdLj++4JH2LCFau+X2rNbSQ+SKGwMpFIJMhOeAfMC1Wy 3fp5CoY5J7kGuFNZMFe+4ToJIyr75EmXDEYFB1F4VK9qU4YJWN1Fbzo6aT66YUqTCqoe 4pE69amR9mYQLnU3OHnFp4A3//dSTXHlCSBsLhbZOtP602bfljvp0qHzyhMbwU148uWE axdcB348LeAmYNfR6XMcFduMqREfV3EatUZzqh2wqlwIVBaK3ZFjnlcBRWdh6SHqnWcv oTmg== X-Gm-Message-State: AOAM532LDwDmTvvRfZcDRqD4vqql/gnD4FNvLWRYCKj/ScWWtTlDtDrb cLRHvnjfB3VZBOGQW58jVdiJyViXUuUufzyeHD6NnSj63O2oUO/l1zHPobkw1Cb1nZoCZF+RUXi 9faXCeaRkSIPKGTDvdT9Ba7+8r3as45npgd3UnxR/TAp+RT8IVbGH/weNrKy338yCgKKuzeQ91w obL2Mvfvvr2LdZa4m/kqKM1S8YVivINiNYZrLokCqxWw4yMY6xIhK/ah6JRQ== X-Google-Smtp-Source: ABdhPJzaPxzxs1k85r4af84WX92Z+MNeRtFo2LXB6sFawczRVc3Tx8WBCITNI+cwhHkdLY3Sa47p4WK6Rs/361Nxce8= X-Received: by 2002:a05:6638:1ba:: with SMTP id b26mr3086779jaq.20.1625582272258; Tue, 06 Jul 2021 07:37:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 6 Jul 2021 20:07:41 +0530 Message-ID: Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel. To: Pradip Parkale Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e44f8605c6755d6c" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000e44f8605c6755d6c Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Tue, Jul 6, 2021 at 3:00 PM Pradip Parkale < pradip.parkale@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. > > On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> Please find the updated patch. I have moved the function into the >>> utility file now. >>> >>> On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Pradip >>>> >>>> I have seen that we have duplicated code for resize_the_queryTool, >>>> resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I >>>> would suggest making a common function somewhere in the utils and call that >>>> function. In the future, if we need to change the code we will have to >>>> change it in four different places. >>>> >>>> Please resend the patch after fixing the above issue. >>>> >>>> On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale < >>>> pradip.parkale@enterprisedb.com> wrote: >>>> >>>>> Hi Akshay, >>>>> >>>>> Please find attached for debugger and ERD tool which was missing in >>>>> my previous patch. >>>>> >>>>> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi < >>>>> akshay.joshi@enterprisedb.com> wrote: >>>>> >>>>>> Thanks, the patch applied. >>>>>> >>>>>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < >>>>>> pradip.parkale@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Please find the attached patch for #6398.Detaching query editor >>>>>>> panel gives a blank white panel. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks & Regards, >>>>>>> Pradip Parkale >>>>>>> Software Engineer | EnterpriseDB Corporation >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Thanks & Regards* >>>>>> *Akshay Joshi* >>>>>> *pgAdmin Hacker | Principal Software Architect* >>>>>> *EDB Postgres * >>>>>> >>>>>> *Mobile: +91 976-788-8246* >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Pradip Parkale >>>>> Software Engineer | EnterpriseDB Corporation >>>>> >>>> >>>> >>>> -- >>>> *Thanks & Regards* >>>> *Akshay Joshi* >>>> *pgAdmin Hacker | Principal Software Architect* >>>> *EDB Postgres * >>>> >>>> *Mobile: +91 976-788-8246* >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --000000000000e44f8605c6755d6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Tue, Jul 6, 2021 at 3:00 = PM Pradip Parkale <pr= adip.parkale@enterprisedb.com> wrote:
Hi Akshay,
Please find th= e updated patch.=C2=A0

On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi= <aks= hay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On= Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale <pradip.parkale@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">Hi Akshay,
Please find the updated patch. I have moved = the function into the utility file now.

On Thu, Jun 24, 2021 at 7:56 P= M Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Pradip
I have seen that we have duplicated=C2=A0code for=C2=A0resize_the_queryTool,=C2=A0resize_the_erdtool,=C2=A0resize_the_psql, and in debugger_ui.js file.=C2=A0I woul= d suggest making a common function somewhere in the utils and call that fun= ction. In the future, if we need to change the code we will have to change = it in four different places.

Please resend the= patch after fixing the above issue.

On Thu, Jun 24, 2021 at 7:00 PM P= radip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,
=
Please find=C2=A0attached=C2=A0for debugger and ERD tool whi= ch was missing in my=C2=A0previous patch.

On Wed, Jun 23, 2021 at 11:5= 0 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the pat= ch applied.

On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale <pradip.parkale@ent= erprisedb.com> wrote:
Hi Hackers,

Please find the attached patch for #6398.Detaching query editor panel gi= ves a blank white panel.


--
=
Thanks &a= mp; Regards,
Pradip Parkale
Sof= tware Engineer | EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--000000000000e44f8605c6755d6c--