Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmdVW-0001TH-Ka for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 11:49:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gmdVV-00005d-Eh for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 Jan 2019 11:49:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmdVV-00005T-80 for pgadmin-hackers@lists.postgresql.org; Thu, 24 Jan 2019 11:49:17 +0000 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gmdVR-0003Fh-8Q for pgadmin-hackers@postgresql.org; Thu, 24 Jan 2019 11:49:16 +0000 Received: by mail-qt1-x829.google.com with SMTP id l11so6123207qtp.0 for ; Thu, 24 Jan 2019 03:49:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=urJgFKeNxNNE0XFK27mB1ZYvEO/MswLrOV605AOvaIM=; b=JltbZZQjVWolmj7UnD64qbaBsYXKkofcMMi5axY/5M9pphSCDgdXv3o6FOEU31k/IL 9zAJXTQ1ceUen5RpoFvGEYbIv90yEcxqwqIVrDuQme7TU8pcOy744ZOl6Lgs//JBH03E /z7sCYmX84goo5Apq8sbAeGRDhhq/F2lQFaZa5ckZNmL352yT5l7vSNIH3uTIV7rZeMT nhj+GmxVVUFBiCLNYKS6MCWqPLkQMe9AMVOvTTMB6BWL2KnypmPIWAXMdlikpzO4I/02 5AktKno10pmKLRCiUZFjX0qq2CsHgCWjo0laS83w1J7XvuouD0UWDFHq9zqwsMJ8DwH3 QnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=urJgFKeNxNNE0XFK27mB1ZYvEO/MswLrOV605AOvaIM=; b=DptK5CnfKgIF7jgCjeVQk+l0TtYXS26wwAqPq97vFmN6lR4iQq+apZjlCBYCDWovfb n7rShFsTgmiUzISDjvU8+QCDr+nP7lQGev18y/J476K62Hx8d1JQ5CYrimvdS6eQSVI+ cbMGz9KNyYjLm2pEYt/sTWSPfkwToGKp3njrYvctCX7c2WLp/MjXeeOVqIrikP6782iC ULgTCQ2zzzbXeohb6bifz2cjHkJiTdX3P/BNrtyw26tlXBCSQhzibMdFSe3FPI7cP1Fq bu+XTTNsa17OBmsR1NJq2Cr5czSoWgR3mf2ZPhqthpPfnCwO9kfTksUt3FeCQjH5pdFU 8cfg== X-Gm-Message-State: AJcUukdMbBs8Uxc9MuIw+yEW2a2ZQLAuShmRhWUV8XhfvLurV3uRrdmC bMwodPB6x3H4SK+cxC1/J6hkeTQUsgRjRgxBJ/EldQ== X-Google-Smtp-Source: ALg8bN5XW9THDhxhIbvoDv55Ddv81QRHARf3IKPJJGslOs6fatWxRLuuSIvRVd2ucSJ71Zx3eanzBKTmuXIMpcNe0XY= X-Received: by 2002:a0c:8a29:: with SMTP id 38mr5509557qvt.222.1548330551422; Thu, 24 Jan 2019 03:49:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Thu, 24 Jan 2019 17:19:00 +0530 Message-ID: Subject: Re: [pgAdmin4] [RM3862] Fix Dialog tabset keyboard navigation To: Harshal Dhumal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000083474b058032cc7d" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000083474b058032cc7d Content-Type: text/plain; charset="UTF-8" Thanks patch applied. On Thu, Jan 24, 2019 at 4:19 PM Harshal Dhumal < harshal.dhumal@enterprisedb.com> wrote: > Hi, > > Please find attached patch to fix dialog tab navigation in backup and > restore dialog. > > Note: If first control in dialog is bootstrap switch then tab and dialog > tab navigation do not work. > This is because bootstrap switch captures all keyboard events and it does > not allow them to propagate /bubble up. > As Khushboo is working on new switch control (RM 3051 > ) I haven't fix this issue as > a part of this patch. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> The patch looks good to me. >>> >>> On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi < >>> akshay.joshi@enterprisedb.com> wrote: >>> >>>> Hi Khushboo >>>> >>>> Can you please review it. >>>> >>>> On Wed, Jan 16, 2019 at 12:55 PM Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find attached updated patch. >>>>> In this patch I have fixed two issues: >>>>> i. Dialog tab navigation should work even if focus is on footer >>>>> buttons (Save, Cancel, etc..) >>>>> ii. Focus should be set to first editable element of dialog when tab >>>>> cycle goes through all editable footer buttons. >>>>> >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Sr. Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal < >>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> This patch fixes Dialog tabset keyboard navigation. >>>>>> This regression was caused due to bootstrap 4 changes. >>>>>> Also I have added jasmine test cases for the same >>>>>> >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Sr. Software Engineer* >>>>>> >>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>> >>>> -- >>>> *Akshay Joshi* >>>> >>>> *Sr. Software Architect * >>>> >>>> >>>> >>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* --00000000000083474b058032cc7d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks patch applied.

=
On Thu, Jan 24, 2019 at 4:19 PM Harsh= al Dhumal <harshal.dh= umal@enterprisedb.com> wrote:
Hi,

Please find attached patch to fix dialog tab navigation in backup and re= store dialog.

Note: If first control in dialog is = bootstrap switch then tab and dialog tab navigation do not work.
= This is because bootstrap switch captures all keyboard events and it does n= ot allow them to propagate /bubble up.
As Khushboo is working on = new switch control (RM=C2=A03051) I haven't fix this issue as a part = of this patch.

=
--=C2=A0
Hars= hal Dhumal
Sr. Software Engineer

=
Enterpri= seDB India:=C2=A0http://www.enterpri= sedb.com
The Enterprise PostgreSQL Co= mpany


On Tue, Jan 22, 2019 at 4:29 PM Akshay Joshi <akshay.joshi@enterprisedb.= com> wrote:
Thanks patch applied.

On Tue, Jan 22, 2019 at 2:51 PM Khushboo Vashi <khushboo.= vashi@enterprisedb.com> wrote:
The patch looks good to me.
On Mon, Jan 21, 2019 at 4:39 PM Akshay Joshi <akshay.joshi@enterprisedb.com<= /a>> wrote:
<= div dir=3D"ltr">Hi Khushboo=C2=A0

Can you please review = it.

On Wed, Jan 16, 2019 at 12:55 P= M Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

=
Please find attached updated patch.
In this patch I ha= ve fixed two issues:
i. Dialog tab navigation should work even if= focus is on footer buttons (Save, Cancel, etc..)
ii. Focus shoul= d be set to first editable element of dialog when tab cycle goes through al= l editable footer buttons.


--=C2=A0
Harshal Dhumal
Sr. Software Engineer

EnterpriseDB India:=C2=A0= http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>


On Thu, Jan 10, 2019 at 1:16 PM Harshal Dhumal <harshal.dhumal@enterp= risedb.com> wrote:
Hi,
This patch = fixes=C2=A0Dialog tabset keyboard navigation.
This regression was= caused due to bootstrap 4 changes.
Also I have added jasmine tes= t cases for the same


--=C2=A0
Ha= rshal Dhumal
Sr. Software Engineer

Enterp= riseDB India:=C2=A0http://www.enterp= risedb.com
The Enterprise PostgreSQL = Company


--
Akshay Joshi
= Sr. Software Architect
=


Phone: +91 20-3058-9517<= br>Mobile: +91 976-788-8246


--
= Akshay Joshi
Sr. Software Architect

=

<= /font>
Phon= e: +91 20-3058-9517
Mobile: +91 976-788-8246


--
Akshay Joshi
Sr. S= oftware Architect
=

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246=
--00000000000083474b058032cc7d--