Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihUMC-00061h-Dk for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 08:06:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ihUMB-0001zh-7U for pgadmin-hackers@arkaria.postgresql.org; Wed, 18 Dec 2019 08:06:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihUMA-0001za-Vz for pgadmin-hackers@lists.postgresql.org; Wed, 18 Dec 2019 08:06:55 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ihUM8-0003BX-QP for pgadmin-hackers@postgresql.org; Wed, 18 Dec 2019 08:06:54 +0000 Received: by mail-io1-xd41.google.com with SMTP id f82so1010986ioa.9 for ; Wed, 18 Dec 2019 00:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8+CJSMWHgLGAEvrzYF4lSE4GeKwAP8V9M2nPjatX37Y=; b=nS52ngk4AYnEJ/hjfBe4crhQU7ghnNRe9lh6p1Q0qIQvmdO8AGZt4wh6gY6VtYKzzv bDESqv1t7VsS3YhINcsBKWuw8vGpwVQIwawzVq3rmsim3vdi3uocW/qnWh8qXBTWSyTo Vri1s+zZCfVW+OEnjQ85tOASf0E7SyyHBumKNA9ED9s/Qmwo+LnqFLyfwOebEQHOko+0 5KXV5VqorrHt91Hww/2y9cHt7v9j8Xhh64NMk6NWqi/qT+VfX3EiCdCrBuIwVsjLWFpQ MkpsNbhtHY5IkQxhJ0g40oGYTJmHRprU9BETNWW1unwGp05DokqvTZWJ48EnfY8b9TRK UARg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8+CJSMWHgLGAEvrzYF4lSE4GeKwAP8V9M2nPjatX37Y=; b=aNytX0GW9Xpk/s3QfXcNRaeUjOAWlaWKkmO/8OkO1DoRSdGTMc3kVyy7D9Y89ljmcQ tvLT6pU52gJh/pawt2hnnU+VjMTlboXjTPMzKavSdCZCmp5quK45yFt2ILhJcb1tvO3D 8UJsRPmn6LLxzoXcbdjRE3bBNTMDT4e0ihi6+/9ydBOxTBhmXLPvEoX0jrrsBJfUwr+B CHJMgucyqzTSWokqvM7ZtjLy5G1KqJDzhc7wvMuCNyangPglk6aOqw7QAzoNGv0HLEiz 10lEZRR7E1JnN+2PJReEp1xhTLvw2GbdLJpZoZXON+xsgX/nUez5zahnjGfc9pbvCP6u uOJA== X-Gm-Message-State: APjAAAUO7nRkWJTvglgmoQJd2Kb3l3QCsbeSwqvZ+i8R+Q6sicB6Uf96 3z2cvBicKBwqIqar5ww9aXzYz25vxjXBrBvLGw6gBc8W7ifVNunrHquXLaud6KgXYJoPG5adHzp lAzNw8qvTgodUgi6/siNPCVB6JVDhwlPU97Edp6KalpFOWUWnb8uXJmuE4T0IAYkZ3az90UbRtp ypMzRTQKtD+/E6q0tvLVw+X9AoinNChS06s3Ttj4R1mH7bS+g0u4E= X-Google-Smtp-Source: APXvYqxGwNct687Dja4dw4MLLIPv+tcl9sb06PfmoZMFivpHrQ5LXhHn0LzrIZSMvmgWKBjCS78pE5gQdJb9XGfnTgk= X-Received: by 2002:a6b:ec08:: with SMTP id c8mr657841ioh.257.1576656410946; Wed, 18 Dec 2019 00:06:50 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Wed, 18 Dec 2019 13:36:39 +0530 Message-ID: Subject: Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4 To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004ec0220599f5ed7e" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004ec0220599f5ed7e Content-Type: text/plain; charset="UTF-8" Thanks, patch applied. On Wed, Dec 18, 2019 at 1:12 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Hackers, > > Had couple of typos in the previous patch. Although the edit types were > passed to the front end, they were not filtered and all the types were > displayed in edit table dialog. > Kindly find the patch to fix it. > > On Mon, Dec 16, 2019 at 6:54 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached patch which is related to RM4988, reduces the number of hits to edit_mode_types.sql >>> (an expensive one). >>> Currently, this is query is executed for every column one by one when >>> table properties dialog is opened. I've added edit_mode_types_bulk.sql, >>> which will fetch the edit types for all the distinct column types used in >>> the table in a single DB trip and use that data for each column. >>> Also, while generating RE-SQL for columns, edit_mode_types.sql will not >>> be executed. >>> This will definitely reduce time. >>> >>> Kindly review. >>> >>> -- >>> Thanks and Regards, >>> Aditya Toshniwal >>> Sr. Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* --0000000000004ec0220599f5ed7e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, patch applied.

On Wed, Dec 18, 2019 at 1:12 PM Adit= ya Toshniwal <adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,
<= div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">
H= ad couple of typos in the previous patch. Although the edit types were pass= ed to the front end, they were not filtered and all the types were displaye= d in edit table dialog.
Kindly find the patch to fix it.

On Mon, Dec 1= 6, 2019 at 6:54 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
T= hanks, patch applied.

On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal <<= a href=3D"mailto:aditya.toshniwal@enterprisedb.com" target=3D"_blank">adity= a.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Att= ached patch which is related to RM4988, reduces the number of hits to=C2=A0= edit_mode_types.= sql (an expensive one).
Currently, this is query is executed for every column one by one = when table properties dialog is opened. I've added=C2=A0edit_mode_types_bulk.sql= , which will fetch the edit types for all the distinct column types used in= the table in a single DB trip and use that data for each column.
Also, while generating = RE-SQL for columns,=C2=A0e= dit_mode_types.sql will not be executed.
This will definitely reduce time.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer |=C2=A0Ente= rpriseDB India |=C2=A0Pune
"Don't Complain about Heat, Plant a TREE"<= /div>


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards
=
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
=
Mobile: += 91 976-788-8246
--0000000000004ec0220599f5ed7e--