Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maEBg-0004cF-W5 for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Oct 2021 09:35:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1maEBd-0007e6-6t for pgadmin-hackers@arkaria.postgresql.org; Tue, 12 Oct 2021 09:35:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1maEBc-0007bZ-LP for pgadmin-hackers@lists.postgresql.org; Tue, 12 Oct 2021 09:35:05 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1maEBa-00016s-3U for pgadmin-hackers@postgresql.org; Tue, 12 Oct 2021 09:35:04 +0000 Received: by mail-il1-x12b.google.com with SMTP id d11so21004993ilc.8 for ; Tue, 12 Oct 2021 02:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+5/h3TKhefWZlpx9P11V6mpRhxYO7ms6cWoBYHp5LDI=; b=XJjBte08hGwYdvgIloTaqR5jkt5S9IjK6w9Pi4j3Qxvl9mtskl4UvwKTL92OATNGGD VPvtRdKP8AJ43cnH0KXdlUyrboEvIklYTPVCSr4crGAk1sDtjU8GI9Km1uDvi68Jku/K cMxOQjyOYt6frm2rOut70dm6x+cKglbTlFqxGZxqDK7VRAQ4Fd6MR/iycy7GO7cIap7Z czLjJJMrF3NhM64Xy79BKHcbapvjqr+Ik7kyQNrxPEhyCrQtlb85I3aZ9DrdrwBrATzT 0uss2O46YvtOGORJ/8GXSK5Q66WBeZUtQyezoQxwkNmyfkbGJ22N17xeUvF60lYo+rqZ QPQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+5/h3TKhefWZlpx9P11V6mpRhxYO7ms6cWoBYHp5LDI=; b=LSP1hyBp7kQJ83AEp8Ss9Fa8xDqSbh0kJuSH3aar9MT628I4q6LVAQA4noORqodhTr vMDBMKcDAj4POchZ+EQwaw/pe6I/2LbldRCNbUIZ/MepiXqN9ne+2d2cKc/8n05sXWFs ZI8B9KppZ04sQOpUw/EEwlypIKKuAygLM8kWFsNelMSb8fNvj/Xw1QVgUT8qiwNCokmu Q22Qa7KjHSRvh8SJRENwjf6a3pxDpIkO+Tj8TeO5PSnLsQAXBItMtji1ON8XpdsQiZYF UFy2omslow0njrZcCHJvpd1gh1w0/UslS5UEutEpVCLM6/TTOtWugpvxCvu7juc8eF2K oOAQ== X-Gm-Message-State: AOAM531OOJrP7mYBUbDWj3traDOGFUzaMImSWvD4/hhnJkHrD+9QYjS4 NaWh7mEW1NxgTMFS/qJtSQXgrM5aVZzfEugQ/1obYlDKpBcyZTmjzolcqm9AiMUUuVHFDMH+Y2b ObADezYreuEbP9p3LqsjVXyjK9yiCOa1v05FBkHkBs2gS97dAJDIu13WYkIS+dE5mObcR9r3+8C gGq0wmU31RcyPhtN8+cO/IxeXMd+t7gnvrajDaPtGPNOt8H7nKWHu2T/LiPw== X-Google-Smtp-Source: ABdhPJyCxKGBiNLoqbrqGXxMq/ZMcorQgaR2P8+cn8xBTF+oY+vNTQWw0Dnl6Mis/tkSIC7FW3GP+h9Lv1qHkkcwJ+Q= X-Received: by 2002:a05:6e02:148e:: with SMTP id n14mr3652434ilk.178.1634031300209; Tue, 12 Oct 2021 02:35:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Akshay Joshi Date: Tue, 12 Oct 2021 15:04:49 +0530 Message-ID: Subject: Re: [pgAdmin][RM6081] Advanced table fields in ERD To: Aditya Toshniwal Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000003388da05ce248f6b" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000003388da05ce248f6b Content-Type: text/plain; charset="UTF-8" Thanks, the patch applied. On Tue, Oct 12, 2021 at 11:36 AM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi, > > Please review the attached patch to fix failing API test case. > > On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal < >> aditya.toshniwal@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached patch will port Backbone based dialogs in ERD to React based >>> using the schema view UI framework. This allows us to use the existing >>> table UI, remove repeated code and enable advanced fields. I have hidden >>> fields from the existing table UI for ERD. >>> Please note, this also fixes #6529. >>> >>> Please review. >>> >>> -- >>> Thanks, >>> Aditya Toshniwal >>> pgAdmin Hacker | Software Architect | *edbpostgres.com* >>> >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks, > Aditya Toshniwal > pgAdmin Hacker | Software Architect | *edbpostgres.com* > > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246* --0000000000003388da05ce248f6b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 11:36 AM= Aditya Toshniwal <= aditya.toshniwal@enterprisedb.com> wrote:
Hi,

Please review the att= ached patch to fix=C2=A0failing API test case.

On Mon, Oct 11, 2021 at= 5:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the= patch applied.

On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal <aditya.tos= hniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached=C2=A0patch wi= ll port Backbone based dialogs in ERD to React based using the schema view = UI framework. This allows us to use the existing table UI, remove repeated = code and enable advanced fields. I have hidden fields from the existing tab= le UI for ERD.
Please=C2=A0note, this also fixes #6529.

Please review.=

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker= =C2=A0| Software Architect=C2=A0| <= b>edbpostgres.com
"Don't Complain about H= eat, Plant a TREE"


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal=
pgAdmin Hacker=C2=A0| Software Architect=C2=A0| = edbpostgres.com
=
&q= uot;Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmi= n Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

--0000000000003388da05ce248f6b--